ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-05-09 10:41:31 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

helper: raise Exception when ds is not dict type (#53936)

Browse source 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
This commit is contained in:
Abhijeet Kasurde 2019-03-25 11:18:33 +05:30 • committed by GitHub
parent 19e1b4de58
commit 83be129923
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/ansible/playbook/helpers.py
View file

@ -102,7 +102,7 @@ def load_list_of_tasks(ds, play, block=None, role=None, task_include=None, use_h
task_list = [] task_list = []
for task_ds in ds: for task_ds in ds:
if not isinstance(task_ds, dict): if not isinstance(task_ds, dict):
AnsibleAssertionError('The ds (%s) should be a dict but was a %s' % (ds, type(ds))) raise AnsibleAssertionError('The ds (%s) should be a dict but was a %s' % (ds, type(ds)))
if 'block' in task_ds: if 'block' in task_ds:
t = Block.load( t = Block.load(

5
test/units/playbook/test_helpers.py
View file

@ -97,6 +97,11 @@ class TestLoadListOfTasks(unittest.TestCase, MixinForMocks):
self.assertRaises(AssertionError, helpers.load_list_of_tasks, self.assertRaises(AssertionError, helpers.load_list_of_tasks,
ds, self.mock_play, block=None, role=None, task_include=None, use_handlers=False, variable_manager=None, loader=None) ds, self.mock_play, block=None, role=None, task_include=None, use_handlers=False, variable_manager=None, loader=None)
def test_ds_not_dict(self):
ds = [[]]
self.assertRaises(AssertionError, helpers.load_list_of_tasks,
ds, self.mock_play, block=None, role=None, task_include=None, use_handlers=False, variable_manager=None, loader=None)
def test_empty_task(self): def test_empty_task(self):
ds = [{}] ds = [{}]
self.assertRaisesRegexp(errors.AnsibleParserError, self.assertRaisesRegexp(errors.AnsibleParserError,