More validate module fixes (#39097)

* Fix type bool DOCUMENTATION issues

lib/ansible/modules/cloud/amazon/aws_application_scaling_policy.py

@@ -70,7 +70,7 @@ options:
         description: Whether or not to override values of minimum and/or maximum tasks if it's already set.
         required: no
         default: no
-        choices: [ 'yes', 'no' ]
+        type: bool
         version_added: "2.6"
 extends_documentation_fragment:
     - aws

lib/ansible/modules/cloud/amazon/aws_direct_connect_connection.py

@@ -57,6 +57,7 @@ options:
     description:
       - To modify bandwidth or location the connection will need to be deleted and recreated.
         By default this will not happen - this option must be set to True.
+    type: bool
 """
 
 EXAMPLES = """

lib/ansible/modules/cloud/amazon/cloudfront_distribution.py

@@ -67,7 +67,7 @@ options:
           specified. If no tags are specified, it removes all existing tags for the distribution. When I(purge_tags=no), existing tags are kept and I(tags)
           are added, if specified.
       default: 'no'
-      choices: ['yes', 'no']
+      type: bool
 
     alias:
       description:
@@ -85,7 +85,7 @@ options:
         - Specifies whether existing aliases will be removed before adding new aliases. When I(purge_aliases=yes), existing aliases are removed and I(aliases)
           are added.
       default: 'no'
-      choices: ['yes', 'no']
+      type: bool
 
     default_root_object:
       description:
@@ -245,7 +245,7 @@ options:
       description:
         - A boolean value that specifies whether the distribution is enabled or disabled.
       default: 'yes'
-      choices: ['yes', 'no']
+      type: bool
 
     viewer_certificate:
       description:
@@ -280,13 +280,13 @@ options:
     ipv6_enabled:
       description:
         - Determines whether IPv6 support is enabled or not.
-      choices: ['yes', 'no']
+      type: bool
       default: 'no'
 
     wait:
       description:
         - Specifies whether the module waits until the distribution has completed processing the creation or update.
-      choices: ['yes', 'no']
+      type: bool
       default: 'no'
 
     wait_timeout:

lib/ansible/modules/cloud/amazon/ec2_ami.py

@@ -44,7 +44,7 @@ options:
     description:
       - Wait for the AMI to be in state 'available' before returning.
     default: "no"
-    choices: [ "yes", "no" ]
+    type: bool
   wait_timeout:
     description:
       - How long before wait gives up, in seconds.
@@ -62,7 +62,7 @@ options:
       - Flag indicating that the bundling process should not attempt to shutdown the instance before bundling. If this flag is True, the
         responsibility of maintaining file system integrity is left to the owner of the instance.
     default: no
-    choices: [ "yes", "no" ]
+    type: bool
   image_id:
     description:
       - Image ID to be deregistered.
@@ -77,7 +77,7 @@ options:
     description:
       - Delete snapshots when deregistering the AMI.
     default: "no"
-    choices: [ "yes", "no" ]
+    type: bool
   tags:
     description:
       - A dictionary of tags to add to the new image; '{"key":"value"}' and '{"key":"value","key":"value"}'

lib/ansible/modules/cloud/amazon/ec2_ami_facts.py

@@ -39,7 +39,7 @@ options:
     description:
       - Describe attributes (like launchPermission) of the images found.
     default: no
-    choices: ["yes", "no"]
+    type: bool
 
 extends_documentation_fragment:
     - aws

lib/ansible/modules/cloud/amazon/ec2_eni.py

@@ -64,6 +64,7 @@ options:
         won't change
     default: 'yes'
     version_added: 2.2
+    type: bool
   force_detach:
     description:
       - Force detachment of the interface. This applies either when explicitly detaching the interface by setting instance_id

lib/ansible/modules/cloud/amazon/ec2_group.py

@@ -100,7 +100,7 @@ options:
         tags will not be modified.
     required: false
     default: yes
-    choices: [ 'yes', 'no' ]
+    type: bool
 
 extends_documentation_fragment:
     - aws

lib/ansible/modules/cloud/amazon/ec2_snapshot.py

@@ -43,7 +43,7 @@ options:
   wait:
     description:
       - wait for the snapshot to be ready
-    choices: ['yes', 'no']
+    type: bool
     required: false
     default: yes
     version_added: "1.5.1"

lib/ansible/modules/cloud/amazon/ec2_vpc_endpoint.py

@@ -62,7 +62,7 @@ options:
         behaviour from AWS.
     required: false
     default: no
-    choices: ["yes", "no"]
+    type: bool
   wait_timeout:
     description:
       - Used in conjunction with wait. Number of seconds to wait for status.

lib/ansible/modules/cloud/amazon/ec2_vpc_net.py

@@ -35,7 +35,7 @@ options:
     description:
       - Remove CIDRs that are associated with the VPC and are not specified in C(cidr_block).
     default: no
-    choices: [ 'yes', 'no' ]
+    type: bool
     version_added: '2.5'
   tenancy:
     description:
@@ -46,12 +46,12 @@ options:
     description:
       - Whether to enable AWS DNS support.
     default: yes
-    choices: [ 'yes', 'no' ]
+    type: bool
   dns_hostnames:
     description:
       - Whether to enable AWS hostname support.
     default: yes
-    choices: [ 'yes', 'no' ]
+    type: bool
   dhcp_opts_id:
     description:
       - the id of the DHCP options to use for this vpc

lib/ansible/modules/cloud/amazon/ecs_service_facts.py

@@ -27,13 +27,13 @@ options:
             - Set this to true if you want detailed information about the services.
         required: false
         default: 'false'
-        choices: ['true', 'false']
+        type: bool
     events:
         description:
             - Whether to return ECS service events. Only has an effect if C(details) is true.
         required: false
         default: 'true'
-        choices: ['true', 'false']
+        type: bool
         version_added: "2.6"
     cluster:
         description:

lib/ansible/modules/cloud/amazon/elb_application_lb.py

@@ -32,7 +32,7 @@ options:
     description:
       - "Whether or not to enable access logs. When true, I(access_logs_s3_bucket) must be set."
     required: false
-    choices: [ 'yes', 'no' ]
+    type: bool
   access_logs_s3_bucket:
     description:
       - The name of the S3 bucket for the access logs. This attribute is required if access logs in Amazon S3 are enabled. The bucket must exist in the same
@@ -47,7 +47,7 @@ options:
       - Indicates whether deletion protection for the ELB is enabled.
     required: false
     default: no
-    choices: [ 'yes', 'no' ]
+    type: bool
   idle_timeout:
     description:
       - The number of seconds to wait before an idle connection is closed.
@@ -68,14 +68,14 @@ options:
       - If yes, existing listeners will be purged from the ELB to match exactly what is defined by I(listeners) parameter. If the I(listeners) parameter is
         not set then listeners will not be modified
     default: yes
-    choices: [ 'yes', 'no' ]
+    type: bool
   purge_tags:
     description:
       - If yes, existing tags will be purged from the resource to match exactly what is defined by I(tags) parameter. If the I(tags) parameter is not set then
         tags will not be modified.
     required: false
     default: yes
-    choices: [ 'yes', 'no' ]
+    type: bool
   subnets:
     description:
       - A list of the IDs of the subnets to attach to the load balancer. You can specify only one subnet per Availability Zone. You must specify subnets from

lib/ansible/modules/cloud/amazon/elb_target.py

@@ -19,7 +19,7 @@ options:
     description:
       - The default behaviour for targets that are unused is to leave them registered. If instead you would like to remove them
         set I(deregister_unused) to yes.
-    choices: [ 'yes', 'no' ]
+    type: bool
   target_az:
     description:
       - An Availability Zone or all. This determines whether the target receives traffic from the load balancer nodes in the specified

lib/ansible/modules/cloud/amazon/elb_target_group.py

@@ -78,7 +78,7 @@ options:
         tags will not be modified.
     required: false
     default: yes
-    choices: [ 'yes', 'no' ]
+    type: bool
   state:
     description:
       - Create or destroy the target group.
@@ -87,7 +87,7 @@ options:
   stickiness_enabled:
     description:
       - Indicates whether sticky sessions are enabled.
-    choices: [ 'yes', 'no' ]
+    type: bool
   stickiness_lb_cookie_duration:
     description:
       - The time period, in seconds, during which requests from a client should be routed to the same target. After this time period expires, the load