Improve CI (#3348)

* Remove superfluous test.

* Use remote_temp_dir instead of output_dir on remote.

* Read certificate from correct place.

* Adjust more places.

* Fix boolean.

* Improve cryptography setup.

* Fix java_keystore changes.

* Need to copy binary from remote.

* Use correct Python for serve script.

* Sleep before downloading.

* Use correct Python interpreter.

* Avoid failing shebang test.

* Fix permission error with macOS 11.1.

* Avoid shebang trouble.

tests/integration/targets/consul/meta/main.yml

@@ -2,3 +2,4 @@
 dependencies:
   - setup_pkg_mgr
   - setup_openssl
+  - setup_remote_tmp_dir

tests/integration/targets/consul/tasks/main.yml

@@ -7,7 +7,7 @@
   vars:
     consul_version: 1.5.0
     consul_uri: https://s3.amazonaws.com/ansible-ci-files/test/integration/targets/consul/consul_{{ consul_version }}_{{ ansible_system | lower }}_{{ consul_arch }}.zip
-    consul_cmd: '{{ output_dir }}/consul'
+    consul_cmd: '{{ remote_tmp_dir }}/consul'
   block:
   - name: register pyOpenSSL version
     command: '{{ ansible_python_interpreter }} -c ''import OpenSSL; print(OpenSSL.__version__)'''
@@ -27,19 +27,19 @@
     block:
     - name: Generate privatekey
       community.crypto.openssl_privatekey:
-        path: '{{ output_dir }}/privatekey.pem'
+        path: '{{ remote_tmp_dir }}/privatekey.pem'
     - name: Generate CSR
       community.crypto.openssl_csr:
-        path: '{{ output_dir }}/csr.csr'
-        privatekey_path: '{{ output_dir }}/privatekey.pem'
+        path: '{{ remote_tmp_dir }}/csr.csr'
+        privatekey_path: '{{ remote_tmp_dir }}/privatekey.pem'
         subject:
           commonName: localhost
     - name: Generate selfsigned certificate
       register: selfsigned_certificate
       community.crypto.openssl_certificate:
-        path: '{{ output_dir }}/cert.pem'
-        csr_path: '{{ output_dir }}/csr.csr'
-        privatekey_path: '{{ output_dir }}/privatekey.pem'
+        path: '{{ remote_tmp_dir }}/cert.pem'
+        csr_path: '{{ remote_tmp_dir }}/csr.csr'
+        privatekey_path: '{{ remote_tmp_dir }}/privatekey.pem'
         provider: selfsigned
         selfsigned_digest: sha256
   - name: Install unzip
@@ -59,21 +59,21 @@
   - name: Download consul binary
     unarchive:
       src: '{{ consul_uri }}'
-      dest: '{{ output_dir }}'
+      dest: '{{ remote_tmp_dir }}'
       remote_src: true
     register: result
     until: result is success
   - vars:
-      remote_dir: '{{ echo_output_dir.stdout }}'
+      remote_dir: '{{ echo_remote_tmp_dir.stdout }}'
     block:
-    - command: echo {{ output_dir }}
-      register: echo_output_dir
+    - command: echo {{ remote_tmp_dir }}
+      register: echo_remote_tmp_dir
     - name: Create configuration file
       template:
         src: consul_config.hcl.j2
-        dest: '{{ output_dir }}/consul_config.hcl'
+        dest: '{{ remote_tmp_dir }}/consul_config.hcl'
     - name: Start Consul (dev mode enabled)
-      shell: nohup {{ consul_cmd }} agent -dev -config-file {{ output_dir }}/consul_config.hcl </dev/null >/dev/null 2>&1 &
+      shell: nohup {{ consul_cmd }} agent -dev -config-file {{ remote_tmp_dir }}/consul_config.hcl </dev/null >/dev/null 2>&1 &
     - name: Create some data
       command: '{{ consul_cmd }} kv put data/value{{ item }} foo{{ item }}'
       loop:
@@ -83,5 +83,5 @@
     - import_tasks: consul_session.yml
     always:
     - name: Kill consul process
-      shell: kill $(cat {{ output_dir }}/consul.pid)
+      shell: kill $(cat {{ remote_tmp_dir }}/consul.pid)
       ignore_errors: true