ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-22 21:00:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Enhance empty __init__ code-smell to check module_utils (#33438)

Browse source 
Empty __init__ will allow us to use python namespaces with all of these
files.  That may be something we want to take advantage of for allowign
them to be expanded by user dirs.  Also might be needed for AnsiballZ or
other wrapper enhancements in the future.
This commit is contained in:
Toshio Kuratomi 2017-11-30 15:47:38 -08:00 • committed by GitHub
commit 7bd0af15d2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

7
test/sanity/code-smell/empty-init.sh
View file

@ -2,8 +2,11 @@
found=''
for path in lib/ansible/modules/ test/units/; do
files=$(find "${path}" -name __init__.py -size '+0')
for path in lib/ansible/modules/ lib/ansible/module_utils test/units/; do
# facts is grandfathered in but will break namespacing. Only way to fix it
# is to deprecate and eventually remove.
# six will break namespacing but because it is bundled we should not be overriding it
files=$(find "${path}" -name __init__.py -size '+0' | sed '\!lib/ansible/module_utils/\(six\|facts\)/__init__.py!d')
if [ "${files}" ]; then
echo "${files}"