Cliconf and Netconf refactoring iosxr_interface (#33909)

* Cliconf and Netconf refactoring iosxr_interface

* adds `xml` key and related changes for netconf output

* * review comments changes
This commit is contained in:
Kedar Kekan 2017-12-20 13:06:07 +05:30 committed by GitHub
parent 8a9865cb10
commit 78a14d7966
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 875 additions and 227 deletions

View file

@ -1,2 +1,3 @@
---
- { include: cli.yaml, tags: ['cli'] }
- { include: netconf.yaml, tags: ['netconf'] }

View file

@ -0,0 +1,16 @@
---
- name: collect all netconf test cases
find:
paths: "{{ role_path }}/tests/netconf"
patterns: "{{ testcase }}.yaml"
register: test_cases
delegate_to: localhost
- name: set test_items
set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"
- name: run test case
include: "{{ test_case_to_run }}"
with_items: "{{ test_items }}"
loop_control:
loop_var: test_case_to_run

View file

@ -0,0 +1,281 @@
---
- debug: msg="START iosxr_interface netconf/basic.yaml"
- name: Enable Netconf service
iosxr_netconf:
netconf_port: 830
netconf_vrf: 'default'
state: present
register: result
- name: Setup interface
iosxr_interface:
name: GigabitEthernet0/0/0/1
state: absent
provider: "{{ netconf }}"
register: result
- name: Confgure interface
iosxr_interface:
name: GigabitEthernet0/0/0/1
description: test-interface-initial
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- '"GigabitEthernet0/0/0/1" in result.xml[0]'
- name: Confgure interface (idempotent)
iosxr_interface:
name: GigabitEthernet0/0/0/1
description: test-interface-initial
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == false'
- name: Confgure interface parameters
iosxr_interface:
name: GigabitEthernet0/0/0/1
description: test-interface
speed: 100
duplex: half
mtu: 512
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- '"GigabitEthernet0/0/0/1" in result.xml[0]'
- '"test-interface" in result.xml[0]'
- '"100" in result.xml[0]'
- '"512" in result.xml[0]'
- name: Change interface parameters
iosxr_interface:
name: GigabitEthernet0/0/0/1
description: test-interface-1
speed: 10
duplex: full
mtu: 256
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- '"GigabitEthernet0/0/0/1" in result.xml[0]'
- '"test-interface-1" in result.xml[0]'
- '"10" in result.xml[0]'
- '"256" in result.xml[0]'
- name: Change interface parameters (idempotent)
iosxr_interface:
name: GigabitEthernet0/0/0/1
description: test-interface-1
speed: 10
duplex: full
mtu: 256
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == false'
- name: Disable interface
iosxr_interface:
name: GigabitEthernet0/0/0/1
enabled: False
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- name: Enable interface
iosxr_interface:
name: GigabitEthernet0/0/0/1
enabled: True
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- name: Confgure second interface (setup)
iosxr_interface:
name: GigabitEthernet0/0/0/0
description: test-interface-initial
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- '"GigabitEthernet0/0/0/0" in result.xml[0]'
- name: Delete interface aggregate (setup)
iosxr_interface:
aggregate:
- name: GigabitEthernet0/0/0/0
- name: GigabitEthernet0/0/0/1
state: absent
provider: "{{ netconf }}"
- name: Add interface aggregate
iosxr_interface:
aggregate:
- { name: GigabitEthernet0/0/0/0, mtu: 256, description: test-interface-1 }
- { name: GigabitEthernet0/0/0/1, mtu: 516, description: test-interface-2 }
speed: 100
duplex: full
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- '"GigabitEthernet0/0/0/1" in result.xml[0]'
- '"GigabitEthernet0/0/0/0" in result.xml[0]'
- name: Add interface aggregate (idempotent)
iosxr_interface:
aggregate:
- { name: GigabitEthernet0/0/0/0, mtu: 256, description: test-interface-1 }
- { name: GigabitEthernet0/0/0/1, mtu: 516, description: test-interface-2 }
speed: 100
duplex: full
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == false'
- name: Disable interface aggregate
iosxr_interface:
aggregate:
- name: GigabitEthernet0/0/0/0
- name: GigabitEthernet0/0/0/1
enabled: False
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- name: Disable interface aggregate (idempotent)
iosxr_interface:
aggregate:
- name: GigabitEthernet0/0/0/0
- name: GigabitEthernet0/0/0/1
enabled: False
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == false'
- name: Enable interface aggregate
iosxr_interface:
aggregate:
- name: GigabitEthernet0/0/0/0
- name: GigabitEthernet0/0/0/1
enabled: True
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- name: Enable interface aggregate
iosxr_interface:
aggregate:
- name: GigabitEthernet0/0/0/0
- name: GigabitEthernet0/0/0/1
enabled: True
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == false'
- name: interface aggregate (setup)
iosxr_interface:
aggregate:
- name: GigabitEthernet0/0/0/0
- name: GigabitEthernet0/0/0/1
description: test-interface-initial
provider: "{{ netconf }}"
register: result
- name: Create interface aggregate
iosxr_interface:
aggregate:
- name: GigabitEthernet0/0/0/0
description: test_interface_1
- name: GigabitEthernet0/0/0/1
description: test_interface_2
state: present
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- '"GigabitEthernet0/0/0/0" in result.xml[0]'
- '"GigabitEthernet0/0/0/1" in result.xml[0]'
- '"test_interface_1" in result.xml[0]'
- '"test_interface_2" in result.xml[0]'
- name: Delete interface aggregate
iosxr_interface:
aggregate:
- name: GigabitEthernet0/0/0/0
- name: GigabitEthernet0/0/0/1
state: absent
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == true'
- name: Delete interface aggregate (idempotent)
iosxr_interface:
aggregate:
- name: GigabitEthernet0/0/0/0
- name: GigabitEthernet0/0/0/1
state: absent
provider: "{{ netconf }}"
register: result
- assert:
that:
- 'result.changed == false'
- debug: msg="END iosxr_interface netconf/basic.yaml"

View file

@ -0,0 +1,78 @@
---
- debug: msg="START iosxr_interface netconf/intent.yaml"
- name: Setup (interface is up)
iosxr_interface:
name: GigabitEthernet0/0/0/1
description: test_interface_1
enabled: True
state: present
provider: "{{ netconf }}"
register: result
- name: Check intent arguments
iosxr_interface:
name: GigabitEthernet0/0/0/1
state: up
delay: 10
provider: "{{ netconf }}"
register: result
- assert:
that:
- "result.failed == false"
- name: Check intent arguments (failed condition)
iosxr_interface:
name: GigabitEthernet0/0/0/1
state: down
provider: "{{ netconf }}"
ignore_errors: yes
register: result
- assert:
that:
- "result.failed == true"
- "'state eq(down)' in result.failed_conditions"
- name: Config + intent
iosxr_interface:
name: GigabitEthernet0/0/0/1
enabled: False
state: down
delay: 10
provider: "{{ netconf }}"
register: result
- assert:
that:
- "result.failed == false"
- name: Config + intent (fail)
iosxr_interface:
name: GigabitEthernet0/0/0/1
enabled: False
state: up
provider: "{{ netconf }}"
ignore_errors: yes
register: result
- assert:
that:
- "result.failed == true"
- "'state eq(up)' in result.failed_conditions"
- name: Aggregate config + intent (pass)
iosxr_interface:
aggregate:
- name: GigabitEthernet0/0/0/1
enabled: True
state: up
delay: 10
provider: "{{ netconf }}"
ignore_errors: yes
register: result
- assert:
that:
- "result.failed == false"