ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-23 13:20:23 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

nmcli: module refactor (#1113)

Browse source 
* * Refactor `nmcli` module to use consistent parameters when creating/modifying connections and detecting changes.
* Keep DNS list arguments as lists internally.
* Remove duplicated code where practical.

* DBus and GObject dependencies are not necessary.

* Update changelog fragment.

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelog fragment.

Co-authored-by: Felix Fontein <felix@fontein.de>

* Use identity operator instead of equality for type comparison.

* Don't start changelog notes with a capital letter.

* * Have `settings_type` return `str` by default instead of `None`.
* Improve variable naming, use `convert_func` instead of `type_cast`.

* Revert new feature of allowing ethernet types as slaves.

* Bring back `list_connection_info` to list all connections with `nmcli con show`.

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
Justin Bronn 2020-10-22 23:13:39 -06:00 • committed by GitHub
commit 7722800561
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 389 additions and 1108 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/sanity/ignore-2.10.txt
View file

@ -840,8 +840,6 @@ plugins/modules/net_tools/nios/nios_zone.py validate-modules:invalid-ansiblemodu
plugins/modules/net_tools/nios/nios_zone.py validate-modules:parameter-alias-self
plugins/modules/net_tools/nios/nios_zone.py validate-modules:parameter-type-not-in-doc
plugins/modules/net_tools/nios/nios_zone.py validate-modules:undocumented-parameter
plugins/modules/net_tools/nmcli.py validate-modules:parameter-list-no-elements
plugins/modules/net_tools/nmcli.py validate-modules:parameter-type-not-in-doc
plugins/modules/net_tools/nsupdate.py validate-modules:parameter-list-no-elements
plugins/modules/net_tools/nsupdate.py validate-modules:parameter-type-not-in-doc
plugins/modules/net_tools/omapi_host.py validate-modules:parameter-list-no-elements

2
tests/sanity/ignore-2.11.txt
View file

@ -840,8 +840,6 @@ plugins/modules/net_tools/nios/nios_zone.py validate-modules:invalid-ansiblemodu
plugins/modules/net_tools/nios/nios_zone.py validate-modules:parameter-alias-self
plugins/modules/net_tools/nios/nios_zone.py validate-modules:parameter-type-not-in-doc
plugins/modules/net_tools/nios/nios_zone.py validate-modules:undocumented-parameter
plugins/modules/net_tools/nmcli.py validate-modules:parameter-list-no-elements
plugins/modules/net_tools/nmcli.py validate-modules:parameter-type-not-in-doc
plugins/modules/net_tools/nsupdate.py validate-modules:parameter-list-no-elements
plugins/modules/net_tools/nsupdate.py validate-modules:parameter-type-not-in-doc
plugins/modules/net_tools/omapi_host.py validate-modules:parameter-list-no-elements

1
tests/sanity/ignore-2.9.txt
View file

@ -652,7 +652,6 @@ plugins/modules/net_tools/nios/nios_zone.py validate-modules:doc-default-does-no
plugins/modules/net_tools/nios/nios_zone.py validate-modules:doc-missing-type
plugins/modules/net_tools/nios/nios_zone.py validate-modules:parameter-type-not-in-doc
plugins/modules/net_tools/nios/nios_zone.py validate-modules:undocumented-parameter
plugins/modules/net_tools/nmcli.py validate-modules:parameter-type-not-in-doc
plugins/modules/net_tools/nsupdate.py validate-modules:parameter-type-not-in-doc
plugins/modules/notification/bearychat.py validate-modules:parameter-type-not-in-doc
plugins/modules/notification/campfire.py validate-modules:doc-missing-type