mirror of
https://github.com/ansible-collections/community.general.git
synced 2025-07-27 15:11:23 -07:00
Tidy up sanity checks (2021/Batch 3 - who's counting) (#1885)
* fixed validation-modules for plugins/modules/packaging/language/pip_package_info.py * fixed validation-modules for plugins/modules/packaging/language/maven_artifact.py * fixed validation-modules for plugins/modules/packaging/language/bundler.py * fixed validation-modules for plugins/modules/notification/pushbullet.py * fixed validation-modules for plugins/modules/monitoring/sensu/sensu_handler.py * fixed validation-modules for plugins/modules/monitoring/sensu/sensu_check.py * fixed validation-modules for plugins/modules/monitoring/sensu/sensu_client.py * fixed validation-modules for plugins/modules/monitoring/icinga2_host.py * fixed validation-modules for plugins/modules/monitoring/datadog/datadog_monitor.py * fixed validation-modules for plugins/modules/monitoring/datadog/datadog_event.py * fixed validation-modules for plugins/modules/clustering/znode.py * fixed validation-modules for plugins/modules/clustering/etcd3.py * fixed validation-modules for plugins/modules/clustering/consul/consul_session.py * fixed validation-modules for plugins/modules/clustering/consul/consul_kv.py * fixed validation-modules for plugins/modules/clustering/consul/consul.py * fixed validation-modules for plugins/modules/cloud/profitbricks/profitbricks.py * fixed validation-modules for plugins/modules/cloud/profitbricks/profitbricks_volume.py * fixed validation-modules for plugins/modules/cloud/packet/packet_sshkey.py * fixed validation-modules for plugins/modules/cloud/oneandone/oneandone_server.py * fixed validation-modules for plugins/modules/cloud/oneandone/oneandone_private_network.py * fixed validation-modules for plugins/modules/cloud/oneandone/oneandone_monitoring_policy.py * fixed validation-modules for plugins/modules/cloud/oneandone/oneandone_load_balancer.py * fixed validation-modules for plugins/modules/cloud/oneandone/oneandone_firewall_policy.py * fixed validation-modules for plugins/modules/cloud/webfaction/webfaction_app.py * fixed validation-modules for plugins/modules/cloud/webfaction/webfaction_db.py * fixed validation-modules for plugins/modules/cloud/webfaction/webfaction_domain.py * fixed validation-modules for plugins/modules/cloud/webfaction/webfaction_mailbox.py * fixed validation-modules for plugins/modules/cloud/webfaction/webfaction_site.py * fixed validation-modules for plugins/modules/remote_management/lxca/lxca_cmms.py * fixed validation-modules for plugins/modules/remote_management/lxca/lxca_nodes.py * missed one "elements" in sensu_handler * Tidy up batch of sanity checks ignore lines * missed lines in ignore-2.9.txt * fixed validation-modules for plugins/modules/clustering/consul/consul_acl.py * Update ignore-2.9.txt Removed consul_acl.py from ignore-2.9.txt * Apply suggestions from code review Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru> * Update plugins/modules/notification/pushbullet.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/cloud/oneandone/oneandone_monitoring_policy.py Co-authored-by: Felix Fontein <felix@fontein.de> * added changelog fragment * Update plugins/modules/cloud/oneandone/oneandone_monitoring_policy.py * Update changelogs/fragments/1885-sanity-check-fixes-batch3.yml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
This commit is contained in:
Alexei Znamensky
GitHub
parent
afe9d0fdb3
commit
76d9fe4ec6
35 changed files with 299 additions and 265 deletions
|
|
@ -56,6 +56,7 @@ options:
|
|||
- If not specified, it defaults to the remote system's hostname.
|
||||
tags:
|
||||
type: list
|
||||
elements: str
|
||||
description: ["Comma separated list of tags to apply to the event."]
|
||||
alert_type:
|
||||
type: str
|
||||
|
|
@ -114,17 +115,12 @@ def main():
|
|||
app_key=dict(required=True, no_log=True),
|
||||
title=dict(required=True),
|
||||
text=dict(required=True),
|
||||
date_happened=dict(required=False, default=None, type='int'),
|
||||
priority=dict(
|
||||
required=False, default='normal', choices=['normal', 'low']
|
||||
),
|
||||
host=dict(required=False, default=None),
|
||||
tags=dict(required=False, default=None, type='list'),
|
||||
alert_type=dict(
|
||||
required=False, default='info',
|
||||
choices=['error', 'warning', 'info', 'success']
|
||||
),
|
||||
aggregation_key=dict(required=False, default=None),
|
||||
date_happened=dict(type='int'),
|
||||
priority=dict(default='normal', choices=['normal', 'low']),
|
||||
host=dict(),
|
||||
tags=dict(type='list', elements='str'),
|
||||
alert_type=dict(default='info', choices=['error', 'warning', 'info', 'success']),
|
||||
aggregation_key=dict(),
|
||||
validate_certs=dict(default=True, type='bool'),
|
||||
)
|
||||
)
|
||||
|
|
|
|||
|
|
@ -46,6 +46,7 @@ options:
|
|||
- A list of tags to associate with your monitor when creating or updating.
|
||||
- This can help you categorize and filter monitors.
|
||||
type: list
|
||||
elements: str
|
||||
type:
|
||||
description:
|
||||
- The type of the monitor.
|
||||
|
|
@ -206,31 +207,30 @@ def main():
|
|||
module = AnsibleModule(
|
||||
argument_spec=dict(
|
||||
api_key=dict(required=True, no_log=True),
|
||||
api_host=dict(required=False),
|
||||
api_host=dict(),
|
||||
app_key=dict(required=True, no_log=True),
|
||||
state=dict(required=True, choices=['present', 'absent', 'mute', 'unmute']),
|
||||
type=dict(required=False, choices=['metric alert', 'service check', 'event alert',
|
||||
'process alert', 'log alert', 'query alert',
|
||||
'trace-analytics alert', 'rum alert']),
|
||||
type=dict(choices=['metric alert', 'service check', 'event alert', 'process alert',
|
||||
'log alert', 'query alert', 'trace-analytics alert', 'rum alert']),
|
||||
name=dict(required=True),
|
||||
query=dict(required=False),
|
||||
notification_message=dict(required=False, no_log=True, default=None, aliases=['message'],
|
||||
query=dict(),
|
||||
notification_message=dict(no_log=True, aliases=['message'],
|
||||
deprecated_aliases=[dict(name='message', version='3.0.0',
|
||||
collection_name='community.general')]), # was Ansible 2.14
|
||||
silenced=dict(required=False, default=None, type='dict'),
|
||||
notify_no_data=dict(required=False, default=False, type='bool'),
|
||||
no_data_timeframe=dict(required=False, default=None),
|
||||
timeout_h=dict(required=False, default=None),
|
||||
renotify_interval=dict(required=False, default=None),
|
||||
escalation_message=dict(required=False, default=None),
|
||||
notify_audit=dict(required=False, default=False, type='bool'),
|
||||
thresholds=dict(required=False, type='dict', default=None),
|
||||
tags=dict(required=False, type='list', default=None),
|
||||
locked=dict(required=False, default=False, type='bool'),
|
||||
require_full_window=dict(required=False, default=None, type='bool'),
|
||||
new_host_delay=dict(required=False, default=None),
|
||||
evaluation_delay=dict(required=False, default=None),
|
||||
id=dict(required=False),
|
||||
silenced=dict(type='dict'),
|
||||
notify_no_data=dict(default=False, type='bool'),
|
||||
no_data_timeframe=dict(),
|
||||
timeout_h=dict(),
|
||||
renotify_interval=dict(),
|
||||
escalation_message=dict(),
|
||||
notify_audit=dict(default=False, type='bool'),
|
||||
thresholds=dict(type='dict', default=None),
|
||||
tags=dict(type='list', elements='str', default=None),
|
||||
locked=dict(default=False, type='bool'),
|
||||
require_full_window=dict(type='bool'),
|
||||
new_host_delay=dict(),
|
||||
evaluation_delay=dict(),
|
||||
id=dict(),
|
||||
include_tags=dict(required=False, default=True, type='bool'),
|
||||
)
|
||||
)
|
||||
|
|
|
|||
|
|
@ -75,6 +75,7 @@ options:
|
|||
description:
|
||||
- Name used to create / delete the host. This does not need to be the FQDN, but does needs to be unique.
|
||||
required: true
|
||||
aliases: [host]
|
||||
zone:
|
||||
type: str
|
||||
description:
|
||||
|
|
|
|||
|
|
@ -49,11 +49,13 @@ options:
|
|||
- Path to the sensu check to run (not required when I(state=absent))
|
||||
handlers:
|
||||
type: list
|
||||
elements: str
|
||||
description:
|
||||
- List of handlers to notify when the check fails
|
||||
default: []
|
||||
subscribers:
|
||||
type: list
|
||||
elements: str
|
||||
description:
|
||||
- List of subscribers/channels this check should run for
|
||||
- See sensu_subscribers to subscribe a machine to a channel
|
||||
|
|
@ -86,9 +88,9 @@ options:
|
|||
- When to enable handling of check failures
|
||||
dependencies:
|
||||
type: list
|
||||
elements: str
|
||||
description:
|
||||
- Other checks this check depends on, if dependencies fail,
|
||||
- handling of this check will be disabled
|
||||
- Other checks this check depends on, if dependencies fail handling of this check will be disabled
|
||||
default: []
|
||||
metric:
|
||||
description:
|
||||
|
|
@ -327,15 +329,15 @@ def main():
|
|||
'state': {'type': 'str', 'default': 'present', 'choices': ['present', 'absent']},
|
||||
'backup': {'type': 'bool', 'default': 'no'},
|
||||
'command': {'type': 'str'},
|
||||
'handlers': {'type': 'list'},
|
||||
'subscribers': {'type': 'list'},
|
||||
'handlers': {'type': 'list', 'elements': 'str'},
|
||||
'subscribers': {'type': 'list', 'elements': 'str'},
|
||||
'interval': {'type': 'int'},
|
||||
'timeout': {'type': 'int'},
|
||||
'ttl': {'type': 'int'},
|
||||
'handle': {'type': 'bool'},
|
||||
'subdue_begin': {'type': 'str'},
|
||||
'subdue_end': {'type': 'str'},
|
||||
'dependencies': {'type': 'list'},
|
||||
'dependencies': {'type': 'list', 'elements': 'str'},
|
||||
'metric': {'type': 'bool', 'default': 'no'},
|
||||
'standalone': {'type': 'bool'},
|
||||
'publish': {'type': 'bool'},
|
||||
|
|
|
|||
|
|
@ -33,6 +33,7 @@ options:
|
|||
- If not specified it defaults to non-loopback IPv4 address as determined by Ruby Socket.ip_address_list (provided by Sensu).
|
||||
subscriptions:
|
||||
type: list
|
||||
elements: str
|
||||
description:
|
||||
- An array of client subscriptions, a list of roles and/or responsibilities assigned to the system (e.g. webserver).
|
||||
- These subscriptions determine which monitoring checks are executed by the client, as check requests are sent to subscriptions.
|
||||
|
|
@ -44,6 +45,7 @@ options:
|
|||
default: 'no'
|
||||
redact:
|
||||
type: list
|
||||
elements: str
|
||||
description:
|
||||
- Client definition attributes to redact (values) when logging and sending client keepalives.
|
||||
socket:
|
||||
|
|
@ -160,22 +162,22 @@ def main():
|
|||
module = AnsibleModule(
|
||||
supports_check_mode=True,
|
||||
argument_spec=dict(
|
||||
state=dict(type='str', required=False, choices=['present', 'absent'], default='present'),
|
||||
name=dict(type='str', required=False),
|
||||
address=dict(type='str', required=False),
|
||||
subscriptions=dict(type='list', required=False),
|
||||
safe_mode=dict(type='bool', required=False, default=False),
|
||||
redact=dict(type='list', required=False),
|
||||
socket=dict(type='dict', required=False),
|
||||
keepalives=dict(type='bool', required=False, default=True),
|
||||
keepalive=dict(type='dict', required=False),
|
||||
registration=dict(type='dict', required=False),
|
||||
deregister=dict(type='bool', required=False),
|
||||
deregistration=dict(type='dict', required=False),
|
||||
ec2=dict(type='dict', required=False),
|
||||
chef=dict(type='dict', required=False),
|
||||
puppet=dict(type='dict', required=False),
|
||||
servicenow=dict(type='dict', required=False)
|
||||
state=dict(type='str', choices=['present', 'absent'], default='present'),
|
||||
name=dict(type='str', ),
|
||||
address=dict(type='str', ),
|
||||
subscriptions=dict(type='list', elements="str"),
|
||||
safe_mode=dict(type='bool', default=False),
|
||||
redact=dict(type='list', elements="str"),
|
||||
socket=dict(type='dict'),
|
||||
keepalives=dict(type='bool', default=True),
|
||||
keepalive=dict(type='dict'),
|
||||
registration=dict(type='dict'),
|
||||
deregister=dict(type='bool'),
|
||||
deregistration=dict(type='dict'),
|
||||
ec2=dict(type='dict'),
|
||||
chef=dict(type='dict'),
|
||||
puppet=dict(type='dict'),
|
||||
servicenow=dict(type='dict')
|
||||
),
|
||||
required_if=[
|
||||
['state', 'present', ['subscriptions']]
|
||||
|
|
|
|||
|
|
@ -37,11 +37,13 @@ options:
|
|||
- The Sensu event filter (name) to use when filtering events for the handler.
|
||||
filters:
|
||||
type: list
|
||||
elements: str
|
||||
description:
|
||||
- An array of Sensu event filters (names) to use when filtering events for the handler.
|
||||
- Each array item must be a string.
|
||||
severities:
|
||||
type: list
|
||||
elements: str
|
||||
description:
|
||||
- An array of check result severities the handler will handle.
|
||||
- 'NOTE: event resolution bypasses this filtering.'
|
||||
|
|
@ -84,9 +86,9 @@ options:
|
|||
- 'NOTE: the pipe attribute is only required for Transport handlers (i.e. handlers configured with "type": "transport").'
|
||||
handlers:
|
||||
type: list
|
||||
elements: str
|
||||
description:
|
||||
- An array of Sensu event handlers (names) to use for events using the handler set.
|
||||
- Each array item must be a string.
|
||||
- 'NOTE: the handlers attribute is only required for handler sets (i.e. handlers configured with "type": "set").'
|
||||
notes:
|
||||
- Check mode is supported
|
||||
|
|
@ -165,20 +167,20 @@ def main():
|
|||
module = AnsibleModule(
|
||||
supports_check_mode=True,
|
||||
argument_spec=dict(
|
||||
state=dict(type='str', required=False, choices=['present', 'absent'], default='present'),
|
||||
state=dict(type='str', choices=['present', 'absent'], default='present'),
|
||||
name=dict(type='str', required=True),
|
||||
type=dict(type='str', required=False, choices=['pipe', 'tcp', 'udp', 'transport', 'set']),
|
||||
filter=dict(type='str', required=False),
|
||||
filters=dict(type='list', required=False),
|
||||
severities=dict(type='list', required=False),
|
||||
mutator=dict(type='str', required=False),
|
||||
timeout=dict(type='int', required=False, default=10),
|
||||
handle_silenced=dict(type='bool', required=False, default=False),
|
||||
handle_flapping=dict(type='bool', required=False, default=False),
|
||||
command=dict(type='str', required=False),
|
||||
socket=dict(type='dict', required=False),
|
||||
pipe=dict(type='dict', required=False),
|
||||
handlers=dict(type='list', required=False),
|
||||
type=dict(type='str', choices=['pipe', 'tcp', 'udp', 'transport', 'set']),
|
||||
filter=dict(type='str'),
|
||||
filters=dict(type='list', elements='str'),
|
||||
severities=dict(type='list', elements='str'),
|
||||
mutator=dict(type='str'),
|
||||
timeout=dict(type='int', default=10),
|
||||
handle_silenced=dict(type='bool', default=False),
|
||||
handle_flapping=dict(type='bool', default=False),
|
||||
command=dict(type='str'),
|
||||
socket=dict(type='dict'),
|
||||
pipe=dict(type='dict'),
|
||||
handlers=dict(type='list', elements='str'),
|
||||
),
|
||||
required_if=[
|
||||
['state', 'present', ['type']],
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue