ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-22 21:00:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Don't ignore a duplicate host for an already processed include (#40361)

Browse source 
* Don't ignore a duplicate host for an already processed include, assume that the repetition indicates a new include. Fixes #40317

* Add intg tests to ensure duplicate items in loop are not deduped

* Add note about relative indexing
This commit is contained in:
Matt Martz 2018-06-08 15:36:22 -05:00 • committed by GitHub
commit 76867730bf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 36 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
test/integration/targets/include_import/runme.sh
View file

@ -73,3 +73,9 @@ if [[ -z "$OUT" ]]; then
echo "apply on import_tasks did not cause error"
exit 1
fi
# Test that duplicate items in loop are not deduped
ANSIBLE_STRATEGY='linear' ansible-playbook tasks/test_include_dupe_loop.yml -i ../../inventory "$@" | tee test_include_dupe_loop.out
test "$(grep -c 'item=foo' test_include_dupe_loop.out)" = 3
ANSIBLE_STRATEGY='free' ansible-playbook tasks/test_include_dupe_loop.yml -i ../../inventory "$@" | tee test_include_dupe_loop.out
test "$(grep -c 'item=foo' test_include_dupe_loop.out)" = 3

2
test/integration/targets/include_import/tasks/debug_item.yml Normal file
View file

@ -0,0 +1,2 @@
- debug:
msg: "item={{ item }}"

8
test/integration/targets/include_import/tasks/test_include_dupe_loop.yml Normal file
View file

@ -0,0 +1,8 @@
- name: Test Include Duplicate Loop Items
hosts: testhost
tasks:
- include_tasks: debug_item.yml
loop:
- foo
- foo
- foo