ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-08-22 05:51:43 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

apache2_module: updated cgi action conditions (#10423)

Browse source 
* apache2_module: updated cgi action conditions

Only the activation of the cgi module in threaded mode should be a
restriction due to apache2 limitations, not the deactivation.
Especially when the cgi module isn't enabled yet at all. Fixes #9140

* bug(fix): apache2_module fails to disable cgi module

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
Daniel Hoffend 2025-08-17 12:52:49 +02:00 • committed by GitHub
commit 735a066d92
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/10423-apache_module-condition.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- apache2_module - check the ``cgi`` module restrictions only during activation (https://github.com/ansible-collections/community.general/pull/10423).

4
plugins/modules/apache2_module.py
View file

@ -258,8 +258,8 @@ def main():
) )
name = module.params['name'] name = module.params['name']
if name == 'cgi' and _run_threaded(module): if name == 'cgi' and module.params['state'] == 'present' and _run_threaded(module):
module.fail_json(msg="Your MPM seems to be threaded. No automatic actions on module cgi possible.") module.fail_json(msg="Your MPM seems to be threaded, therefore enabling cgi module is not allowed.")
if not module.params['identifier']: if not module.params['identifier']:
module.params['identifier'] = create_apache_identifier(module.params['name']) module.params['identifier'] = create_apache_identifier(module.params['name'])