mirror of
https://github.com/ansible-collections/community.general.git
synced 2025-10-23 12:33:59 -07:00
Refactor yum and dnf, add feature parity (#43621)
* Refactor yum and dnf, add feature parity
Signed-off-by: Adam Miller <admiller@redhat.com>
* remove unnecessary module_utils, move the classes into the module code
Signed-off-by: Adam Miller <admiller@redhat.com>
* remove yum -> yum4, out of scope
Signed-off-by: Adam Miller <admiller@redhat.com>
* use ABCMeta
Signed-off-by: Adam Miller <admiller@redhat.com>
* re-arrange run() caller vs callee
Signed-off-by: Adam Miller <admiller@redhat.com>
* make sanity checks happy
Signed-off-by: Adam Miller <admiller@redhat.com>
* fix yum unit tests
Signed-off-by: Adam Miller <admiller@redhat.com>
* remove unecessary debug statements, fix typo
Signed-off-by: Adam Miller <admiller@redhat.com>
* fix licensing and attribution in yumdnf module_util
Signed-off-by: Adam Miller <admiller@redhat.com>
* include fix from PR 40737
original commit 5cbda9658a
original Author: Strahinja Kustudic <kustodian@gmail.com>
yum will fail on 'No space left on device', fixes #32791 (#40737)
During the installing of packages if yum runs out of free disk space,
some post install scripts could fail (like e.g. when the kernel
package generates initramfs), but yum would still exit with a status
0. This is bad, especially for the kernel package, because it makes
it unable to boot. Because the yum module is usually used for
automation, which means the users cannot read every message yum
prints, it's better that the yum module fails if it detects that
there is no free space on the disk.
Signed-off-by: Adam Miller <admiller@redhat.com>
* Revert "fix licensing and attribution in yumdnf module_util"
This reverts commit 59e11de5a2a6efa17ac3f0076bb162348c02e1bd.
* move fetch_rpm_from_url out of yumdnf module_util
Signed-off-by: Adam Miller <admiller@redhat.com>
* fix the move of fetch_rpm_from_url
Signed-off-by: Adam Miller <admiller@redhat.com>
This commit is contained in:
parent
d7921b4d5b
commit
6d95624c22
5 changed files with 1940 additions and 1495 deletions
|
@ -232,6 +232,37 @@
|
|||
dnf: name=sos installroot='/'
|
||||
register: dnf_result
|
||||
|
||||
# Test download_only
|
||||
- name: uninstall sos for downloadonly test
|
||||
dnf:
|
||||
name: sos
|
||||
state: absent
|
||||
|
||||
- name: install sos
|
||||
dnf:
|
||||
name: sos
|
||||
state: latest
|
||||
download_only: true
|
||||
register: dnf_result
|
||||
|
||||
- name: verify download of sos (part 1 -- dnf "install" succeeded)
|
||||
assert:
|
||||
that:
|
||||
- "dnf_result is success"
|
||||
- "dnf_result is changed"
|
||||
|
||||
- name: uninstall sos (noop)
|
||||
dnf:
|
||||
name: sos
|
||||
state: absent
|
||||
register: dnf_result
|
||||
|
||||
- name: verify download of sos (part 2 -- nothing removed during uninstall)
|
||||
assert:
|
||||
that:
|
||||
- "dnf_result is success"
|
||||
- "not dnf_result is changed"
|
||||
|
||||
# GROUP INSTALL
|
||||
# Using 'Books and Guides' because it is only 5 packages and a 7.3 M download on Fedora 26.
|
||||
# It also doesn't install anything that will tamper with our Python environment.
|
||||
|
@ -308,7 +339,8 @@
|
|||
- "'msg' in dnf_result"
|
||||
|
||||
# cleanup until https://github.com/ansible/ansible/issues/27377 is resolved
|
||||
- shell: dnf -y group install "Books and Guides" && dnf -y group remove "Books and Guides"
|
||||
- shell: 'dnf -y group install "Books and Guides" && dnf -y group remove "Books and Guides"'
|
||||
register: shell_dnf_result
|
||||
|
||||
# GROUP UPGRADE - this will go to the same method as group install
|
||||
# but through group_update - it is its invocation we're testing here
|
||||
|
@ -426,3 +458,188 @@
|
|||
- "'non-existent-rpm' in dnf_result['failures'][0]"
|
||||
- "'no package matched' in dnf_result['failures'][0]"
|
||||
- "'Failed to install some of the specified packages' in dnf_result['msg']"
|
||||
|
||||
- name: use latest to install httpd
|
||||
dnf:
|
||||
name: httpd
|
||||
state: latest
|
||||
register: dnf_result
|
||||
|
||||
- name: verify httpd was installed
|
||||
assert:
|
||||
that:
|
||||
- "'changed' in dnf_result"
|
||||
|
||||
- name: uninstall httpd
|
||||
dnf:
|
||||
name: httpd
|
||||
state: removed
|
||||
|
||||
- name: update httpd only if it exists
|
||||
dnf:
|
||||
name: httpd
|
||||
state: latest
|
||||
update_only: yes
|
||||
register: dnf_result
|
||||
|
||||
- name: verify httpd not installed
|
||||
assert:
|
||||
that:
|
||||
- "not dnf_result is changed"
|
||||
|
||||
- name: try to install not compatible arch rpm, should fail
|
||||
dnf:
|
||||
name: http://download.fedoraproject.org/pub/epel/7/ppc64le/Packages/b/banner-1.3.4-3.el7.ppc64le.rpm
|
||||
state: present
|
||||
register: dnf_result
|
||||
ignore_errors: True
|
||||
|
||||
- name: verify that dnf failed
|
||||
assert:
|
||||
that:
|
||||
- "not dnf_result is changed"
|
||||
- "dnf_result is failed"
|
||||
|
||||
# setup for testing installing an RPM from url
|
||||
|
||||
- set_fact:
|
||||
pkg_name: fpaste
|
||||
|
||||
- name: cleanup
|
||||
dnf:
|
||||
name: "{{ pkg_name }}"
|
||||
state: absent
|
||||
|
||||
- set_fact:
|
||||
pkg_url: https://download.fedoraproject.org/pub/fedora/linux/releases/27/Everything/x86_64/os/Packages/f/fpaste-0.3.9.1-1.fc27.noarch.rpm
|
||||
# setup end
|
||||
|
||||
- name: download an rpm
|
||||
get_url:
|
||||
url: "{{ pkg_url }}"
|
||||
dest: "/tmp/{{ pkg_name }}.rpm"
|
||||
|
||||
- name: install the downloaded rpm
|
||||
dnf:
|
||||
name: "/tmp/{{ pkg_name }}.rpm"
|
||||
state: present
|
||||
register: dnf_result
|
||||
|
||||
- name: verify installation
|
||||
assert:
|
||||
that:
|
||||
- "dnf_result is success"
|
||||
- "dnf_result is changed"
|
||||
|
||||
- name: install the downloaded rpm again
|
||||
dnf:
|
||||
name: "/tmp/{{ pkg_name }}.rpm"
|
||||
state: present
|
||||
register: dnf_result
|
||||
|
||||
- name: verify installation
|
||||
assert:
|
||||
that:
|
||||
- "dnf_result is success"
|
||||
- "not dnf_result is changed"
|
||||
|
||||
- name: clean up
|
||||
dnf:
|
||||
name: "{{ pkg_name }}"
|
||||
state: absent
|
||||
|
||||
- name: install from url
|
||||
dnf:
|
||||
name: "{{ pkg_url }}"
|
||||
state: present
|
||||
register: dnf_result
|
||||
|
||||
- name: verify installation
|
||||
assert:
|
||||
that:
|
||||
- "dnf_result is success"
|
||||
- "dnf_result is changed"
|
||||
- "dnf_result is not failed"
|
||||
|
||||
- name: verify dnf module outputs
|
||||
assert:
|
||||
that:
|
||||
- "'changed' in dnf_result"
|
||||
- "'results' in dnf_result"
|
||||
|
||||
- name: Create a temp RPM file which does not contain nevra information
|
||||
file:
|
||||
name: "/tmp/non_existent_pkg.rpm"
|
||||
state: touch
|
||||
|
||||
- name: Try installing RPM file which does not contain nevra information
|
||||
dnf:
|
||||
name: "/tmp/non_existent_pkg.rpm"
|
||||
state: present
|
||||
register: no_nevra_info_result
|
||||
ignore_errors: yes
|
||||
|
||||
- name: Verify RPM failed to install
|
||||
assert:
|
||||
that:
|
||||
- "'changed' in no_nevra_info_result"
|
||||
- "'msg' in no_nevra_info_result"
|
||||
|
||||
- name: Delete a temp RPM file
|
||||
file:
|
||||
name: "/tmp/non_existent_pkg.rpm"
|
||||
state: absent
|
||||
|
||||
- name: uninstall lsof
|
||||
dnf:
|
||||
name: lsof
|
||||
state: removed
|
||||
|
||||
- name: check lsof with rpm
|
||||
shell: rpm -q lsof
|
||||
ignore_errors: True
|
||||
register: rpm_lsof_result
|
||||
|
||||
- name: verify lsof is uninstalled
|
||||
assert:
|
||||
that:
|
||||
- "rpm_lsof_result is failed"
|
||||
|
||||
- name: exclude lsof
|
||||
lineinfile:
|
||||
dest: /etc/dnf/dnf.conf
|
||||
regexp: (^exclude=)(.)*
|
||||
line: "exclude=lsof*"
|
||||
state: present
|
||||
|
||||
# begin test case where disable_excludes is supported
|
||||
- name: Try install lsof without disable_excludes
|
||||
dnf: name=lsof state=latest
|
||||
register: dnf_lsof_result
|
||||
ignore_errors: True
|
||||
|
||||
- name: verify lsof did not install because it is in exclude list
|
||||
assert:
|
||||
that:
|
||||
- "dnf_lsof_result is failed"
|
||||
|
||||
- name: install lsof with disable_excludes
|
||||
dnf: name=lsof state=latest disable_excludes=all
|
||||
register: dnf_lsof_result_using_excludes
|
||||
|
||||
- name: verify lsof did install using disable_excludes=all
|
||||
assert:
|
||||
that:
|
||||
- "dnf_lsof_result_using_excludes is success"
|
||||
- "dnf_lsof_result_using_excludes is changed"
|
||||
- "dnf_lsof_result_using_excludes is not failed"
|
||||
|
||||
- name: remove exclude lsof (cleanup dnf.conf)
|
||||
lineinfile:
|
||||
dest: /etc/dnf/dnf.conf
|
||||
regexp: (^exclude=lsof*)
|
||||
line: "exclude="
|
||||
state: present
|
||||
|
||||
|
||||
# end test case where disable_excludes is supported
|
||||
|
|
|
@ -2,7 +2,7 @@
|
|||
# -*- coding: utf-8 -*-
|
||||
from ansible.compat.tests import unittest
|
||||
|
||||
from ansible.modules.packaging.os import yum
|
||||
from ansible.modules.packaging.os.yum import YumModule
|
||||
|
||||
|
||||
yum_plugin_load_error = """
|
||||
|
@ -141,34 +141,34 @@ class TestYumUpdateCheckParse(unittest.TestCase):
|
|||
self.assertIsInstance(result, dict)
|
||||
|
||||
def test_empty_output(self):
|
||||
res = yum.parse_check_update("")
|
||||
res = YumModule.parse_check_update("")
|
||||
expected_pkgs = []
|
||||
self._assert_expected(expected_pkgs, res)
|
||||
|
||||
def test_longname(self):
|
||||
res = yum.parse_check_update(longname)
|
||||
res = YumModule.parse_check_update(longname)
|
||||
expected_pkgs = ['xxxxxxxxxxxxxxxxxxxxxxxxxx', 'glibc']
|
||||
self._assert_expected(expected_pkgs, res)
|
||||
|
||||
def test_plugin_load_error(self):
|
||||
res = yum.parse_check_update(yum_plugin_load_error)
|
||||
res = YumModule.parse_check_update(yum_plugin_load_error)
|
||||
expected_pkgs = []
|
||||
self._assert_expected(expected_pkgs, res)
|
||||
|
||||
def test_wrapped_output_1(self):
|
||||
res = yum.parse_check_update(wrapped_output_1)
|
||||
res = YumModule.parse_check_update(wrapped_output_1)
|
||||
expected_pkgs = ["vms-agent"]
|
||||
self._assert_expected(expected_pkgs, res)
|
||||
|
||||
def test_wrapped_output_2(self):
|
||||
res = yum.parse_check_update(wrapped_output_2)
|
||||
res = YumModule.parse_check_update(wrapped_output_2)
|
||||
expected_pkgs = ["empty-empty-empty-empty-empty-empty-empty-empty-empty-empty-empty-empty-empty-empty-empty-empty-empty-empty-empty-empty",
|
||||
"libtiff"]
|
||||
|
||||
self._assert_expected(expected_pkgs, res)
|
||||
|
||||
def test_wrapped_output_3(self):
|
||||
res = yum.parse_check_update(wrapped_output_3)
|
||||
res = YumModule.parse_check_update(wrapped_output_3)
|
||||
expected_pkgs = ["ceph", "ceph-base", "ceph-common", "ceph-mds",
|
||||
"ceph-mon", "ceph-osd", "ceph-selinux", "libcephfs1",
|
||||
"librados2", "libradosstriper1", "librbd1", "librgw2",
|
||||
|
@ -176,16 +176,16 @@ class TestYumUpdateCheckParse(unittest.TestCase):
|
|||
self._assert_expected(expected_pkgs, res)
|
||||
|
||||
def test_wrapped_output_4(self):
|
||||
res = yum.parse_check_update(wrapped_output_4)
|
||||
res = YumModule.parse_check_update(wrapped_output_4)
|
||||
|
||||
expected_pkgs = ["ipxe-roms-qemu", "quota", "quota-nls", "rdma", "screen",
|
||||
"sos", "sssd-client"]
|
||||
self._assert_expected(expected_pkgs, res)
|
||||
|
||||
def test_wrapped_output_rhel7(self):
|
||||
res = yum.parse_check_update(unwrapped_output_rhel7)
|
||||
res = YumModule.parse_check_update(unwrapped_output_rhel7)
|
||||
self._assert_expected(unwrapped_output_rhel7_expected_pkgs, res)
|
||||
|
||||
def test_wrapped_output_rhel7_obsoletes(self):
|
||||
res = yum.parse_check_update(unwrapped_output_rhel7_obsoletes)
|
||||
res = YumModule.parse_check_update(unwrapped_output_rhel7_obsoletes)
|
||||
self._assert_expected(unwrapped_output_rhel7_expected_pkgs, res)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue