From 6b59a3c1f6c33bd10d1cc553aed601333c28c4e2 Mon Sep 17 00:00:00 2001 From: "patchback[bot]" <45432694+patchback[bot]@users.noreply.github.com> Date: Fri, 29 Aug 2025 07:06:42 +0200 Subject: [PATCH] [PR #10752/f6003f61 backport][stable-10] selective: don't hard code ansible_loop_var 'item' (#10763) selective: don't hard code ansible_loop_var 'item' (#10752) * selective: don't hard code ansible_loop_var 'item' * Add changelog fragment * Update changelog message --------- (cherry picked from commit f6003f61cca2fae20c363499edd71f8293112228) Co-authored-by: Hoang Nguyen Co-authored-by: Felix Fontein --- changelogs/fragments/10752-selective-hardcoded-loop-var.yml | 2 ++ plugins/callback/selective.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/10752-selective-hardcoded-loop-var.yml diff --git a/changelogs/fragments/10752-selective-hardcoded-loop-var.yml b/changelogs/fragments/10752-selective-hardcoded-loop-var.yml new file mode 100644 index 0000000000..cfc6bdd9e9 --- /dev/null +++ b/changelogs/fragments/10752-selective-hardcoded-loop-var.yml @@ -0,0 +1,2 @@ +bugfixes: + - selective callback plugin - specify ``ansible_loop_var`` instead of the explicit value ``item`` when printing task result (https://github.com/ansible-collections/community.general/pull/10752). diff --git a/plugins/callback/selective.py b/plugins/callback/selective.py index 9cc805d3cd..8c684a9837 100644 --- a/plugins/callback/selective.py +++ b/plugins/callback/selective.py @@ -208,7 +208,7 @@ class CallbackModule(CallbackBase): stderr = [r.get('exception', None), r.get('module_stderr', None)] stderr = "\n".join([e for e in stderr if e]).strip() - self._print_host_or_item(r['item'], + self._print_host_or_item(r[r['ansible_loop_var']], r.get('changed', False), to_text(r.get('msg', '')), r.get('diff', None),