mirror of
https://github.com/ansible-collections/community.general.git
synced 2025-04-22 18:31:25 -07:00
multiple modules: improve dict.items() loops (#8876)
* multiple modules: improve dict.items() loops * simplify in memset_* modules * add changelog frag
This commit is contained in:
parent
80f48cceb4
commit
6af74d1ba6
16 changed files with 44 additions and 43 deletions
|
@ -264,14 +264,14 @@ class GitlabIssue(object):
|
|||
|
||||
if key == 'milestone_id':
|
||||
old_milestone = getattr(issue, 'milestone')['id'] if getattr(issue, 'milestone') else ""
|
||||
if options[key] != old_milestone:
|
||||
if value != old_milestone:
|
||||
return True
|
||||
elif key == 'assignee_ids':
|
||||
if options[key] != sorted([user["id"] for user in getattr(issue, 'assignees')]):
|
||||
if value != sorted([user["id"] for user in getattr(issue, 'assignees')]):
|
||||
return True
|
||||
|
||||
elif key == 'labels':
|
||||
if options[key] != sorted(getattr(issue, key)):
|
||||
if value != sorted(getattr(issue, key)):
|
||||
return True
|
||||
|
||||
elif getattr(issue, key) != value:
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue