ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-05-10 19:21:31 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Fix dangerous default args. (#29839)

Browse source
This commit is contained in:
Matt Clay 2017-09-12 00:11:13 -07:00 • committed by GitHub
parent 5caa47feb9
commit 68aeaa58a8
50 changed files with 253 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

1
test/sanity/pylint/disable.txt
View file

@ -17,7 +17,6 @@ broad-except
cell-var-from-loop
consider-iterating-dictionary
consider-using-enumerate
dangerous-default-value
deprecated-lambda
deprecated-method
deprecated-module

3
test/units/mock/loader.py
View file

@ -28,7 +28,8 @@ from ansible.module_utils._text import to_bytes
class DictDataLoader(DataLoader):
def __init__(self, file_mapping=dict()):
def __init__(self, file_mapping=None):
file_mapping = {} if file_mapping is None else file_mapping
assert type(file_mapping) == dict
super(DictDataLoader, self).__init__()

4
test/units/module_utils/gcp/test_auth.py
View file

@ -48,7 +48,9 @@ class FakeModule(object):
else:
return alt
def __init__(self, data={}):
def __init__(self, data=None):
data = {} if data is None else data
self.params = FakeModule.Params()
self.params.data = data

6
test/units/modules/cloud/amazon/test_ec2_vpc_vpn.py
View file

@ -84,7 +84,11 @@ def setup_mod_conn(placeboify, params):
return m, conn
def make_params(cgw, vgw, tags={}, filters={}, routes=[]):
def make_params(cgw, vgw, tags=None, filters=None, routes=None):
tags = {} if tags is None else tags
filters = {} if filters is None else filters
routes = [] if routes is None else routes
return {'customer_gateway_id': cgw,
'static_only': True,
'vpn_gateway_id': vgw,

63
test/units/modules/network/nuage/test_nuage_vspk.py
View file

@ -42,8 +42,10 @@ class TestNuageVSPKModule(TestNuageModule):
self.patches = []
def enterprises_get(self, filter=None, order_by=None, group_by=[], page=None, page_size=None, query_parameters=None, commit=True, async=False,
def enterprises_get(self, filter=None, order_by=None, group_by=None, page=None, page_size=None, query_parameters=None, commit=True, async=False,
callback=None):
group_by = [] if group_by is None else group_by
if 'unknown' in filter:
return []
@ -56,7 +58,9 @@ class TestNuageVSPKModule(TestNuageModule):
self.enterprises_get_mock.start()
self.patches.append(self.enterprises_get_mock)
def enterprises_get_first(self, filter=None, order_by=None, group_by=[], query_parameters=None, commit=False, async=False, callback=None):
def enterprises_get_first(self, filter=None, order_by=None, group_by=None, query_parameters=None, commit=False, async=False, callback=None):
group_by = [] if group_by is None else group_by
if filter == 'name == "test-enterprise-create"' or 'unknown' in filter:
return None
return vsdk.NUEnterprise(id='enterprise-id', name='test-enterprise')
@ -128,8 +132,10 @@ class TestNuageVSPKModule(TestNuageModule):
self.user_save_mock.start()
self.patches.append(self.user_save_mock)
def groups_get(self, filter=None, order_by=None, group_by=[], page=None, page_size=None, query_parameters=None, commit=True, async=False,
def groups_get(self, filter=None, order_by=None, group_by=None, page=None, page_size=None, query_parameters=None, commit=True, async=False,
callback=None):
group_by = [] if group_by is None else group_by
return []
self.groups_get_mock = patch('vspk.v5_0.fetchers.NUGroupsFetcher.get', new=groups_get)
@ -411,7 +417,10 @@ class TestNuageVSPKModule(TestNuageModule):
'state': 'present'
})
def users_get(self, filter=None, order_by=None, group_by=[], page=None, page_size=None, query_parameters=None, commit=True, async=False, callback=None):
def users_get(self, filter=None, order_by=None, group_by=None, page=None, page_size=None, query_parameters=None, commit=True, async=False,
callback=None):
group_by = [] if group_by is None else group_by
return [vsdk.NUUser(id='user-id'), vsdk.NUUser(id='user-id-2')]
with self.assertRaises(AnsibleExitJson) as exc:
@ -431,7 +440,10 @@ class TestNuageVSPKModule(TestNuageModule):
'state': 'present'
})
def users_get(self, filter=None, order_by=None, group_by=[], page=None, page_size=None, query_parameters=None, commit=True, async=False, callback=None):
def users_get(self, filter=None, order_by=None, group_by=None, page=None, page_size=None, query_parameters=None, commit=True, async=False,
callback=None):
group_by = [] if group_by is None else group_by
return []
with self.assertRaises(AnsibleExitJson) as exc:
@ -488,7 +500,10 @@ class TestNuageVSPKModule(TestNuageModule):
]
})
def users_get(self, filter=None, order_by=None, group_by=[], page=None, page_size=None, query_parameters=None, commit=True, async=False, callback=None):
def users_get(self, filter=None, order_by=None, group_by=None, page=None, page_size=None, query_parameters=None, commit=True, async=False,
callback=None):
group_by = [] if group_by is None else group_by
return []
with self.assertRaises(AnsibleExitJson) as exc:
@ -523,7 +538,10 @@ class TestNuageVSPKModule(TestNuageModule):
]
})
def users_get(self, filter=None, order_by=None, group_by=[], page=None, page_size=None, query_parameters=None, commit=True, async=False, callback=None):
def users_get(self, filter=None, order_by=None, group_by=None, page=None, page_size=None, query_parameters=None, commit=True, async=False,
callback=None):
group_by = [] if group_by is None else group_by
return []
with self.assertRaises(AnsibleExitJson) as exc:
@ -560,7 +578,10 @@ class TestNuageVSPKModule(TestNuageModule):
'state': 'absent'
})
def users_get(self, filter=None, order_by=None, group_by=[], page=None, page_size=None, query_parameters=None, commit=True, async=False, callback=None):
def users_get(self, filter=None, order_by=None, group_by=None, page=None, page_size=None, query_parameters=None, commit=True, async=False,
callback=None):
group_by = [] if group_by is None else group_by
return [vsdk.NUUser(id='user-id')]
with self.assertRaises(AnsibleExitJson) as exc:
@ -636,8 +657,10 @@ class TestNuageVSPKModule(TestNuageModule):
'command': 'find'
})
def enterprises_failed_get(self, filter=None, order_by=None, group_by=[], page=None, page_size=None, query_parameters=None, commit=True, async=False,
def enterprises_failed_get(self, filter=None, order_by=None, group_by=None, page=None, page_size=None, query_parameters=None, commit=True, async=False,
callback=None):
group_by = [] if group_by is None else group_by
raise BambouHTTPError(MockNuageConnection(status_code='404', reason='Not Found', errors={'description': 'Entity not found'}))
with self.assertRaises(AnsibleFailJson) as exc:
@ -675,8 +698,10 @@ class TestNuageVSPKModule(TestNuageModule):
'state': 'absent'
})
def enterprises_failed_get_first(self, filter=None, order_by=None, group_by=[], page=None, page_size=None, query_parameters=None, commit=True,
def enterprises_failed_get_first(self, filter=None, order_by=None, group_by=None, page=None, page_size=None, query_parameters=None, commit=True,
async=False, callback=None):
group_by = [] if group_by is None else group_by
raise BambouHTTPError(MockNuageConnection(status_code='404', reason='Not Found', errors={'description': 'Entity not found'}))
with self.assertRaises(AnsibleExitJson) as exc:
@ -714,7 +739,10 @@ class TestNuageVSPKModule(TestNuageModule):
'state': 'present'
})
def users_get(self, filter=None, order_by=None, group_by=[], page=None, page_size=None, query_parameters=None, commit=True, async=False, callback=None):
def users_get(self, filter=None, order_by=None, group_by=None, page=None, page_size=None, query_parameters=None, commit=True, async=False,
callback=None):
group_by = [] if group_by is None else group_by
return []
def group_assign(self, objects, nurest_object_type, async=False, callback=None, commit=True):
@ -739,7 +767,10 @@ class TestNuageVSPKModule(TestNuageModule):
'state': 'absent'
})
def users_get(self, filter=None, order_by=None, group_by=[], page=None, page_size=None, query_parameters=None, commit=True, async=False, callback=None):
def users_get(self, filter=None, order_by=None, group_by=None, page=None, page_size=None, query_parameters=None, commit=True, async=False,
callback=None):
group_by = [] if group_by is None else group_by
return [vsdk.NUUser(id='user-id'), vsdk.NUUser(id='user-id-2')]
def group_assign(self, objects, nurest_object_type, async=False, callback=None, commit=True):
@ -956,8 +987,10 @@ class TestNuageVSPKModule(TestNuageModule):
'state': 'present'
})
def users_get_first(self, filter=None, order_by=None, group_by=[], page=None, page_size=None, query_parameters=None, commit=True, async=False,
def users_get_first(self, filter=None, order_by=None, group_by=None, page=None, page_size=None, query_parameters=None, commit=True, async=False,
callback=None):
group_by = [] if group_by is None else group_by
return None
with self.assertRaises(AnsibleFailJson) as exc:
@ -1105,8 +1138,10 @@ class TestNuageVSPKModule(TestNuageModule):
]
})
def users_get_first(self, filter=None, order_by=None, group_by=[], page=None, page_size=None, query_parameters=None, commit=True, async=False,
def users_get_first(self, filter=None, order_by=None, group_by=None, page=None, page_size=None, query_parameters=None, commit=True, async=False,
callback=None):
group_by = [] if group_by is None else group_by
return None
with self.assertRaises(AnsibleFailJson) as exc: