mirror of
https://github.com/ansible-collections/community.general.git
synced 2025-07-22 21:00:22 -07:00
Fix dangerous default args. (#29839)
This commit is contained in:
parent
5caa47feb9
commit
68aeaa58a8
50 changed files with 253 additions and 87 deletions
|
@ -301,7 +301,9 @@ class Role(Base, Become, Conditional, Taggable):
|
|||
def get_parents(self):
|
||||
return self._parents
|
||||
|
||||
def get_default_vars(self, dep_chain=[]):
|
||||
def get_default_vars(self, dep_chain=None):
|
||||
dep_chain = [] if dep_chain is None else dep_chain
|
||||
|
||||
default_vars = dict()
|
||||
for dep in self.get_all_dependencies():
|
||||
default_vars = combine_vars(default_vars, dep.get_default_vars())
|
||||
|
@ -311,7 +313,9 @@ class Role(Base, Become, Conditional, Taggable):
|
|||
default_vars = combine_vars(default_vars, self._default_vars)
|
||||
return default_vars
|
||||
|
||||
def get_inherited_vars(self, dep_chain=[]):
|
||||
def get_inherited_vars(self, dep_chain=None):
|
||||
dep_chain = [] if dep_chain is None else dep_chain
|
||||
|
||||
inherited_vars = dict()
|
||||
|
||||
if dep_chain:
|
||||
|
@ -319,7 +323,9 @@ class Role(Base, Become, Conditional, Taggable):
|
|||
inherited_vars = combine_vars(inherited_vars, parent._role_vars)
|
||||
return inherited_vars
|
||||
|
||||
def get_role_params(self, dep_chain=[]):
|
||||
def get_role_params(self, dep_chain=None):
|
||||
dep_chain = [] if dep_chain is None else dep_chain
|
||||
|
||||
params = {}
|
||||
if dep_chain:
|
||||
for parent in dep_chain:
|
||||
|
@ -327,7 +333,9 @@ class Role(Base, Become, Conditional, Taggable):
|
|||
params = combine_vars(params, self._role_params)
|
||||
return params
|
||||
|
||||
def get_vars(self, dep_chain=[], include_params=True):
|
||||
def get_vars(self, dep_chain=None, include_params=True):
|
||||
dep_chain = [] if dep_chain is None else dep_chain
|
||||
|
||||
all_vars = self.get_inherited_vars(dep_chain)
|
||||
|
||||
for dep in self.get_all_dependencies():
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue