ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-06-08 17:29:11 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fix dangerous default args. (#29839)

Browse source
This commit is contained in:
Matt Clay 2017-09-12 00:11:13 -07:00 • committed by GitHub
parent 5caa47feb9
commit 68aeaa58a8
50 changed files with 253 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

9
lib/ansible/parsing/mod_args.py
View file

@ -95,8 +95,9 @@ class ModuleArgsParser:
Args may also be munged for certain shell command parameters.
"""
# FIXME: mutable default arg
def __init__(self, task_ds=dict()):
def __init__(self, task_ds=None):
task_ds = {} if task_ds is None else task_ds
assert isinstance(task_ds, dict), "the type of 'task_ds' should be a dict, but is a %s" % type(task_ds)
self._task_ds = task_ds
@ -129,11 +130,13 @@ class ModuleArgsParser:
return (action, args)
def _normalize_parameters(self, thing, action=None, additional_args=dict()):
def _normalize_parameters(self, thing, action=None, additional_args=None):
'''
arguments can be fuzzy. Deal with all the forms.
'''
additional_args = {} if additional_args is None else additional_args
# final args are the ones we'll eventually return, so first update
# them with any additional args specified, which have lower priority
# than those which may be parsed/normalized next