Fix dangerous default args. (#29839)

This commit is contained in:
Matt Clay 2017-09-12 00:11:13 -07:00 committed by GitHub
parent 5caa47feb9
commit 68aeaa58a8
50 changed files with 253 additions and 87 deletions

View file

@ -395,7 +395,7 @@ def _validate_named_port_params(params):
return (True, '')
def _get_instance_list(mig, field='name', filter_list=['NONE']):
def _get_instance_list(mig, field='name', filter_list=None):
"""
Helper to grab field from instances response.
@ -414,6 +414,8 @@ def _get_instance_list(mig, field='name', filter_list=['NONE']):
:return: List of strings from list_managed_instances response.
:rtype: ``list``
"""
filter_list = ['NONE'] if filter_list is None else filter_list
return [x[field] for x in mig.list_managed_instances()
if x['currentAction'] in filter_list]