From 682469b9b856d59be463512d5cb56407d5884b6b Mon Sep 17 00:00:00 2001 From: "patchback[bot]" <45432694+patchback[bot]@users.noreply.github.com> Date: Sun, 10 Aug 2025 13:50:49 +0200 Subject: [PATCH] [PR #10603/6b7ec564 backport][stable-11] riak: command args as list rather than string (#10632) riak: command args as list rather than string (#10603) * riak: command args as list rather than string * add changelog frag (cherry picked from commit 6b7ec5648dff7fefae3f5274cab88fc03f2c623c) Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com> --- changelogs/fragments/10603-riak-cmd-list.yml | 2 ++ plugins/modules/riak.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/10603-riak-cmd-list.yml diff --git a/changelogs/fragments/10603-riak-cmd-list.yml b/changelogs/fragments/10603-riak-cmd-list.yml new file mode 100644 index 0000000000..1a29a07c7f --- /dev/null +++ b/changelogs/fragments/10603-riak-cmd-list.yml @@ -0,0 +1,2 @@ +minor_changes: + - riak - using safer mechanism to run external command (https://github.com/ansible-collections/community.general/pull/10603). diff --git a/plugins/modules/riak.py b/plugins/modules/riak.py index 2009ca0a22..bb62405749 100644 --- a/plugins/modules/riak.py +++ b/plugins/modules/riak.py @@ -153,7 +153,7 @@ def main(): version=version) if command == 'ping': - cmd = '%s ping %s' % (riak_bin, target_node) + cmd = [riak_bin, 'ping', target_node] rc, out, err = module.run_command(cmd) if rc == 0: result['ping'] = out