ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-25 20:01:25 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Add unit tests for ansible.module_utils.urls (#38059)

Browse source 
* Start of tests for ansible.module_utils.urls

* Start adding file for generic functions throughout urls

* Add tests for maybe_add_ssl_handler

* Remove commented out line

* Improve coverage of maybe_add_ssl_handler, test basic_auth_header

* Start tests for open_url

* pep8 and ignore urlopen in test_url_open.py tests

* Extend auth tests, add test for validate_certs=False

* Finish tests for open_url

* Add tests for fetch_url

* Add fetch_url tests to replace-urlopen ignore

* dummy instead of _

* Add BadStatusLine test

* Reorganize/rename tests

* Add tests for RedirectHandlerFactory

* Add POST test to confirm behavior is to convert to GET

* Update tests to handle recent changes to RedirectHandlerFactory

* Special test, just to confirm that aliasing http_error_308 to http_error_307 does not cause issues with urllib2 type redirects
This commit is contained in:
Matt Martz 2018-04-09 10:17:43 -05:00 • committed by GitHub
parent eccccfe77f
commit 6332beef65
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 936 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/ansible/module_utils/urls.py
View file

@ -941,7 +941,7 @@ def open_url(url, data=None, headers=None, method=None, use_proxy=True,
# user defined headers now, which may override things we've set above
if headers:
if not isinstance(headers, dict):
raise ValueError("headers provided to fetch_url() must be a dict")
raise ValueError("headers provided to open_url() must be a dict")
for header in headers:
request.add_header(header, headers[header])