diff --git a/changelogs/fragments/10711-pytohn-idioms-1.yml b/changelogs/fragments/10711-pytohn-idioms-1.yml new file mode 100644 index 0000000000..18ae9db37b --- /dev/null +++ b/changelogs/fragments/10711-pytohn-idioms-1.yml @@ -0,0 +1,6 @@ +minor_changes: + - gitlab_label - minor refactor to improve readability (https://github.com/ansible-collections/community.general/pull/10711). + - gitlab_milestone - minor refactor to improve readability (https://github.com/ansible-collections/community.general/pull/10711). + - ipa_host - minor refactor to improve readability (https://github.com/ansible-collections/community.general/pull/10711). + - lvg_rename - minor refactor to improve readability (https://github.com/ansible-collections/community.general/pull/10711). + - terraform - minor refactor to improve readability (https://github.com/ansible-collections/community.general/pull/10711). diff --git a/plugins/modules/gitlab_label.py b/plugins/modules/gitlab_label.py index a139d1fcbd..ea073321b6 100644 --- a/plugins/modules/gitlab_label.py +++ b/plugins/modules/gitlab_label.py @@ -419,7 +419,7 @@ def main(): color=dict(type='str'), description=dict(type='str'), priority=dict(type='int'), - new_name=dict(type='str'),) + new_name=dict(type='str')) ), state=dict(type='str', default="present", choices=["absent", "present"]), ) diff --git a/plugins/modules/gitlab_milestone.py b/plugins/modules/gitlab_milestone.py index 1406f96ffb..4624c4d5cd 100644 --- a/plugins/modules/gitlab_milestone.py +++ b/plugins/modules/gitlab_milestone.py @@ -414,12 +414,12 @@ def main(): project=dict(type='str'), group=dict(type='str'), purge=dict(type='bool', default=False), - milestones=dict(type='list', elements='dict', default=list(), + milestones=dict(type='list', elements='dict', default=[], options=dict( title=dict(type='str', required=True), description=dict(type='str'), due_date=dict(type='str'), - start_date=dict(type='str'),) + start_date=dict(type='str')) ), state=dict(type='str', default="present", choices=["absent", "present"]), ) diff --git a/plugins/modules/ipa_host.py b/plugins/modules/ipa_host.py index 89461a7bf2..32422c71c8 100644 --- a/plugins/modules/ipa_host.py +++ b/plugins/modules/ipa_host.py @@ -291,19 +291,21 @@ def ensure(module, client): def main(): argument_spec = ipa_argument_spec() - argument_spec.update(description=dict(type='str'), - fqdn=dict(type='str', required=True, aliases=['name']), - force=dict(type='bool'), - ip_address=dict(type='str'), - ns_host_location=dict(type='str', aliases=['nshostlocation']), - ns_hardware_platform=dict(type='str', aliases=['nshardwareplatform']), - ns_os_version=dict(type='str', aliases=['nsosversion']), - user_certificate=dict(type='list', aliases=['usercertificate'], elements='str'), - mac_address=dict(type='list', aliases=['macaddress'], elements='str'), - update_dns=dict(type='bool'), - state=dict(type='str', default='present', choices=['present', 'absent', 'enabled', 'disabled']), - random_password=dict(type='bool', no_log=False), - force_creation=dict(type='bool', default=True),) + argument_spec.update( + description=dict(type='str'), + fqdn=dict(type='str', required=True, aliases=['name']), + force=dict(type='bool'), + ip_address=dict(type='str'), + ns_host_location=dict(type='str', aliases=['nshostlocation']), + ns_hardware_platform=dict(type='str', aliases=['nshardwareplatform']), + ns_os_version=dict(type='str', aliases=['nsosversion']), + user_certificate=dict(type='list', aliases=['usercertificate'], elements='str'), + mac_address=dict(type='list', aliases=['macaddress'], elements='str'), + update_dns=dict(type='bool'), + state=dict(type='str', default='present', choices=['present', 'absent', 'enabled', 'disabled']), + random_password=dict(type='bool', no_log=False), + force_creation=dict(type='bool', default=True) + ) module = AnsibleModule(argument_spec=argument_spec, supports_check_mode=True) diff --git a/plugins/modules/lvg_rename.py b/plugins/modules/lvg_rename.py index 37f513697e..94b1aea95e 100644 --- a/plugins/modules/lvg_rename.py +++ b/plugins/modules/lvg_rename.py @@ -57,8 +57,8 @@ EXAMPLES = r""" from ansible.module_utils.basic import AnsibleModule argument_spec = dict( - vg=dict(type='str', required=True,), - vg_new=dict(type='str', required=True,), + vg=dict(type='str', required=True), + vg_new=dict(type='str', required=True), ) diff --git a/plugins/modules/terraform.py b/plugins/modules/terraform.py index a5adbcbe7e..5e4742d07c 100644 --- a/plugins/modules/terraform.py +++ b/plugins/modules/terraform.py @@ -507,7 +507,7 @@ def main(): state_file=dict(type='path'), targets=dict(type='list', elements='str', default=[]), lock=dict(type='bool', default=True), - lock_timeout=dict(type='int',), + lock_timeout=dict(type='int'), force_init=dict(type='bool', default=False), backend_config=dict(type='dict'), backend_config_files=dict(type='list', elements='path'), diff --git a/tests/unit/plugins/modules/test_oneview_datacenter_info.py b/tests/unit/plugins/modules/test_oneview_datacenter_info.py index eb5e05d229..f91625d525 100644 --- a/tests/unit/plugins/modules/test_oneview_datacenter_info.py +++ b/tests/unit/plugins/modules/test_oneview_datacenter_info.py @@ -29,7 +29,7 @@ class TestDatacenterInfoModule(FactsParamsTest): def test_should_get_all_datacenters(self): self.resource.get_all.return_value = {"name": "Data Center Name"} - self.mock_ansible_module.params = dict(config='config.json',) + self.mock_ansible_module.params = dict(config='config.json') DatacenterInfoModule().run()