ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-25 22:30:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

letsencrypt: don't mask values specified in data (#37556)

Browse source 
* Don't mask values specified in data.

This heavily improves readability of error messages such as
'Authorization for ******** returned in********:  CHALLENGE: ********-01 DETAILS: Incorrect TXT record "********" (and 1 more) found at ********.********;'
(verbatim quote).

* Added documentation.
This commit is contained in:
Felix Fontein 2018-03-18 21:51:50 +01:00 • committed by ansibot
commit 60fee5154b
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/ansible/modules/web_infrastructure/letsencrypt.py
View file

@ -128,6 +128,11 @@ options:
- "The data to validate ongoing challenges." - "The data to validate ongoing challenges."
- "The value that must be used here will be provided by a previous use - "The value that must be used here will be provided by a previous use
of this module." of this module."
- "I(Note): the C(data) option was marked as C(no_log) up to
Ansible 2.5. From Ansible 2.6 on, it is no longer marked this way
as it causes error messages to be come unusable, and C(data) does
not contain any information which can be used without having
access to the account key or which are not public anyway."
dest: dest:
description: description:
- "The destination file for the certificate." - "The destination file for the certificate."
@ -1293,7 +1298,7 @@ def main():
terms_agreed=dict(required=False, default=False, type='bool'), terms_agreed=dict(required=False, default=False, type='bool'),
challenge=dict(required=False, default='http-01', choices=['http-01', 'dns-01', 'tls-sni-02'], type='str'), challenge=dict(required=False, default='http-01', choices=['http-01', 'dns-01', 'tls-sni-02'], type='str'),
csr=dict(required=True, aliases=['src'], type='path'), csr=dict(required=True, aliases=['src'], type='path'),
data=dict(required=False, no_log=True, default=None, type='dict'), data=dict(required=False, default=None, type='dict'),
dest=dict(aliases=['cert'], type='path'), dest=dict(aliases=['cert'], type='path'),
fullchain_dest=dict(aliases=['fullchain'], type='path'), fullchain_dest=dict(aliases=['fullchain'], type='path'),
chain_dest=dict(required=False, default=None, aliases=['chain'], type='path'), chain_dest=dict(required=False, default=None, aliases=['chain'], type='path'),