ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-22 12:50:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

fix nxos_overlay_global idempotence (#28150)

Browse source 
* fix nxos_overlay_global idempotence

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* modify nxos_overlay_global unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
This commit is contained in:
Trishna Guha 2017-08-14 16:09:53 +05:30 • committed by GitHub
commit 60ce6438e3
3 changed files with 11 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
lib/ansible/modules/network/nxos/nxos_overlay_global.py
View file

@ -72,11 +72,12 @@ def get_existing(module, args):
for arg in args:
command = PARAM_TO_COMMAND_KEYMAP[arg]
has_command = re.match(r'(?:{0}\s)(?P<value>.*)$'.format(command), config, re.M)
has_command = re.findall(r'(?:{0}\s)(?P<value>.*)$'.format(command), config, re.M)
value = ''
if has_command:
value = has_command.group('value')
value = has_command[0]
existing[arg] = value
return existing
@ -102,8 +103,10 @@ def get_commands(module, existing, proposed, candidate):
else:
if 'anycast-gateway-mac' in key:
value = normalize_mac(value, module)
command = '{0} {1}'.format(key, value)
commands.append(command)
existing_value = existing_commands.get(key)
if existing_value and value != existing_value:
command = '{0} {1}'.format(key, value)
commands.append(command)
if commands:
candidate.add(commands, parents=[])