ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-25 06:10:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

nxos_linkagg mode fix (#44294)

Browse source 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
This commit is contained in:
Trishna Guha 2018-08-17 12:27:13 +05:30 • committed by GitHub
commit 6090802551
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 36 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

38
lib/ansible/modules/network/nxos/nxos_linkagg.py
View file

@ -139,6 +139,19 @@ def search_obj_in_list(group, lst):
return o return o
def get_diff(w, obj):
c = deepcopy(w)
o = deepcopy(obj)
if o['group'] == c['group'] and o.get('members') == c.get('members'):
if 'members' in o:
del o['members']
if 'members' in c:
del c['members']
diff_dict = dict(set(c.items()) - set(o.items()))
return diff_dict
def map_obj_to_commands(updates, module): def map_obj_to_commands(updates, module):
commands = list() commands = list()
want, have = updates want, have = updates
@ -208,6 +221,18 @@ def map_obj_to_commands(updates, module):
commands.append('exit') commands.append('exit')
commands.append('interface {0}'.format(m)) commands.append('interface {0}'.format(m))
commands.append('no channel-group {0}'.format(group)) commands.append('no channel-group {0}'.format(group))
else:
diff = get_diff(w, obj_in_have)
if diff and 'mode' in diff:
mode = diff['mode']
for i in members:
commands.append('interface {0}'.format(i))
if force:
commands.append('channel-group {0} force mode {1}'.format(group, mode))
else:
commands.append('channel-group {0} mode {1}'.format(group, mode))
if purge: if purge:
for h in have: for h in have:
obj_in_want = search_obj_in_list(h['group'], want) obj_in_want = search_obj_in_list(h['group'], want)
@ -310,7 +335,7 @@ def parse_channel_options(module, output, channel):
group = channel['group'] group = channel['group']
obj['group'] = group obj['group'] = group
obj['min-links'] = parse_min_links(module, group) obj['min_links'] = parse_min_links(module, group)
members = parse_members(output, group) members = parse_members(output, group)
obj['members'] = members obj['members'] = members
for m in members: for m in members:
@ -389,7 +414,16 @@ def main():
if commands: if commands:
if not module.check_mode: if not module.check_mode:
load_config(module, commands) resp = load_config(module, commands, True)
if resp:
for item in resp:
if item:
if isinstance(item, dict):
err_str = item['clierror']
else:
err_str = item
if 'cannot add' in err_str.lower():
module.fail_json(msg=err_str)
result['changed'] = True result['changed'] = True
module.exit_json(**result) module.exit_json(**result)