Fix platform agnostic network integration test cases (#32378)

* Fix platform agnostic network test cases

* Fix vyos_interface CI failure

test/integration/targets/net_banner/tests/eos/basic-login.yaml

@@ -1,7 +1,7 @@
 ---
 
 - name: setup - remove login
-  eos_banner:
+  net_banner:
     banner: login
     state: absent
     authorize: yes

test/integration/targets/net_banner/tests/eos/basic-motd.yaml

@@ -1,7 +1,7 @@
 ---
 
 - name: setup - remove motd
-  eos_banner:
+  net_banner:
     banner: motd
     state: absent
     authorize: yes
@@ -49,6 +49,43 @@
       # Ensure sessions contains epoc. Will fail after 18th May 2033
       - "result.session_name is not defined"
 
+- name: Remove motd
+  net_banner:
+    banner: motd
+    text: |
+      this is my motd banner
+      that has a multiline
+      string
+    state: absent
+    authorize: yes
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == true"
+      - "'no banner motd' in result.commands"
+      # Ensure sessions contains epoc. Will fail after 18th May 2033
+      - "'ansible_1' in result.session_name"
+
+- name: Remove motd again (idempotent)
+  net_banner:
+    banner: motd
+    text: |
+      this is my motd banner
+      that has a multiline
+      string
+    state: absent
+    authorize: yes
+    provider: "{{ cli }}"
+  register: result
+
+- assert:
+    that:
+      - "result.changed == false"
+      - "result.commands | length == 0"
+      # Ensure sessions contains epoc. Will fail after 18th May 2033
+      - "result.session_name is not defined"
 
 # FIXME add in tests for everything defined in docs
 # FIXME Test state:absent + test:

test/integration/targets/net_banner/tests/eos/basic-no-login.yaml

@@ -1,6 +1,6 @@
 ---
 - name: Setup
-  eos_banner:
+  net_banner:
     banner: login
     text: |
       Junk login banner

test/integration/targets/net_banner/tests/ios/basic-login.yaml

@@ -5,7 +5,6 @@
     banner: login
     state: absent
     authorize: yes
-    provider: "{{ cli }}"
 
 - name: Set login
   net_banner:
@@ -16,7 +15,6 @@
       string
     state: present
     authorize: yes
-    provider: "{{ cli }}"
   register: result
 
 - debug:
@@ -36,7 +34,6 @@
       string
     state: present
     authorize: yes
-    provider: "{{ cli }}"
   register: result
 
 - assert:

test/integration/targets/net_banner/tests/ios/basic-motd.yaml

@@ -4,7 +4,6 @@
     banner: motd
     state: absent
     authorize: yes
-    provider: "{{ cli }}"
 
 - name: Set motd
   net_banner:
@@ -15,7 +14,6 @@
       string
     state: present
     authorize: yes
-    provider: "{{ cli }}"
   register: result
 
 - debug:
@@ -35,7 +33,6 @@
       string
     state: present
     authorize: yes
-    provider: "{{ cli }}"
   register: result
 
 - assert:

test/integration/targets/net_banner/tests/ios/basic-no-login.yaml

@@ -7,14 +7,12 @@
       over multiple lines
     state: present
     authorize: yes
-    provider: "{{ cli }}"
 
 - name: remove login
   net_banner:
     banner: login
     state: absent
     authorize: yes
-    provider: "{{ cli }}"
   register: result
 
 - debug:
@@ -30,7 +28,6 @@
     banner: login
     state: absent
     authorize: yes
-    provider: "{{ cli }}"
   register: result
 
 - assert:

test/integration/targets/net_banner/tests/junos/basic.yaml

@@ -94,7 +94,7 @@
       - "result.changed == false"
 
 - name: delete motd banner
-  junos_banner:
+  net_banner:
     banner: motd
     state: absent
     provider: "{{ netconf }}"