mirror of
https://github.com/ansible-collections/community.general.git
synced 2025-07-25 14:20:22 -07:00
ucadapter rewrite and unit test (#49497)
* ucadapter rewrite * update skip line
This commit is contained in:
Chris Archibald
John R Barker
parent
2e4b579eb3
commit
5cc34af927
2 changed files with 213 additions and 56 deletions
|
|
@ -76,6 +76,7 @@ import traceback
|
|||
from ansible.module_utils.basic import AnsibleModule
|
||||
from ansible.module_utils._text import to_native
|
||||
import ansible.module_utils.netapp as netapp_utils
|
||||
from ansible.module_utils.netapp_module import NetAppModule
|
||||
|
||||
HAS_NETAPP_LIB = netapp_utils.has_netapp_lib()
|
||||
|
||||
|
|
@ -99,14 +100,8 @@ class NetAppOntapadapter(object):
|
|||
supports_check_mode=True
|
||||
)
|
||||
|
||||
params = self.module.params
|
||||
|
||||
# set up state variables
|
||||
self.state = params['state']
|
||||
self.adapter_name = params['adapter_name']
|
||||
self.node_name = params['node_name']
|
||||
self.mode = params['mode']
|
||||
self.type = params['type']
|
||||
self.na_helper = NetAppModule()
|
||||
self.parameters = self.na_helper.set_parameters(self.module.params)
|
||||
|
||||
if HAS_NETAPP_LIB is False:
|
||||
self.module.fail_json(msg="the python NetApp-Lib module is required")
|
||||
|
|
@ -123,96 +118,99 @@ class NetAppOntapadapter(object):
|
|||
:rtype: dict
|
||||
"""
|
||||
adapter_info = netapp_utils.zapi.NaElement('ucm-adapter-get')
|
||||
adapter_info.add_new_child('adapter-name', self.adapter_name)
|
||||
adapter_info.add_new_child('node-name', self.node_name)
|
||||
result = self.server.invoke_successfully(adapter_info, True)
|
||||
return_value = None
|
||||
adapter_attributes = result.get_child_by_name('attributes').\
|
||||
get_child_by_name('uc-adapter-info')
|
||||
return_value = {
|
||||
'mode': adapter_attributes.get_child_content('mode'),
|
||||
'pending-mode': adapter_attributes.get_child_content('pending-mode'),
|
||||
'type': adapter_attributes.get_child_content('fc4-type'),
|
||||
'pending-type': adapter_attributes.get_child_content('pending-fc4-type'),
|
||||
'status': adapter_attributes.get_child_content('status'),
|
||||
}
|
||||
return return_value
|
||||
adapter_info.add_new_child('adapter-name', self.parameters['adapter_name'])
|
||||
adapter_info.add_new_child('node-name', self.parameters['node_name'])
|
||||
try:
|
||||
result = self.server.invoke_successfully(adapter_info, True)
|
||||
except netapp_utils.zapi.NaApiError as error:
|
||||
self.module.fail_json(msg='Error fetching ucadapter details: %s: %s'
|
||||
% (self.parameters['node_name'], to_native(error)),
|
||||
exception=traceback.format_exc())
|
||||
if result.get_child_by_name('attributes'):
|
||||
adapter_attributes = result.get_child_by_name('attributes').\
|
||||
get_child_by_name('uc-adapter-info')
|
||||
return_value = {
|
||||
'mode': adapter_attributes.get_child_content('mode'),
|
||||
'pending-mode': adapter_attributes.get_child_content('pending-mode'),
|
||||
'type': adapter_attributes.get_child_content('fc4-type'),
|
||||
'pending-type': adapter_attributes.get_child_content('pending-fc4-type'),
|
||||
'status': adapter_attributes.get_child_content('status'),
|
||||
}
|
||||
return return_value
|
||||
return None
|
||||
|
||||
def modify_adapter(self):
|
||||
"""
|
||||
Modify the adapter.
|
||||
"""
|
||||
params = {'adapter-name': self.adapter_name,
|
||||
'node-name': self.node_name}
|
||||
if self.type is not None:
|
||||
params['fc4-type'] = self.type
|
||||
if self.mode is not None:
|
||||
params['mode'] = self.mode
|
||||
params = {'adapter-name': self.parameters['adapter_name'],
|
||||
'node-name': self.parameters['node_name']}
|
||||
if self.parameters['type'] is not None:
|
||||
params['fc4-type'] = self.parameters['type']
|
||||
if self.parameters['mode'] is not None:
|
||||
params['mode'] = self.parameters['mode']
|
||||
adapter_modify = netapp_utils.zapi.NaElement.create_node_with_children(
|
||||
'ucm-adapter-modify', ** params)
|
||||
try:
|
||||
self.server.invoke_successfully(adapter_modify,
|
||||
enable_tunneling=True)
|
||||
except netapp_utils.zapi.NaApiError as e:
|
||||
self.module.fail_json(msg='Error modifying adapter %s: %s' % (self.adapter_name, to_native(e)),
|
||||
self.module.fail_json(msg='Error modifying adapter %s: %s' % (self.parameters['adapter_name'], to_native(e)),
|
||||
exception=traceback.format_exc())
|
||||
|
||||
def offline_adapter(self):
|
||||
def online_or_offline_adapter(self, status):
|
||||
"""
|
||||
Bring a Fibre Channel target adapter offline.
|
||||
Bring a Fibre Channel target adapter offline/online.
|
||||
"""
|
||||
adapter_offline = netapp_utils.zapi.NaElement('fcp-adapter-config-down')
|
||||
adapter_offline.add_new_child('fcp-adapter', self.adapter_name)
|
||||
adapter_offline.add_new_child('node', self.node_name)
|
||||
if status == 'down':
|
||||
adapter = netapp_utils.zapi.NaElement('fcp-adapter-config-down')
|
||||
elif status == 'up':
|
||||
adapter = netapp_utils.zapi.NaElement('fcp-adapter-config-up')
|
||||
adapter.add_new_child('fcp-adapter', self.parameters['adapter_name'])
|
||||
adapter.add_new_child('node', self.parameters['node_name'])
|
||||
try:
|
||||
self.server.invoke_successfully(adapter_offline,
|
||||
self.server.invoke_successfully(adapter,
|
||||
enable_tunneling=True)
|
||||
except netapp_utils.zapi.NaApiError as e:
|
||||
self.module.fail_json(msg='Error trying to offline fc-adapter %s: %s' % (self.adapter_name, to_native(e)),
|
||||
self.module.fail_json(msg='Error trying to %s fc-adapter %s: %s' % (status, self.parameters['adapter_name'], to_native(e)),
|
||||
exception=traceback.format_exc())
|
||||
|
||||
def online_adapter(self):
|
||||
def autosupport_log(self):
|
||||
"""
|
||||
Bring a Fibre Channel target adapter online.
|
||||
Autosupport log for ucadater
|
||||
:return:
|
||||
"""
|
||||
adapter_online = netapp_utils.zapi.NaElement('fcp-adapter-config-up')
|
||||
adapter_online.add_new_child('fcp-adapter', self.adapter_name)
|
||||
adapter_online.add_new_child('node', self.node_name)
|
||||
try:
|
||||
self.server.invoke_successfully(adapter_online,
|
||||
enable_tunneling=True)
|
||||
except netapp_utils.zapi.NaApiError as e:
|
||||
self.module.fail_json(msg='Error trying to online fc-adapter %s: %s' % (self.adapter_name, to_native(e)),
|
||||
exception=traceback.format_exc())
|
||||
results = netapp_utils.get_cserver(self.server)
|
||||
cserver = netapp_utils.setup_na_ontap_zapi(module=self.module, vserver=results)
|
||||
netapp_utils.ems_log_event("na_ontap_ucadapter", cserver)
|
||||
|
||||
def apply(self):
|
||||
''' calling all adapter features '''
|
||||
changed = False
|
||||
results = netapp_utils.get_cserver(self.server)
|
||||
cserver = netapp_utils.setup_na_ontap_zapi(module=self.module, vserver=results)
|
||||
netapp_utils.ems_log_event("na_ontap_ucadapter", cserver)
|
||||
adapter_detail = self.get_adapter()
|
||||
|
||||
def need_to_change(expected, pending, current):
|
||||
if expected is None:
|
||||
return False
|
||||
if pending is not None:
|
||||
elif pending is not None:
|
||||
return pending != expected
|
||||
if current is not None:
|
||||
elif current is not None:
|
||||
return current != expected
|
||||
return False
|
||||
|
||||
if adapter_detail:
|
||||
changed = need_to_change(self.type, adapter_detail['pending-type'], adapter_detail['type']) or \
|
||||
need_to_change(self.mode, adapter_detail['pending-mode'], adapter_detail['mode'])
|
||||
changed = need_to_change(self.parameters.get('type'), adapter_detail['pending-type'],
|
||||
adapter_detail['type']) or need_to_change(self.parameters.get('mode'),
|
||||
adapter_detail['pending-mode'],
|
||||
adapter_detail['mode'])
|
||||
|
||||
if changed:
|
||||
if self.module.check_mode:
|
||||
pass
|
||||
else:
|
||||
self.offline_adapter()
|
||||
self.online_or_offline_adapter('down')
|
||||
self.modify_adapter()
|
||||
self.online_adapter()
|
||||
self.online_or_offline_adapter('up')
|
||||
|
||||
self.module.exit_json(changed=changed)
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue