ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-25 11:51:26 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Cmp python3 compat (#25008)

Browse source 
* Use double-quotes for expect integration tests

* Cast user input to string for expect integration tests

* Remove usage of cmp() for python3 compatibility

- Add code smell test to look for cmp usage

- Fixes #24756
This commit is contained in:
kkjang 2017-05-24 15:59:59 -07:00 • committed by Toshio Kuratomi
parent 64f63a3cac
commit 5c43bd3bae
5 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/ansible/modules/network/cloudengine/ce_ntp.py
View file

@ -478,7 +478,7 @@ class Ntp(object):
peer_type=ntp_dict['type'], prefer=is_preferred, key_id=key_id)
exp_ntp_cfg = dict(vpn_name=self.vpn_name, source_int=self.interface.lower(), address=self.address,
peer_type=self.peer_type, prefer=self.is_preferred, key_id=self.key_id)
if cmp(cur_ntp_cfg, exp_ntp_cfg) == 0:
if cur_ntp_cfg == exp_ntp_cfg:
self.conf_exsit = True
vpn_name = ntp_dict['vpnName']