ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-24 05:40:23 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix tests as filters #4 (#33930)

Browse source 
* Resolve newly added tests as filters

* Add code smell to test for ansible provided jinja tests as filters syntax

* Add docs for no-tests-as-filters code smell test

* Address tests as filters in new integration tests

* Address feedback

* Address feedback 2
This commit is contained in:
Matt Martz 2017-12-21 13:42:53 -06:00 • committed by GitHub
commit 57575d1cfa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 121 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

10
docs/docsite/rst/dev_guide/testing/sanity/no-tests-as-filters.rst Normal file
View file

@ -0,0 +1,10 @@
Sanity Tests » no-tests-as-filters
==================================
Using Ansible provided Jinja2 tests as filters will be removed in Ansible 2.9.
Prior to Ansible 2.5, Jinja2 tests included within Ansible were most often used as filters. The large difference in use is that filters are referenced as ``variable | filter_name`` where as Jinja2 tests are refereced as ``variable is test_name``.
Jinja2 tests are used for comparisons, whereas filters are used for data manipulation, and have different applications in Jinja2. This change is to help differentiate the concepts for a better understanding of Jinja2, and where each can be appropriately used.
As of Ansible 2.5 using an Ansible provided Jinja2 test with filter syntax will display a deprecation error.