ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-07-22 21:00:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

moved code that gets the vm's current hard drive profile and checks if vm_disk definition count is higher than actual vm drive count out of for loop for efficiency

Browse source
This commit is contained in:
Sebastien Couture 2016-01-08 17:22:50 -05:00 • committed by Matt Clay
commit 5674e77d7e
1 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

15
lib/ansible/modules/cloud/vmware/vsphere_guest.py
View file

@ -880,6 +880,13 @@ def reconfigure_vm(vsphere_client, vm, module, esxi, resource_pool, cluster_name
# Resize hard drives # Resize hard drives
if vm_disk: if vm_disk:
spec = spec_singleton(spec, request, vm) spec = spec_singleton(spec, request, vm)
# Get a list of the VM's hard drives
dev_list = [d for d in vm.properties.config.hardware.device if d._type=='VirtualDisk']
if len(vm_disk) > len(dev_list):
vsphere_client.disconnect()
module.fail_json(msg="Error in vm_disk definition. Too many disks defined in comparison to the VM's disk profile.")
disk_num = 0 disk_num = 0
dev_changes = [] dev_changes = []
disks_changed = {} disks_changed = {}
@ -891,12 +898,6 @@ def reconfigure_vm(vsphere_client, vm, module, esxi, resource_pool, cluster_name
except (KeyError, ValueError): except (KeyError, ValueError):
vsphere_client.disconnect() vsphere_client.disconnect()
module.fail_json(msg="Error in '%s' definition. Size needs to be specified as an integer." % disk) module.fail_json(msg="Error in '%s' definition. Size needs to be specified as an integer." % disk)
# Get a list of the hard drives
dev_list = [d for d in vm.properties.config.hardware.device if d._type=='VirtualDisk']
if disk_num >= len(dev_list):
vsphere_client.disconnect()
module.fail_json(msg="Error in '%s' definition. Too many disks defined in comparison to the VM's disk profile." % disk)
# Make sure the new disk size is higher than the current value # Make sure the new disk size is higher than the current value
dev = dev_list[disk_num] dev = dev_list[disk_num]
@ -920,7 +921,7 @@ def reconfigure_vm(vsphere_client, vm, module, esxi, resource_pool, cluster_name
spec.set_element_deviceChange(dev_changes) spec.set_element_deviceChange(dev_changes)
changes['disks'] = disks_changed changes['disks'] = disks_changed
if len(changes): if len(changes):
if shutdown and vm.is_powered_on(): if shutdown and vm.is_powered_on():