ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-26 12:21:26 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Performance improvement using in-operator on dicts

Browse source 
Just a small cleanup for the existing occurrences.

Using the in-operator for hash lookups is faster than using .keys()
http://stackoverflow.com/questions/29314269/why-do-key-in-dict-and-key-in-dict-keys-have-the-same-output
This commit is contained in:
Dag Wieers 2016-11-17 15:19:14 +01:00 • committed by Matt Clay
parent c843eeabc2
commit 54fdff16db
9 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/ansible/modules/network/nxos/nxos_vpc_interface.py
View file

@ -1013,7 +1013,7 @@ def main():
if vpc:
mapping = get_existing_portchannel_to_vpc_mappings(module)
if vpc in mapping.keys() and portchannel != mapping[vpc].strip('Po'):
if vpc in mapping and portchannel != mapping[vpc].strip('Po'):
module.fail_json(msg="This vpc is already configured on "
"another portchannel. Remove it first "
"before trying to assign it here. ",