Add error info if tabs are found in the yaml (#18343)

If a yaml file fails to load because of tabs being used
for formatting, detect that and show a error message
with more details.
This commit is contained in:
Adrian Likins 2016-11-08 11:43:08 -05:00 committed by GitHub
parent e8e09f3df6
commit 51e3ef89a9
4 changed files with 41 additions and 1 deletions

View file

@ -24,6 +24,7 @@ from six import PY3
from ansible.compat.tests import unittest
from ansible.compat.tests.mock import patch, mock_open
from ansible.errors import AnsibleParserError
from ansible.errors import yaml_strings
from ansible.parsing.dataloader import DataLoader
@ -60,6 +61,17 @@ class TestDataLoader(unittest.TestCase):
""", True)
self.assertRaises(AnsibleParserError, self._loader.load_from_file, 'dummy_yaml_bad.txt')
@patch('ansible.errors.AnsibleError._get_error_lines_from_file')
@patch.object(DataLoader, '_get_file_contents')
def test_tab_error(self, mock_def, mock_get_error_lines):
mock_def.return_value = (u"""---\nhosts: localhost\nvars:\n foo: bar\n\tblip: baz""", True)
mock_get_error_lines.return_value = ('''\tblip: baz''', '''..foo: bar''')
with self.assertRaises(AnsibleParserError) as cm:
self._loader.load_from_file('dummy_yaml_text.txt')
self.assertIn(yaml_strings.YAML_COMMON_LEADING_TAB_ERROR, str(cm.exception))
self.assertIn('foo: bar', str(cm.exception))
class TestDataLoaderWithVault(unittest.TestCase):
def setUp(self):