Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc

test/integration/targets/win_hotfix/tasks/tests.yml

@@ -21,7 +21,7 @@
 - name: assert remove an identifier that isn't installed
   assert:
     that:
-    - not remove_missing_hotfix_identifier|changed
+    - remove_missing_hotfix_identifier is not changed
 
 - name: remove a kb that isn't installed
   win_hotfix:
@@ -32,4 +32,4 @@
 - name: assert remove a kb that isn't installed
   assert:
     that:
-    - not remove_missing_hotfix_kb|changed
+    - remove_missing_hotfix_kb is not changed

test/integration/targets/win_hotfix/tasks/tests_2012R2.yml

@@ -57,7 +57,7 @@
 - name: assert install hotfix check
   assert:
     that:
-    - install_hotfix_check|changed
+    - install_hotfix_check is changed
     - install_hotfix_check.kb == test_win_hotfix_kb
     - install_hotfix_check.identifier == test_win_hotfix_identifier
     - install_hotfix_actual_check.rc != 0
@@ -75,7 +75,7 @@
 - name: assert install hotfix
   assert:
     that:
-    - install_hotfix|changed
+    - install_hotfix is changed
     - install_hotfix.kb == test_win_hotfix_kb
     - install_hotfix.identifier == test_win_hotfix_identifier
     - install_hotfix.reboot_required == False
@@ -90,7 +90,7 @@
 - name: assert install hotfix again
   assert:
     that:
-    - not install_hotfix_again|changed
+    - install_hotfix_again is not changed
     - install_hotfix_again.kb == test_win_hotfix_kb
     - install_hotfix_again.identifier == test_win_hotfix_identifier
     - install_hotfix_again.reboot_required == False
@@ -109,7 +109,7 @@
 - name: assert uninstall hotfix check
   assert:
     that:
-    - uninstall_hotfix_check|changed
+    - uninstall_hotfix_check is changed
     - uninstall_hotfix_check.kb == test_win_hotfix_kb
     - uninstall_hotfix_check.identifier == test_win_hotfix_identifier
     - uninstall_hotfix_actual_check.rc == 0
@@ -128,7 +128,7 @@
 - name: assert uninstall hotfix
   assert:
     that:
-    - uninstall_hotfix|changed
+    - uninstall_hotfix is changed
     - uninstall_hotfix.kb == test_win_hotfix_kb
     - uninstall_hotfix.identifier == test_win_hotfix_identifier
     - uninstall_hotfix.reboot_required == False
@@ -143,7 +143,7 @@
 - name: assert uninstall hotfix again
   assert:
     that:
-    - not uninstall_hotfix_again|changed
+    - uninstall_hotfix_again is not changed
     - uninstall_hotfix_again.reboot_required == False
 
 - name: install reboot hotfix
@@ -160,7 +160,7 @@
 - name: assert install reboot hotfix
   assert:
     that:
-    - install_reboot_hotfix|changed
+    - install_reboot_hotfix is changed
     - install_reboot_hotfix.kb == test_win_hotfix_reboot_kb
     - install_reboot_hotfix.identifier == test_win_hotfix_reboot_identifier
     - install_reboot_hotfix.reboot_required == True
@@ -175,7 +175,7 @@
 - name: assert install reboot again before rebooting
   assert:
     that:
-    - not install_before_rebooting|changed
+    - install_before_rebooting is not changed
     - install_before_rebooting.reboot_required == True
 
 - win_reboot:
@@ -190,7 +190,7 @@
 - name: assert install reboot hotfix again
   assert:
     that:
-    - not install_reboot_hotfix_again|changed
+    - install_reboot_hotfix_again is not changed
     - install_reboot_hotfix_again.reboot_required == False
 
 - name: uninstall hotfix with kb check
@@ -207,7 +207,7 @@
 - name: assert uninstall hotfix with kb check
   assert:
     that:
-    - uninstall_hotfix_kb_check|changed
+    - uninstall_hotfix_kb_check is changed
     - uninstall_hotfix_kb_check.kb == test_win_hotfix_reboot_kb
     - uninstall_hotfix_kb_check.identifier == test_win_hotfix_reboot_identifier
     - uninstall_hotfix_kb_check.reboot_required == False
@@ -227,7 +227,7 @@
 - name: assert uninstall hotfix with kb
   assert:
     that:
-    - uninstall_hotfix_kb|changed
+    - uninstall_hotfix_kb is changed
     - uninstall_hotfix_kb.kb == test_win_hotfix_reboot_kb
     - uninstall_hotfix_kb.identifier == test_win_hotfix_reboot_identifier
     - uninstall_hotfix_kb.reboot_required == True
@@ -244,7 +244,7 @@
 - name: assert uninstall hotfix with kb again
   assert:
     that:
-    - not uninstall_hotfix_kb_again|changed
+    - uninstall_hotfix_kb_again is not changed
     - uninstall_hotfix_kb_again.reboot_required == False
 
 - name: remove test staging folder