Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc

test/integration/targets/wait_for/tasks/main.yml

@@ -28,7 +28,7 @@
 - name: verify test for absent path
   assert:
     that:
-      - waitfor|success
+      - waitfor is successful
       - "waitfor.path == '/tmp/wait_for_file'"
       - waitfor.elapsed >= 5
       - waitfor.elapsed <= 15
@@ -46,7 +46,7 @@
 - name: verify test for absent path
   assert:
     that:
-      - waitfor|success
+      - waitfor is successful
       - "waitfor.path == '/tmp/wait_for_file'"
       - waitfor.elapsed >= 5
       - waitfor.elapsed <= 15
@@ -65,7 +65,7 @@
 - name: verify test wait for port timeout
   assert:
     that:
-      - waitfor|success
+      - waitfor is successful
       - "waitfor.search_regex == 'completed'"
       - waitfor.elapsed >= 5
       - waitfor.elapsed <= 15
@@ -79,7 +79,7 @@
 - name: verify test wait for port timeout
   assert:
     that:
-      - waitfor|failed
+      - waitfor is failed
       - waitfor.elapsed == 3
       - "waitfor.msg == 'Timeout when waiting for 127.0.0.1:12121'"
 
@@ -93,7 +93,7 @@
 - name: verify test fail with custom msg
   assert:
     that:
-      - waitfor|failed
+      - waitfor is failed
       - waitfor.elapsed == 3
       - "waitfor.msg == 'fail with custom message'"
 
@@ -110,8 +110,8 @@
 - name: verify test wait for port sleep
   assert:
     that:
-      - waitfor|success
-      - not waitfor|changed
+      - waitfor is successful
+      - waitfor is not changed
       - "waitfor.port == {{ http_port }}"
 
 - name: install psutil using pip (non-Linux only)
@@ -128,6 +128,6 @@
 - name: verify test wait for port
   assert:
     that:
-      - waitfor|success
-      - not waitfor|changed
+      - waitfor is successful
+      - waitfor is not changed
       - "waitfor.port == {{ http_port }}"