Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc
This commit is contained in:
Matt Martz 2017-11-27 16:58:08 -06:00 committed by ansibot
commit 4fe08441be
349 changed files with 4086 additions and 3844 deletions

View file

@ -261,7 +261,7 @@
assert:
that:
- "not templated.stat.exists"
- "template_result|changed"
- "template_result is changed"
- name: fill in a basic template
template: src=short.j2 dest={{output_dir}}/short.templated
@ -274,7 +274,7 @@
- name: verify that the file was marked as not changes in check mode
assert:
that:
- "not template_result|changed"
- "template_result is not changed"
- "'templated_var_loaded' in lookup('file', '{{output_dir | expanduser}}/short.templated')"
- name: change var for the template
@ -290,7 +290,7 @@
assert:
that:
- "'templated_var_loaded' in lookup('file', '{{output_dir | expanduser }}/short.templated')"
- "template_result|changed"
- "template_result is changed"
# Create a template using a child template, to ensure that variables
# are passed properly from the parent to subtemplate context (issue #20063)
@ -304,7 +304,7 @@
- name: verify that the parent and subtemplate creation worked
assert:
that:
- "template_result|changed"
- "template_result is changed"
#
# template module can overwrite a file that's been hard linked
@ -368,7 +368,7 @@
- name: verify that the file was marked as changed (Unix)
assert:
that:
- 'template_result|changed'
- 'template_result is changed'
- name: fill in a basic template again (Unix)
template:
@ -379,7 +379,7 @@
- name: verify that the template was not changed (Unix)
assert:
that:
- 'not template_result2|changed'
- 'template_result2 is not changed'
# VERIFY UNIX CONTENTS
- name: copy known good into place (Unix)
@ -414,7 +414,7 @@
- name: verify that the file was marked as changed (DOS)
assert:
that:
- 'template_result|changed'
- 'template_result is changed'
- name: fill in a basic template again (DOS)
template:
@ -426,7 +426,7 @@
- name: verify that the template was not changed (DOS)
assert:
that:
- 'not template_result2|changed'
- 'template_result2 is not changed'
# VERIFY DOS CONTENTS
- name: copy known good into place (DOS)