Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc

test/integration/targets/sensu_client/tasks/main.yml

@@ -30,8 +30,8 @@
 - name: Assert that client data was set successfully and properly
   assert:
     that:
-      - "client | success"
-      - "client | changed"
+      - "client is successful"
+      - "client is changed"
       - "client_stat.stat.exists == true"
       - "client['config']['name'] == 'client'"
       - "'default' in client['config']['subscriptions']"
@@ -65,10 +65,10 @@
 - name: Assert that client deletion was successful
   assert:
     that:
-      - "client_delete | success"
-      - "client_delete | changed"
-      - "client_delete_twice | success"
-      - "not client_delete_twice | changed"
+      - "client_delete is successful"
+      - "client_delete is changed"
+      - "client_delete_twice is successful"
+      - "client_delete_twice is not changed"
       - "client_stat.stat.exists == false"
 
 - name: Configuring a client without subscriptions should fail
@@ -80,7 +80,7 @@
 - name: Assert failure to create client
   assert:
     that:
-      - failure | failed
+      - failure is failed
       - "'the following are missing: subscriptions' in failure['msg']"
 
 - name: Configure a new client from scratch with custom parameters
@@ -137,10 +137,10 @@
 - name: Assert that client data was set successfully and properly
   assert:
     that:
-      - "client | success"
-      - "client | changed"
-      - "client_twice | success"
-      - "not client_twice | changed"
+      - "client is successful"
+      - "client is changed"
+      - "client_twice is successful"
+      - "client_twice is not changed"
       - "client_stat.stat.exists == true"
       - "client['config']['name'] == 'custom'"
       - "client['config']['address'] == 'host.fqdn'"