Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc

test/integration/targets/postgresql/tasks/main.yml

@@ -208,7 +208,7 @@
     msg: "{{ postgres_version_resp.stdout }}"
 
 - set_fact:
-    bypassrls_supported: "{{ postgres_version_resp.stdout | version_compare('9.5.0', '>=') }}"
+    bypassrls_supported: "{{ postgres_version_resp.stdout is version('9.5.0', '>=') }}"
 
 # test 'no_password_change' and 'role_attr_flags' parameters
 - include: test_no_password_change.yml

test/integration/targets/postgresql/tasks/pg_authid_not_readable.yml

@@ -13,9 +13,9 @@
 - name: "Check that task succeeded without any change"
   assert:
     that:
-      - 'not redo_as_admin|failed'
-      - 'not redo_as_admin|changed'
-      - 'redo_as_admin|success'
+      - 'redo_as_admin is not failed'
+      - 'redo_as_admin is not changed'
+      - 'redo_as_admin is successful'
 
 - name: "Check that normal user isn't allowed to access pg_authid"
   shell: 'psql -c "select * from pg_authid;" {{ db_name }} {{ db_user1 }}'
@@ -26,7 +26,7 @@
 
 - assert:
     that:
-      - 'pg_authid|failed'
+      - 'pg_authid is failed'
       - '"permission denied for relation pg_authid" in pg_authid.stderr'
 
 - name: "Normal user isn't allowed to access pg_authid relation: password comparison will fail, password will be updated"
@@ -45,6 +45,6 @@
 - name: "Check that task succeeded and that result is changed"
   assert:
     that:
-      - 'not redo_as_normal_user|failed'
-      - 'redo_as_normal_user|changed'
-      - 'redo_as_normal_user|success'
+      - 'redo_as_normal_user is not failed'
+      - 'redo_as_normal_user is changed'
+      - 'redo_as_normal_user is successful'

test/integration/targets/postgresql/tasks/test_no_password_change.yml

@@ -126,7 +126,7 @@
 
       - assert:
           that:
-            - "(postgres_version_resp.stdout | version_compare('9.5.0', '<')) or 'bypassrls:f' in result.stdout_lines[-2]"
+            - "( postgres_version_resp.stdout is version('9.5.0', '<')) or 'bypassrls:f' in result.stdout_lines[-2]"
     when: bypassrls_supported
 
   - name: Check that using same attribute a second time does nothing

test/integration/targets/postgresql/tasks/test_password.yml

@@ -22,7 +22,7 @@
   - name: 'Check that PGOPTIONS environment variable is effective (2/2)'
     assert:
       that:
-          - "{{ result|failed }}"
+          - "{{ result is failed }}"
 
   - name: 'Create a user (password encrypted: {{ encrypted }})'
     <<: *task_parameters
@@ -37,7 +37,7 @@
     - name: Check that ansible reports it was created
       assert:
         that:
-          - "{{ result|changed }}"
+          - "{{ result is changed }}"
 
   - name: Check that it was created
     <<: *task_parameters
@@ -61,7 +61,7 @@
     - name: Check that ansible reports no change
       assert:
         that:
-          - "{{ not result|changed }}"
+          - "{{ result is not changed }}"
 
   - name: 'Define an expiration time'
     <<: *task_parameters