Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc
This commit is contained in:
Matt Martz 2017-11-27 16:58:08 -06:00 committed by ansibot
commit 4fe08441be
349 changed files with 4086 additions and 3844 deletions

View file

@ -77,7 +77,7 @@
- assert:
that:
- "result.changed == true"
- result.diff.prepared | search("\+ *disable")
- result.diff.prepared is search("\+ *disable")
- name: Enable interface
net_interface:
@ -90,7 +90,7 @@
- assert:
that:
- "result.changed == true"
- result.diff.prepared | search("\- *disable")
- result.diff.prepared is search("\- *disable")
- name: Delete interface
net_interface:
@ -137,15 +137,15 @@
- assert:
that:
- 'result.changed == true'
- result.diff.prepared | search("\+ *ge-0/0/1")
- result.diff.prepared | search("\+ *description test-interface-1")
- result.diff.prepared | search("\+ *speed 1g")
- result.diff.prepared | search("\+ *mtu 512")
- result.diff.prepared | search("\+ *link-mode full-duplex")
- result.diff.prepared | search("\+ *description test-interface-2")
- result.diff.prepared | search("\+ *speed 10m")
- result.diff.prepared | search("\+ * mtu 256")
- result.diff.prepared | search("\+ *link-mode full-duplex")
- result.diff.prepared is search("\+ *ge-0/0/1")
- result.diff.prepared is search("\+ *description test-interface-1")
- result.diff.prepared is search("\+ *speed 1g")
- result.diff.prepared is search("\+ *mtu 512")
- result.diff.prepared is search("\+ *link-mode full-duplex")
- result.diff.prepared is search("\+ *description test-interface-2")
- result.diff.prepared is search("\+ *speed 10m")
- result.diff.prepared is search("\+ * mtu 256")
- result.diff.prepared is search("\+ *link-mode full-duplex")
- name: Set interface on aggregate (idempotent)
net_interface:
@ -172,7 +172,7 @@
- assert:
that:
- 'result.changed == true'
- result.diff.prepared | search("\+ *disable")
- result.diff.prepared is search("\+ *disable")
- name: Enable interface on aggregate
net_interface:
@ -186,7 +186,7 @@
- assert:
that:
- 'result.changed == true'
- result.diff.prepared | search("\- *disable")
- result.diff.prepared is search("\- *disable")
- name: Delete interface on aggregate
net_interface:
@ -200,15 +200,15 @@
- assert:
that:
- 'result.changed == true'
- result.diff.prepared | search("\- *ge-0/0/1")
- result.diff.prepared | search("\- *description test-interface-1")
- result.diff.prepared | search("\- *speed 1g")
- result.diff.prepared | search("\- *mtu 512")
- result.diff.prepared | search("\- *link-mode full-duplex")
- result.diff.prepared | search("\- *description test-interface-2")
- result.diff.prepared | search("\- *speed 10m")
- result.diff.prepared | search("\- * mtu 256")
- result.diff.prepared | search("\- *link-mode full-duplex")
- result.diff.prepared is search("\- *ge-0/0/1")
- result.diff.prepared is search("\- *description test-interface-1")
- result.diff.prepared is search("\- *speed 1g")
- result.diff.prepared is search("\- *mtu 512")
- result.diff.prepared is search("\- *link-mode full-duplex")
- result.diff.prepared is search("\- *description test-interface-2")
- result.diff.prepared is search("\- *speed 10m")
- result.diff.prepared is search("\- * mtu 256")
- result.diff.prepared is search("\- *link-mode full-duplex")
- name: Delete interface on aggregate (idempotent)
net_interface:

View file

@ -10,12 +10,12 @@
- name: Define interface name for vSRX
set_fact:
name: pp0
when: result['ansible_facts']['ansible_net_model'] | search("vSRX*")
when: result['ansible_facts']['ansible_net_model'] is search("vSRX*")
- name: Define interface name for vQFX
set_fact:
name: gr-0/0/0
when: result['ansible_facts']['ansible_net_model'] | search("vqfx*")
when: result['ansible_facts']['ansible_net_model'] is search("vqfx*")
- name: Check intent arguments
net_interface:
@ -58,7 +58,7 @@
- assert:
that:
- "result.failed == false"
- result.diff.prepared | search("\+ *disable")
- result.diff.prepared is search("\+ *disable")
- name: Config + intent (fail)
net_interface: