Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc
This commit is contained in:
Matt Martz 2017-11-27 16:58:08 -06:00 committed by ansibot
commit 4fe08441be
349 changed files with 4086 additions and 3844 deletions

View file

@ -23,13 +23,13 @@
- assert:
that:
- "result.changed == true"
- result.diff.prepared | search("\+ *test-1")
- result.diff.prepared | search("\+ *description test-vrf-1")
- result.diff.prepared | search("\+ *instance-type vrf")
- result.diff.prepared | search("\+ *interface ge-0/0/5.0")
- result.diff.prepared | search("\+ *interface ge-0/0/6.0")
- result.diff.prepared | search("\+ *route-distinguisher 3.3.3.3:10")
- result.diff.prepared | search("\+ *vrf-target target:65513:111")
- result.diff.prepared is search("\+ *test-1")
- result.diff.prepared is search("\+ *description test-vrf-1")
- result.diff.prepared is search("\+ *instance-type vrf")
- result.diff.prepared is search("\+ *interface ge-0/0/5.0")
- result.diff.prepared is search("\+ *interface ge-0/0/6.0")
- result.diff.prepared is search("\+ *route-distinguisher 3.3.3.3:10")
- result.diff.prepared is search("\+ *vrf-target target:65513:111")
- name: Configure vrf and its parameter (idempotent)
junos_vrf:
@ -65,11 +65,11 @@
that:
- "result.changed == true"
- "'[edit routing-instances test-1]' in result.diff.prepared"
- result.diff.prepared | search("\+ *interface ge-0/0/2.0")
- result.diff.prepared | search("\+ *interface ge-0/0/3.0")
- result.diff.prepared is search("\+ *interface ge-0/0/2.0")
- result.diff.prepared is search("\+ *interface ge-0/0/3.0")
- "'[edit routing-instances test-1]' in result.diff.prepared"
- result.diff.prepared | search("\+ *route-distinguisher 1.1.1.1:10")
- result.diff.prepared | search("\+ *vrf-target target:65514:113")
- result.diff.prepared is search("\+ *route-distinguisher 1.1.1.1:10")
- result.diff.prepared is search("\+ *vrf-target target:65514:113")
- name: Deactivate vrf
junos_vrf:
@ -89,13 +89,13 @@
that:
- "result.changed == true"
- "'[edit routing-instances]' in result.diff.prepared"
- result.diff.prepared | search("! *inactive[:] test-1")
- result.diff.prepared is search("! *inactive[:] test-1")
- "'[edit routing-instances test-1]' in result.diff.prepared"
- result.diff.prepared | search("! *inactive[:] interface ge-0/0/2.0")
- result.diff.prepared | search("! *inactive[:] interface ge-0/0/3.0")
- result.diff.prepared is search("! *inactive[:] interface ge-0/0/2.0")
- result.diff.prepared is search("! *inactive[:] interface ge-0/0/3.0")
- "'[edit routing-instances test-1]' in result.diff.prepared"
- result.diff.prepared | search("! *inactive[:] route-distinguisher")
- result.diff.prepared | search("! *inactive[:] vrf-target")
- result.diff.prepared is search("! *inactive[:] route-distinguisher")
- result.diff.prepared is search("! *inactive[:] vrf-target")
- name: Activate vrf
junos_vrf:
@ -115,13 +115,13 @@
that:
- "result.changed == true"
- "'[edit routing-instances]' in result.diff.prepared"
- result.diff.prepared | search("! *active[:] test-1")
- result.diff.prepared is search("! *active[:] test-1")
- "'[edit routing-instances test-1]' in result.diff.prepared"
- result.diff.prepared | search("! *active[:] interface ge-0/0/2.0")
- result.diff.prepared | search("! *active[:] interface ge-0/0/3.0")
- result.diff.prepared is search("! *active[:] interface ge-0/0/2.0")
- result.diff.prepared is search("! *active[:] interface ge-0/0/3.0")
- "'[edit routing-instances test-1]' in result.diff.prepared"
- result.diff.prepared | search("! *active[:] route-distinguisher")
- result.diff.prepared | search("! *active[:] vrf-target")
- result.diff.prepared is search("! *active[:] route-distinguisher")
- result.diff.prepared is search("! *active[:] vrf-target")
- name: Delete vrf
junos_vrf:
@ -139,13 +139,13 @@
- assert:
that:
- "result.changed == true"
- result.diff.prepared | search("\- *test-1")
- result.diff.prepared | search("\- *description test-vrf-1")
- result.diff.prepared | search("\- *instance-type vrf")
- result.diff.prepared | search("\- *interface ge-0/0/2.0")
- result.diff.prepared | search("\- *interface ge-0/0/3.0")
- result.diff.prepared | search("\- *route-distinguisher 1.1.1.1:10")
- result.diff.prepared | search("\- *vrf-target target:65514:113")
- result.diff.prepared is search("\- *test-1")
- result.diff.prepared is search("\- *description test-vrf-1")
- result.diff.prepared is search("\- *instance-type vrf")
- result.diff.prepared is search("\- *interface ge-0/0/2.0")
- result.diff.prepared is search("\- *interface ge-0/0/3.0")
- result.diff.prepared is search("\- *route-distinguisher 1.1.1.1:10")
- result.diff.prepared is search("\- *vrf-target target:65514:113")
- name: Delete vrf (idempotent)
junos_vrf:
@ -196,20 +196,20 @@
- assert:
that:
- "result.changed == true"
- result.diff.prepared | search("\+ *test-1")
- result.diff.prepared | search("\+ *description test-vrf-1")
- result.diff.prepared | search("\+ *instance-type vrf")
- result.diff.prepared | search("\+ *interface ge-0/0/2.0")
- result.diff.prepared | search("\+ *interface ge-0/0/3.0")
- result.diff.prepared | search("\+ *route-distinguisher 1.1.1.1:10")
- result.diff.prepared | search("\+ *vrf-target target:65514:113")
- result.diff.prepared | search("\+ *test-2")
- result.diff.prepared | search("\+ *description test-vrf-2")
- result.diff.prepared | search("\+ *instance-type vrf")
- result.diff.prepared | search("\+ *interface ge-0/0/4.0")
- result.diff.prepared | search("\+ *interface ge-0/0/5.0")
- result.diff.prepared | search("\+ *route-distinguisher 2.2.2.2:10")
- result.diff.prepared | search("\+ *vrf-target target:65515:114")
- result.diff.prepared is search("\+ *test-1")
- result.diff.prepared is search("\+ *description test-vrf-1")
- result.diff.prepared is search("\+ *instance-type vrf")
- result.diff.prepared is search("\+ *interface ge-0/0/2.0")
- result.diff.prepared is search("\+ *interface ge-0/0/3.0")
- result.diff.prepared is search("\+ *route-distinguisher 1.1.1.1:10")
- result.diff.prepared is search("\+ *vrf-target target:65514:113")
- result.diff.prepared is search("\+ *test-2")
- result.diff.prepared is search("\+ *description test-vrf-2")
- result.diff.prepared is search("\+ *instance-type vrf")
- result.diff.prepared is search("\+ *interface ge-0/0/4.0")
- result.diff.prepared is search("\+ *interface ge-0/0/5.0")
- result.diff.prepared is search("\+ *route-distinguisher 2.2.2.2:10")
- result.diff.prepared is search("\+ *vrf-target target:65515:114")
- name: Deactivate vrf configuration using aggregate
junos_vrf:
@ -236,15 +236,15 @@
that:
- "result.changed == true"
- "'edit routing-instances test-1' in result.diff.prepared"
- result.diff.prepared | search("! *inactive[:] interface ge-0/0/2.0")
- result.diff.prepared | search("! *inactive[:] interface ge-0/0/3.0")
- result.diff.prepared | search("! *inactive[:] route-distinguisher")
- result.diff.prepared | search("! *inactive[:] vrf-target")
- result.diff.prepared is search("! *inactive[:] interface ge-0/0/2.0")
- result.diff.prepared is search("! *inactive[:] interface ge-0/0/3.0")
- result.diff.prepared is search("! *inactive[:] route-distinguisher")
- result.diff.prepared is search("! *inactive[:] vrf-target")
- "'edit routing-instances test-2' in result.diff.prepared"
- result.diff.prepared | search("! *inactive[:] interface ge-0/0/4.0")
- result.diff.prepared | search("! *inactive[:] interface ge-0/0/5.0")
- result.diff.prepared | search("! *inactive[:] route-distinguisher")
- result.diff.prepared | search("! *inactive[:] vrf-target")
- result.diff.prepared is search("! *inactive[:] interface ge-0/0/4.0")
- result.diff.prepared is search("! *inactive[:] interface ge-0/0/5.0")
- result.diff.prepared is search("! *inactive[:] route-distinguisher")
- result.diff.prepared is search("! *inactive[:] vrf-target")
- name: Deactivate vrf configuration using aggregate
junos_vrf:
@ -271,15 +271,15 @@
that:
- "result.changed == true"
- "'edit routing-instances test-1' in result.diff.prepared"
- result.diff.prepared | search("! *active[:] interface ge-0/0/2.0")
- result.diff.prepared | search("! *active[:] interface ge-0/0/3.0")
- result.diff.prepared | search("! *active[:] route-distinguisher")
- result.diff.prepared | search("! *active[:] vrf-target")
- result.diff.prepared is search("! *active[:] interface ge-0/0/2.0")
- result.diff.prepared is search("! *active[:] interface ge-0/0/3.0")
- result.diff.prepared is search("! *active[:] route-distinguisher")
- result.diff.prepared is search("! *active[:] vrf-target")
- "'edit routing-instances test-2' in result.diff.prepared"
- result.diff.prepared | search("! *active[:] interface ge-0/0/4.0")
- result.diff.prepared | search("! *active[:] interface ge-0/0/5.0")
- result.diff.prepared | search("! *active[:] route-distinguisher")
- result.diff.prepared | search("! *active[:] vrf-target")
- result.diff.prepared is search("! *active[:] interface ge-0/0/4.0")
- result.diff.prepared is search("! *active[:] interface ge-0/0/5.0")
- result.diff.prepared is search("! *active[:] route-distinguisher")
- result.diff.prepared is search("! *active[:] vrf-target")
- name: Delete vrf configuration using aggregate
junos_vrf:
@ -293,20 +293,20 @@
- assert:
that:
- "result.changed == true"
- result.diff.prepared | search("\- *test-1")
- result.diff.prepared | search("\- *description test-vrf-1")
- result.diff.prepared | search("\- *instance-type vrf")
- result.diff.prepared | search("\- *interface ge-0/0/2.0")
- result.diff.prepared | search("\- *interface ge-0/0/3.0")
- result.diff.prepared | search("\- *route-distinguisher 1.1.1.1:10")
- result.diff.prepared | search("\- *vrf-target target:65514:113")
- result.diff.prepared | search("\- *test-2")
- result.diff.prepared | search("\- *description test-vrf-2")
- result.diff.prepared | search("\- *instance-type vrf")
- result.diff.prepared | search("\- *interface ge-0/0/4.0")
- result.diff.prepared | search("\- *interface ge-0/0/5.0")
- result.diff.prepared | search("\- *route-distinguisher 2.2.2.2:10")
- result.diff.prepared | search("\- *vrf-target target:65515:114")
- result.diff.prepared is search("\- *test-1")
- result.diff.prepared is search("\- *description test-vrf-1")
- result.diff.prepared is search("\- *instance-type vrf")
- result.diff.prepared is search("\- *interface ge-0/0/2.0")
- result.diff.prepared is search("\- *interface ge-0/0/3.0")
- result.diff.prepared is search("\- *route-distinguisher 1.1.1.1:10")
- result.diff.prepared is search("\- *vrf-target target:65514:113")
- result.diff.prepared is search("\- *test-2")
- result.diff.prepared is search("\- *description test-vrf-2")
- result.diff.prepared is search("\- *instance-type vrf")
- result.diff.prepared is search("\- *interface ge-0/0/4.0")
- result.diff.prepared is search("\- *interface ge-0/0/5.0")
- result.diff.prepared is search("\- *route-distinguisher 2.2.2.2:10")
- result.diff.prepared is search("\- *vrf-target target:65515:114")
- name: Delete vrf configuration using aggregate (idempotent)
junos_vrf: