Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc
This commit is contained in:
Matt Martz 2017-11-27 16:58:08 -06:00 committed by ansibot
commit 4fe08441be
349 changed files with 4086 additions and 3844 deletions

View file

@ -29,8 +29,8 @@
- "result.changed == true"
- "'<name>1.1.1.1/32</name>' in config.xml"
- "'<name>fd5d:12c9:2201:1::1/128</name>' in config.xml"
- result.diff.prepared | search("\+ *address 1.1.1.1/32")
- result.diff.prepared | search("\+ *address fd5d:12c9:2201:1::1/128")
- result.diff.prepared is search("\+ *address 1.1.1.1/32")
- result.diff.prepared is search("\+ *address fd5d:12c9:2201:1::1/128")
- name: Configure interface address (idempotent)
junos_l3_interface:
@ -65,8 +65,8 @@
that:
- "result.changed == true"
- "'<address inactive=\"inactive\">' in config.xml"
- result.diff.prepared | search("! *inactive[:] address 1.1.1.1/32")
- result.diff.prepared | search("! *inactive[:] address fd5d:12c9:2201:1::1/128")
- result.diff.prepared is search("! *inactive[:] address 1.1.1.1/32")
- result.diff.prepared is search("! *inactive[:] address fd5d:12c9:2201:1::1/128")
- name: Activate interface address
junos_l3_interface:
@ -81,8 +81,8 @@
- assert:
that:
- "result.changed == true"
- result.diff.prepared | search("! *active[:] address 1.1.1.1/32")
- result.diff.prepared | search("! *active[:] address fd5d:12c9:2201:1::1/128")
- result.diff.prepared is search("! *active[:] address 1.1.1.1/32")
- result.diff.prepared is search("! *active[:] address fd5d:12c9:2201:1::1/128")
- name: Delete interface address
junos_l3_interface:
@ -95,8 +95,8 @@
- assert:
that:
- result.diff.prepared | search("\- *address 1.1.1.1/32")
- result.diff.prepared | search("\- *address fd5d:12c9:2201:1::1/128")
- result.diff.prepared is search("\- *address 1.1.1.1/32")
- result.diff.prepared is search("\- *address fd5d:12c9:2201:1::1/128")
- name: Delete interface address (idempotent)
junos_l3_interface:
@ -145,13 +145,13 @@
that:
- 'result.changed == true'
- "'edit interfaces ge-0/0/1 unit 0 family inet' in result.diff.prepared"
- result.diff.prepared | search("\+ *address 1.1.1.1/32")
- result.diff.prepared is search("\+ *address 1.1.1.1/32")
- "'edit interfaces ge-0/0/1 unit 0 family inet6' in result.diff.prepared"
- result.diff.prepared | search("\+ *address fd5d:12c9:2201:1::1/128")
- result.diff.prepared is search("\+ *address fd5d:12c9:2201:1::1/128")
- "'edit interfaces ge-0/0/2 unit 0 family inet' in result.diff.prepared"
- result.diff.prepared | search("\+ *address 2.2.2.2/32")
- result.diff.prepared is search("\+ *address 2.2.2.2/32")
- "'edit interfaces ge-0/0/2 unit 0 family inet6' in result.diff.prepared"
- result.diff.prepared | search("\+ *address fd5d:12c9:2201:2::2/128")
- result.diff.prepared is search("\+ *address fd5d:12c9:2201:2::2/128")
- name: Configure l3 interface in aggregate (idempotent)
junos_l3_interface:
@ -186,10 +186,10 @@
- assert:
that:
- 'result.changed == true'
- result.diff.prepared | search("! *inactive[:] address 1.1.1.1/32")
- result.diff.prepared | search("! *inactive[:] address fd5d:12c9:2201:1::1/128")
- result.diff.prepared | search("! *inactive[:] address 2.2.2.2/32")
- result.diff.prepared | search("! *inactive[:] address fd5d:12c9:2201:2::2/128")
- result.diff.prepared is search("! *inactive[:] address 1.1.1.1/32")
- result.diff.prepared is search("! *inactive[:] address fd5d:12c9:2201:1::1/128")
- result.diff.prepared is search("! *inactive[:] address 2.2.2.2/32")
- result.diff.prepared is search("! *inactive[:] address fd5d:12c9:2201:2::2/128")
- name: Activate l3 interface configuration
junos_l3_interface:
@ -207,10 +207,10 @@
- assert:
that:
- 'result.changed == true'
- result.diff.prepared | search("! *active[:] address 1.1.1.1/32")
- result.diff.prepared | search("! *active[:] address fd5d:12c9:2201:1::1/128")
- result.diff.prepared | search("! *active[:] address 2.2.2.2/32")
- result.diff.prepared | search("! *active[:] address fd5d:12c9:2201:2::2/128")
- result.diff.prepared is search("! *active[:] address 1.1.1.1/32")
- result.diff.prepared is search("! *active[:] address fd5d:12c9:2201:1::1/128")
- result.diff.prepared is search("! *active[:] address 2.2.2.2/32")
- result.diff.prepared is search("! *active[:] address fd5d:12c9:2201:2::2/128")
- name: Delete l3 interface configuration
junos_l3_interface:
@ -229,13 +229,13 @@
that:
- 'result.changed == true'
- "'edit interfaces ge-0/0/1 unit 0 family inet' in result.diff.prepared"
- result.diff.prepared | search("\- *address 1.1.1.1/32")
- result.diff.prepared is search("\- *address 1.1.1.1/32")
- "'edit interfaces ge-0/0/1 unit 0 family inet6' in result.diff.prepared"
- result.diff.prepared | search("\- *address fd5d:12c9:2201:1::1/128")
- result.diff.prepared is search("\- *address fd5d:12c9:2201:1::1/128")
- "'edit interfaces ge-0/0/2 unit 0 family inet' in result.diff.prepared"
- result.diff.prepared | search("\- *address 2.2.2.2/32")
- result.diff.prepared is search("\- *address 2.2.2.2/32")
- "'edit interfaces ge-0/0/2 unit 0 family inet6' in result.diff.prepared"
- result.diff.prepared | search("\- *address fd5d:12c9:2201:2::2/128")
- result.diff.prepared is search("\- *address fd5d:12c9:2201:2::2/128")
- name: Delete l3 interface configuration (idempotent)
junos_l3_interface: