Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc
This commit is contained in:
Matt Martz 2017-11-27 16:58:08 -06:00 committed by ansibot
commit 4fe08441be
349 changed files with 4086 additions and 3844 deletions

View file

@ -8,7 +8,7 @@
- name: verify setup
assert:
that:
- vpc|success
- vpc is successful
- name: test fail missing name of vpc
cs_vpc:
@ -18,7 +18,7 @@
- name: verify test fail missing name of vpc
assert:
that:
- vpc|failed
- vpc is failed
- "vpc.msg.startswith('missing required arguments: ')"
- name: test fail missing cidr for vpc
@ -30,7 +30,7 @@
- name: verify test fail missing cidr for vpc
assert:
that:
- vpc|failed
- vpc is failed
- 'vpc.msg == "state is present but all of the following are missing: cidr"'
- name: test fail missing vpc offering not found
@ -44,7 +44,7 @@
- name: verify test fail missing cidr for vpc
assert:
that:
- vpc|failed
- vpc is failed
- 'vpc.msg == "VPC offering not found: does_not_exist"'
- name: test create vpc with custom offering in check mode
@ -59,8 +59,8 @@
- name: verify test create vpc with custom offering in check mode
assert:
that:
- vpc|success
- vpc|changed
- vpc is successful
- vpc is changed
- name: test create vpc with custom offering
cs_vpc:
@ -73,8 +73,8 @@
- name: verify test create vpc with custom offering
assert:
that:
- vpc|success
- vpc|changed
- vpc is successful
- vpc is changed
- vpc.name == "{{ cs_resource_prefix }}_vpc_custom"
- vpc.display_text == "{{ cs_resource_prefix }}_display_text_custom"
- vpc.cidr == "10.10.1.0/16"
@ -90,8 +90,8 @@
- name: verify test create vpc with custom offering idempotence
assert:
that:
- vpc|success
- not vpc|changed
- vpc is successful
- vpc is not changed
- vpc.name == "{{ cs_resource_prefix }}_vpc_custom"
- vpc.display_text == "{{ cs_resource_prefix }}_display_text_custom"
- vpc.cidr == "10.10.1.0/16"
@ -107,8 +107,8 @@
- name: verify test create vpc with default offering in check mode
assert:
that:
- vpc|success
- vpc|changed
- vpc is successful
- vpc is changed
- name: test create vpc with default offering
cs_vpc:
@ -120,8 +120,8 @@
- name: verify test create vpc with default offering
assert:
that:
- vpc|success
- vpc|changed
- vpc is successful
- vpc is changed
- vpc.name == "{{ cs_resource_prefix }}_vpc"
- vpc.display_text == "{{ cs_resource_prefix }}_display_text"
- vpc.cidr == "10.10.0.0/16"
@ -136,8 +136,8 @@
- name: verify test create vpc with default offering idempotence
assert:
that:
- vpc|success
- not vpc|changed
- vpc is successful
- vpc is not changed
- vpc.name == "{{ cs_resource_prefix }}_vpc"
- vpc.display_text == "{{ cs_resource_prefix }}_display_text"
- vpc.cidr == "10.10.0.0/16"
@ -151,8 +151,8 @@
- name: verify test create vpc idempotence2
assert:
that:
- vpc|success
- not vpc|changed
- vpc is successful
- vpc is not changed
- vpc.name == "{{ cs_resource_prefix }}_vpc"
- vpc.display_text == "{{ cs_resource_prefix }}_display_text"
- vpc.cidr == "10.10.0.0/16"
@ -168,8 +168,8 @@
- name: verify test update vpc with default offering in check mode
assert:
that:
- vpc|success
- vpc|changed
- vpc is successful
- vpc is changed
- vpc.name == "{{ cs_resource_prefix }}_vpc"
- vpc.display_text == "{{ cs_resource_prefix }}_display_text"
- vpc.cidr == "10.10.0.0/16"
@ -184,8 +184,8 @@
- name: verify test update vpc with default offering
assert:
that:
- vpc|success
- vpc|changed
- vpc is successful
- vpc is changed
- vpc.name == "{{ cs_resource_prefix }}_vpc"
- vpc.display_text == "{{ cs_resource_prefix }}_display_text2"
- vpc.cidr == "10.10.0.0/16"
@ -200,8 +200,8 @@
- name: verify test update vpc idempotence
assert:
that:
- vpc|success
- not vpc|changed
- vpc is successful
- vpc is not changed
- vpc.name == "{{ cs_resource_prefix }}_vpc"
- vpc.display_text == "{{ cs_resource_prefix }}_display_text2"
- vpc.cidr == "10.10.0.0/16"
@ -219,8 +219,8 @@
- name: verify test restart vpc with default offering with clean up in check mode
assert:
that:
- vpc|success
- vpc|changed
- vpc is successful
- vpc is changed
- vpc.name == "{{ cs_resource_prefix }}_vpc"
- vpc.display_text == "{{ cs_resource_prefix }}_display_text2"
- vpc.cidr == "10.10.0.0/16"
@ -237,8 +237,8 @@
- name: verify test restart vpc with default offering with clean up
assert:
that:
- vpc|success
- vpc|changed
- vpc is successful
- vpc is changed
- vpc.name == "{{ cs_resource_prefix }}_vpc"
- vpc.display_text == "{{ cs_resource_prefix }}_display_text2"
- vpc.cidr == "10.10.0.0/16"
@ -254,8 +254,8 @@
- name: verify test restart vpc with default offering without clean up
assert:
that:
- vpc|success
- vpc|changed
- vpc is successful
- vpc is changed
- vpc.name == "{{ cs_resource_prefix }}_vpc"
- vpc.display_text == "{{ cs_resource_prefix }}_display_text2"
- vpc.cidr == "10.10.0.0/16"
@ -273,8 +273,8 @@
- name: verify test create network in vpc in check mode
assert:
that:
- vpc_net|success
- vpc_net|changed
- vpc_net is successful
- vpc_net is changed
- name: test create network in vpc
cs_network:
@ -288,8 +288,8 @@
- name: verify test create network in vpc
assert:
that:
- vpc_net|success
- vpc_net|changed
- vpc_net is successful
- vpc_net is changed
- vpc_net.name == "{{ cs_resource_prefix }}_net_vpc"
- name: test create network in vpc idempotence
@ -304,8 +304,8 @@
- name: verify test create network in vpc idempotence
assert:
that:
- vpc_net|success
- not vpc_net|changed
- vpc_net is successful
- vpc_net is not changed
- vpc_net.name == "{{ cs_resource_prefix }}_net_vpc"
- name: test create instance in vpc in check mode
@ -320,8 +320,8 @@
- name: verify test create instance in vpc in check mode
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- name: test create instance in vpc
cs_instance:
@ -334,8 +334,8 @@
- name: verify test create instance in vpc
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.name == "{{ cs_resource_prefix }}-vm-vpc"
- instance.state == "Running"
@ -350,8 +350,8 @@
- name: verify test create instance in vpc idempotence
assert:
that:
- instance|success
- not instance|changed
- instance is successful
- instance is not changed
- instance.name == "{{ cs_resource_prefix }}-vm-vpc"
- instance.state == "Running"
@ -375,8 +375,8 @@
- name: verify test static nat in vpc in check mode
assert:
that:
- static_nat|success
- static_nat|changed
- static_nat is successful
- static_nat is changed
- name: test static nat in vpc
cs_staticnat:
@ -389,8 +389,8 @@
- name: verify test static nat in vpc
assert:
that:
- static_nat|success
- static_nat|changed
- static_nat is successful
- static_nat is changed
- name: test static nat in vpc idempotence
cs_staticnat:
@ -403,8 +403,8 @@
- name: verify test static nat in vpc idempotence
assert:
that:
- static_nat|success
- not static_nat|changed
- static_nat is successful
- static_nat is not changed
- name: test remove static nat in vpc in check mode
cs_staticnat:
@ -419,8 +419,8 @@
- name: verify test remove static nat in vpc in check mode
assert:
that:
- static_nat|success
- static_nat|changed
- static_nat is successful
- static_nat is changed
- name: test remove static nat in vpc
cs_staticnat:
@ -434,8 +434,8 @@
- name: verify test remove static nat in vpc
assert:
that:
- static_nat|success
- static_nat|changed
- static_nat is successful
- static_nat is changed
- name: test remove static nat in vpc idempotence
cs_staticnat:
@ -449,8 +449,8 @@
- name: verify test remove static nat in vpc idempotence
assert:
that:
- static_nat|success
- not static_nat|changed
- static_nat is successful
- static_nat is not changed
- name: test create port forwarding in vpc in check mode
cs_portforward:
@ -466,8 +466,8 @@
- name: verify test create port forwarding in vpc in check mode
assert:
that:
- port_forward|success
- port_forward|changed
- port_forward is successful
- port_forward is changed
- name: test create port forwarding in vpc
cs_portforward:
@ -482,8 +482,8 @@
- name: verify test create port forwarding in vpc
assert:
that:
- port_forward|success
- port_forward|changed
- port_forward is successful
- port_forward is changed
- name: test create port forwarding in vpc idempotence
cs_portforward:
@ -498,8 +498,8 @@
- name: verify test create port forwarding in vpc idempotence
assert:
that:
- port_forward|success
- not port_forward|changed
- port_forward is successful
- port_forward is not changed
- name: test remove port forwarding in vpc in check mode
cs_portforward:
@ -516,8 +516,8 @@
- name: verify test remove port forwarding in vpc in check mode
assert:
that:
- port_forward|success
- port_forward|changed
- port_forward is successful
- port_forward is changed
- name: test remove port forwarding in vpc
cs_portforward:
@ -533,8 +533,8 @@
- name: verify test remove port forwarding in vpc
assert:
that:
- port_forward|success
- port_forward|changed
- port_forward is successful
- port_forward is changed
- name: test remove port forwarding in vpc idempotence
cs_portforward:
@ -550,8 +550,8 @@
- name: verify test remove port forwarding in vpc idempotence
assert:
that:
- port_forward|success
- not port_forward|changed
- port_forward is successful
- port_forward is not changed
- name: test remove ip address from vpc
cs_ip_address:
@ -564,8 +564,8 @@
- name: verify test remove ip address from vpc
assert:
that:
- ip_address_removed|success
- ip_address_removed|changed
- ip_address_removed is successful
- ip_address_removed is changed
- name: test remove instance in vpc in check mdoe
cs_instance:
@ -577,8 +577,8 @@
- name: verify test remove instance in vpc in check mode
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.name == "{{ cs_resource_prefix }}-vm-vpc"
- instance.state == "Running"
@ -591,8 +591,8 @@
- name: verify test remove instance in vpc
assert:
that:
- instance|success
- instance|changed
- instance is successful
- instance is changed
- instance.name == "{{ cs_resource_prefix }}-vm-vpc"
- instance.state == "Running"
@ -605,8 +605,8 @@
- name: verify test remove instance in vpc idempotence
assert:
that:
- instance|success
- not instance|changed
- instance is successful
- instance is not changed
- name: test remove network in vpc in check mode
cs_network:
@ -619,8 +619,8 @@
- name: verify test remove network in vpc in check mode
assert:
that:
- vpc_net|success
- vpc_net|changed
- vpc_net is successful
- vpc_net is changed
- vpc_net.name == "{{ cs_resource_prefix }}_net_vpc"
- name: test remove network in vpc
@ -633,8 +633,8 @@
- name: verify test remove network in vpc
assert:
that:
- vpc_net|success
- vpc_net|changed
- vpc_net is successful
- vpc_net is changed
- vpc_net.name == "{{ cs_resource_prefix }}_net_vpc"
- name: test remove network in vpc idempotence
@ -647,8 +647,8 @@
- name: verify test remove network in vpc idempotence
assert:
that:
- vpc_net|success
- not vpc_net|changed
- vpc_net is successful
- vpc_net is not changed
- name: test remove vpc with default offering in check mode
cs_vpc:
@ -660,8 +660,8 @@
- name: verify test remove vpc with default offering in check mode
assert:
that:
- vpc|success
- vpc|changed
- vpc is successful
- vpc is changed
- vpc.name == "{{ cs_resource_prefix }}_vpc"
- vpc.display_text == "{{ cs_resource_prefix }}_display_text2"
- vpc.cidr == "10.10.0.0/16"
@ -675,8 +675,8 @@
- name: verify test remove vpc with default offering
assert:
that:
- vpc|success
- vpc|changed
- vpc is successful
- vpc is changed
- vpc.name == "{{ cs_resource_prefix }}_vpc"
- vpc.display_text == "{{ cs_resource_prefix }}_display_text2"
- vpc.cidr == "10.10.0.0/16"
@ -689,8 +689,8 @@
- name: verify test remove vpc idempotence
assert:
that:
- vpc|success
- not vpc|changed
- vpc is successful
- vpc is not changed
- name: test remove vpc with custom offering
cs_vpc:
@ -701,7 +701,7 @@
- name: verify test remove vpc with custom offering
assert:
that:
- vpc|success
- vpc|changed
- vpc is successful
- vpc is changed
- vpc.name == "{{ cs_resource_prefix }}_vpc_custom"
- vpc.cidr == "10.10.1.0/16"