Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc

test/integration/targets/cs_vmsnapshot/tasks/main.yml

@@ -8,7 +8,7 @@
 - name: verify create instance
   assert:
     that:
-    - instance|success
+    - instance is successful
 
 - name: ensure no snapshot exists
   cs_vmsnapshot:
@@ -19,7 +19,7 @@
 - name: verify setup
   assert:
     that:
-    - snap|success
+    - snap is successful
 
 - name: test fail if missing name
   action: cs_vmsnapshot
@@ -28,7 +28,7 @@
 - name: verify results of fail if missing params
   assert:
     that:
-    - snap|failed
+    - snap is failed
     - 'snap.msg.startswith("missing required arguments: ")'
 
 - name: test create snapshot in check mode
@@ -41,7 +41,7 @@
 - name: verify test create snapshot in check mode
   assert:
     that:
-    - snap|changed
+    - snap is changed
 
 - name: test create snapshot
   cs_vmsnapshot:
@@ -52,7 +52,7 @@
 - name: verify test create snapshot
   assert:
     that:
-    - snap|changed
+    - snap is changed
     - snap.display_name == "{{ cs_resource_prefix }}_snapshot"
 
 - name: test create snapshot idempotence
@@ -64,7 +64,7 @@
 - name: verify test create snapshot idempotence
   assert:
     that:
-    - not snap|changed
+    - snap is not changed
     - snap.display_name == "{{ cs_resource_prefix }}_snapshot"
 
 - name: test revert snapshot in check mode
@@ -77,7 +77,7 @@
 - name: verify test revert snapshot in check mode
   assert:
     that:
-    - snap|changed
+    - snap is changed
     - snap.display_name == "{{ cs_resource_prefix }}_snapshot"
 
 - name: test fail revert unknown snapshot
@@ -90,7 +90,7 @@
 - name: verify test fail revert unknown snapshot
   assert:
     that:
-    - snap|failed
+    - snap is failed
     - snap.msg == "snapshot not found, could not revert VM"
 
 - name: test revert snapshot
@@ -102,7 +102,7 @@
 - name: verify test revert snapshot
   assert:
     that:
-    - snap|changed
+    - snap is changed
     - snap.display_name == "{{ cs_resource_prefix }}_snapshot"
 
 - name: test remove snapshot in check mode
@@ -115,7 +115,7 @@
 - name: verify test remove snapshot in check mode
   assert:
     that:
-    - snap|changed
+    - snap is changed
     - snap.display_name == "{{ cs_resource_prefix }}_snapshot"
 
 - name: test remove snapshot
@@ -127,7 +127,7 @@
 - name: verify test remove snapshot
   assert:
     that:
-    - snap|changed
+    - snap is changed
     - snap.display_name == "{{ cs_resource_prefix }}_snapshot"
 
 - name: test remove snapshot idempotence
@@ -139,7 +139,7 @@
 - name: verify test remove snapshot idempotence
   assert:
     that:
-    - not snap|changed
+    - snap is not changed
 
 - name: cleanup instance
   cs_instance:
@@ -149,4 +149,4 @@
 - name: verify destroy instance
   assert:
     that:
-    - instance|success
+    - instance is successful