Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc

test/integration/targets/cs_router/tasks/main.yml

@@ -14,7 +14,7 @@
 - name: verify setup network
   assert:
     that:
-    - net|success
+    - net is successful
     - net.name == "net_router"
 
 - name: setup instance
@@ -29,7 +29,7 @@
 - name: verify setup instance
   assert:
     that:
-    - instance|success
+    - instance is successful
     - instance.name == "instance-vm"
     - instance.state == "Running"
 
@@ -45,7 +45,7 @@
 - name: verify setup instance
   assert:
     that:
-    - instance|success
+    - instance is successful
     - instance.name == "instance-vm"
     - instance.state == "Running"
 
@@ -73,7 +73,7 @@
 - name: verify test router started
   assert:
     that:
-    - router|success
+    - router is successful
 
 - name: test stop router in check mode
   cs_router:
@@ -85,7 +85,7 @@
 - name: verify test stop router in check mode
   assert:
     that:
-    - router|changed
+    - router is changed
     - router.state == "Running"
     - router.service_offering == "System Offering For Software Router"
 
@@ -98,7 +98,7 @@
 - name: verify test stop router
   assert:
     that:
-    - router|changed
+    - router is changed
     - router.state == "Stopped"
     - router.service_offering == "System Offering For Software Router"
 
@@ -111,7 +111,7 @@
 - name: verify test stop router idempotence
   assert:
     that:
-    - not router|changed
+    - router is not changed
     - router.state == "Stopped"
     - router.service_offering == "System Offering For Software Router"
 
@@ -125,7 +125,7 @@
 - name: verify test start router in check mode
   assert:
     that:
-    - router|changed
+    - router is changed
     - router.state == "Stopped"
     - router.service_offering == "System Offering For Software Router"
 
@@ -138,7 +138,7 @@
 - name: verify test start router
   assert:
     that:
-    - router|changed
+    - router is changed
     - router.state == "Running"
     - router.service_offering == "System Offering For Software Router"
 
@@ -151,7 +151,7 @@
 - name: verify test start router idempotence
   assert:
     that:
-    - not router|changed
+    - router is not changed
     - router.state == "Running"
     - router.service_offering == "System Offering For Software Router"
 
@@ -165,7 +165,7 @@
 - name: verify test restart router in check mode
   assert:
     that:
-    - router|changed
+    - router is changed
     - router.state == "Running"
     - router.service_offering == "System Offering For Software Router"
 
@@ -178,6 +178,6 @@
 - name: verify test restart router
   assert:
     that:
-    - router|changed
+    - router is changed
     - router.state == "Running"
     - router.service_offering == "System Offering For Software Router"