Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc
This commit is contained in:
Matt Martz 2017-11-27 16:58:08 -06:00 committed by ansibot
commit 4fe08441be
349 changed files with 4086 additions and 3844 deletions

View file

@ -7,7 +7,7 @@
- name: verify setup
assert:
that:
- role|success
- role is successful
- name: test fail if missing params
cs_role:
@ -16,7 +16,7 @@
- name: verifytest fail if missing params
assert:
that:
- role|failed
- role is failed
- "role.msg.startswith('missing required arguments: ')"
- name: test create role in check mode
@ -28,7 +28,7 @@
- name: verify test create role in check mode
assert:
that:
- role|changed
- role is changed
- name: test create role
cs_role:
@ -38,7 +38,7 @@
- name: verify test create role
assert:
that:
- role|changed
- role is changed
- role.name == '{{ cs_resource_prefix }}-role'
- role.role_type == 'DomainAdmin'
@ -50,7 +50,7 @@
- name: verify test create role idempotence
assert:
that:
- not role|changed
- role is not changed
- role.name == '{{ cs_resource_prefix }}-role'
- role.role_type == 'DomainAdmin'
@ -64,7 +64,7 @@
- name: verify test update role in check mode
assert:
that:
- role|changed
- role is changed
- role.name == '{{ cs_resource_prefix }}-role'
- "role.description is not defined"
- role.role_type == 'DomainAdmin'
@ -78,7 +78,7 @@
- name: verify test update role
assert:
that:
- role|changed
- role is changed
- role.name == '{{ cs_resource_prefix }}-role'
- role.description == '{{ cs_resource_prefix }}-role-description'
- role.role_type == 'DomainAdmin'
@ -91,7 +91,7 @@
- name: verify test update role idempotence
assert:
that:
- not role|changed
- role is not changed
- role.name == '{{ cs_resource_prefix }}-role'
- role.description == '{{ cs_resource_prefix }}-role-description'
- role.role_type == 'DomainAdmin'
@ -105,7 +105,7 @@
- name: verify test remove role in check mode
assert:
that:
- role|changed
- role is changed
- role.name == '{{ cs_resource_prefix }}-role'
- role.role_type == 'DomainAdmin'
@ -117,7 +117,7 @@
- name: verify test remove role
assert:
that:
- role|changed
- role is changed
- name: test remove role idempotence
cs_role:
@ -127,4 +127,4 @@
- name: verify test remove role idempotence
assert:
that:
- not role|changed
- role is not changed