Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc

test/integration/targets/cs_resourcelimit/tasks/cpu.yml

@@ -9,7 +9,7 @@
 - name: verify setup cpu limits account
   assert:
     that:
-    - rl|success
+    - rl is successful
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.account == "{{ cs_resource_prefix }}_user"
     - rl.limit == 20
@@ -24,7 +24,7 @@
 - name: verify setup cpu limits for domain
   assert:
     that:
-    - rl|success
+    - rl is successful
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.limit == -1
     - rl.resource_type == "cpu"
@@ -39,7 +39,7 @@
 - name: verify set cpu limits for domain in check mode
   assert:
     that:
-    - rl|changed
+    - rl is changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.limit == -1
     - rl.resource_type == "cpu"
@@ -53,7 +53,7 @@
 - name: verify set cpu limits for domain
   assert:
     that:
-    - rl|changed
+    - rl is changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.limit == 12
     - rl.resource_type == "cpu"
@@ -67,7 +67,7 @@
 - name: verify set cpu limits for domain
   assert:
     that:
-    - not rl|changed
+    - rl is not changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.limit == 12
     - rl.resource_type == "cpu"
@@ -83,7 +83,7 @@
 - name: verify set cpu limits for account in check mode
   assert:
     that:
-    - rl|changed
+    - rl is changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.account == "{{ cs_resource_prefix }}_user"
     - rl.limit == 20
@@ -99,7 +99,7 @@
 - name: verify set cpu limits for account
   assert:
     that:
-    - rl|changed
+    - rl is changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.account == "{{ cs_resource_prefix }}_user"
     - rl.limit == 10
@@ -115,7 +115,7 @@
 - name: verify set cpu limits for account idempotence
   assert:
     that:
-    - not rl|changed
+    - rl is not changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.account == "{{ cs_resource_prefix }}_user"
     - rl.limit == 10

test/integration/targets/cs_resourcelimit/tasks/instance.yml

@@ -9,7 +9,7 @@
 - name: verify setup instance limits account
   assert:
     that:
-    - rl|success
+    - rl is successful
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.account == "{{ cs_resource_prefix }}_user"
     - rl.limit == 20
@@ -25,7 +25,7 @@
 - name: verify set instance limits for domain in check mode
   assert:
     that:
-    - rl|changed
+    - rl is changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.limit == 20
     - rl.resource_type == "instance"
@@ -39,7 +39,7 @@
 - name: verify set instance limits for domain
   assert:
     that:
-    - rl|changed
+    - rl is changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.limit == 12
     - rl.resource_type == "instance"
@@ -53,7 +53,7 @@
 - name: verify set instance limits for domain
   assert:
     that:
-    - not rl|changed
+    - rl is not changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.limit == 12
     - rl.resource_type == "instance"
@@ -69,7 +69,7 @@
 - name: verify set instance limits for account in check mode
   assert:
     that:
-    - rl|changed
+    - rl is changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.account == "{{ cs_resource_prefix }}_user"
     - rl.limit != 10
@@ -85,7 +85,7 @@
 - name: verify set instance limits for account
   assert:
     that:
-    - rl|changed
+    - rl is changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.account == "{{ cs_resource_prefix }}_user"
     - rl.limit == 10
@@ -101,7 +101,7 @@
 - name: verify set instance limits for account idempotence
   assert:
     that:
-    - not rl|changed
+    - rl is not changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.account == "{{ cs_resource_prefix }}_user"
     - rl.limit == 10

test/integration/targets/cs_resourcelimit/tasks/main.yml

@@ -5,7 +5,7 @@
 - name: verify setup domain
   assert:
     that:
-    - dom|success
+    - dom is successful
 
 - name: setup account
   cs_account:
@@ -21,7 +21,7 @@
 - name: verify setup account
   assert:
     that:
-    - acc|success
+    - acc is successful
 
 - name: test failed unkonwn type
   cs_resourcelimit:
@@ -33,7 +33,7 @@
 - name: verify test failed unkonwn type
   assert:
     that:
-    - rl|failed
+    - rl is failed
 
 - name: test failed missing type
   cs_resourcelimit:
@@ -42,7 +42,7 @@
 - name: verify test failed missing type
   assert:
     that:
-    - rl|failed
+    - rl is failed
 
 - name: setup resource limits domain
   cs_resourcelimit:
@@ -53,7 +53,7 @@
 - name: verify setup resource limits domain
   assert:
     that:
-    - rl|success
+    - rl is successful
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.limit == 10
 
@@ -67,8 +67,8 @@
 - name: verify setup resource limits domain to 20 in check mode
   assert:
     that:
-    - rl|success
-    - rl|changed
+    - rl is successful
+    - rl is changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.limit == 10
 
@@ -81,8 +81,8 @@
 - name: verify setup resource limits domain to 20
   assert:
     that:
-    - rl|success
-    - rl|changed
+    - rl is successful
+    - rl is changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.limit == 20
 
@@ -95,8 +95,8 @@
 - name: verify setup resource limits domain to 20 idempotence
   assert:
     that:
-    - rl|success
-    - not rl|changed
+    - rl is successful
+    - rl is not changed
     - rl.domain == "{{ cs_resource_prefix }}-domain"
     - rl.limit == 20