Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc

test/integration/targets/cs_portforward/tasks/main.yml

@@ -9,7 +9,7 @@
 - name: verify network setup
   assert:
     that:
-    - net|success
+    - net is successful
 
 - name: instance setup
   cs_instance:
@@ -22,7 +22,7 @@
 - name: verify instance setup
   assert:
     that:
-    - instance|success
+    - instance is successful
 
 - name: public ip address setup
   cs_ip_address:
@@ -32,7 +32,7 @@
 - name: verify public ip address setup
   assert:
     that:
-    - ip_address|success
+    - ip_address is successful
 
 - name: set ip address as fact
   set_fact:
@@ -49,7 +49,7 @@
 - name: verify  clear existing port forwarding
   assert:
     that:
-    - pf|success
+    - pf is successful
 
 - name: test fail if missing params
   action: cs_portforward
@@ -58,7 +58,7 @@
 - name: verify results of fail if missing params
   assert:
     that:
-    - pf|failed
+    - pf is failed
     - 'pf.msg.startswith("missing required arguments: ")'
 
 - name: test present port forwarding in check mode
@@ -73,8 +73,8 @@
 - name: verify results of present port forwarding in check mode
   assert:
     that:
-    - pf|success
-    - pf|changed
+    - pf is successful
+    - pf is changed
 
 - name: test present port forwarding
   cs_portforward:
@@ -87,8 +87,8 @@
 - name: verify results of present port forwarding
   assert:
     that:
-    - pf|success
-    - pf|changed
+    - pf is successful
+    - pf is changed
     - pf.vm_name == "{{ cs_portforward_vm }}"
     - pf.ip_address == "{{ cs_portforward_public_ip }}"
     - pf.public_port == 80
@@ -107,8 +107,8 @@
 - name: verify results of present port forwarding idempotence
   assert:
     that:
-    - pf|success
-    - not pf|changed
+    - pf is successful
+    - pf is not changed
     - pf.vm_name == "{{ cs_portforward_vm }}"
     - pf.ip_address == "{{ cs_portforward_public_ip }}"
     - pf.public_port == 80
@@ -128,8 +128,8 @@
 - name: verify results of change port forwarding in check mode
   assert:
     that:
-    - pf|success
-    - pf|changed
+    - pf is successful
+    - pf is changed
     - pf.vm_name == "{{ cs_portforward_vm }}"
     - pf.ip_address == "{{ cs_portforward_public_ip }}"
     - pf.public_port == 80
@@ -148,8 +148,8 @@
 - name: verify results of change port forwarding
   assert:
     that:
-    - pf|success
-    - pf|changed
+    - pf is successful
+    - pf is changed
     - pf.vm_name == "{{ cs_portforward_vm }}"
     - pf.ip_address == "{{ cs_portforward_public_ip }}"
     - pf.public_port == 80
@@ -168,8 +168,8 @@
 - name: verify results of change port forwarding idempotence
   assert:
     that:
-    - pf|success
-    - not pf|changed
+    - pf is successful
+    - pf is not changed
     - pf.vm_name == "{{ cs_portforward_vm }}"
     - pf.ip_address == "{{ cs_portforward_public_ip }}"
     - pf.public_port == 80
@@ -189,8 +189,8 @@
 - name: verify results of absent port forwarding in check mode
   assert:
     that:
-    - pf|success
-    - pf|changed
+    - pf is successful
+    - pf is changed
     - pf.vm_name == "{{ cs_portforward_vm }}"
     - pf.ip_address == "{{ cs_portforward_public_ip }}"
     - pf.public_port == 80
@@ -209,8 +209,8 @@
 - name: verify results of absent port forwarding
   assert:
     that:
-    - pf|success
-    - pf|changed
+    - pf is successful
+    - pf is changed
     - pf.vm_name == "{{ cs_portforward_vm }}"
     - pf.ip_address == "{{ cs_portforward_public_ip }}"
     - pf.public_port == 80
@@ -229,8 +229,8 @@
 - name: verify results of absent port forwarding idempotence
   assert:
     that:
-    - pf|success
-    - not pf|changed
+    - pf is successful
+    - pf is not changed
 
 - name: instance cleanup
   cs_instance:
@@ -241,7 +241,7 @@
 - name: verify instance cleanup
   assert:
     that:
-    - instance|success
+    - instance is successful
 
 - name: network cleanup
   cs_network:
@@ -252,4 +252,4 @@
 - name: verify network cleanup
   assert:
     that:
-    - net|success
+    - net is successful