Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc
This commit is contained in:
Matt Martz 2017-11-27 16:58:08 -06:00 committed by ansibot
commit 4fe08441be
349 changed files with 4086 additions and 3844 deletions

View file

@ -9,7 +9,7 @@
- name: verify setup vpc
assert:
that:
- vpc|success
- vpc is successful
- name: setup network acl
cs_network_acl:
@ -20,7 +20,7 @@
- name: verify setup network acl
assert:
that:
- acl|success
- acl is successful
- name: setup network acl rule
cs_network_acl_rule:
@ -33,7 +33,7 @@
- name: verify setup network acl rule
assert:
that:
- acl_rule|success
- acl_rule is successful
- name: test fail missing params
cs_network_acl_rule:
@ -42,7 +42,7 @@
- name: verify test fail missing param
assert:
that:
- acl_rule|failed
- acl_rule is failed
- "acl_rule.msg.startswith('missing required arguments: ')"
- name: test fail missing params for tcp
@ -59,7 +59,7 @@
- name: verify test fail missing param for tcp
assert:
that:
- acl_rule|failed
- acl_rule is failed
- "acl_rule.msg == 'protocol is tcp but the following are missing: start_port, end_port'"
- name: test fail missing params for icmp
@ -77,7 +77,7 @@
- name: verify test fail missing param for icmp
assert:
that:
- acl_rule|failed
- acl_rule is failed
- "acl_rule.msg == 'protocol is icmp but the following are missing: icmp_type, icmp_code'"
- name: test fail missing params for by number
@ -95,7 +95,7 @@
- name: verify test fail missing param for by number
assert:
that:
- acl_rule|failed
- acl_rule is failed
- "acl_rule.msg == 'protocol is by_number but the following are missing: protocol_number'"
- name: test create network acl rule in check mode
@ -113,8 +113,8 @@
- name: verify test create network acl rule in check mode
assert:
that:
- acl_rule|success
- acl_rule|changed
- acl_rule is successful
- acl_rule is changed
- name: test create network acl rule
cs_network_acl_rule:
@ -130,8 +130,8 @@
- name: verify test create network acl rule
assert:
that:
- acl_rule|success
- acl_rule|changed
- acl_rule is successful
- acl_rule is changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.start_port == 80
@ -155,8 +155,8 @@
- name: verify test create network acl idempotence
assert:
that:
- acl_rule|success
- not acl_rule|changed
- acl_rule is successful
- acl_rule is not changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.start_port == 80
@ -181,8 +181,8 @@
- name: verify test change network acl rule in check mode
assert:
that:
- acl_rule|success
- acl_rule|changed
- acl_rule is successful
- acl_rule is changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.start_port == 80
@ -207,8 +207,8 @@
- name: verify test change network acl rule
assert:
that:
- acl_rule|success
- acl_rule|changed
- acl_rule is successful
- acl_rule is changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.start_port == 81
@ -234,8 +234,8 @@
- name: verify test change network acl idempotence
assert:
that:
- acl_rule|success
- not acl_rule|changed
- acl_rule is successful
- acl_rule is not changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.start_port == 81
@ -263,8 +263,8 @@
- name: verify test change network acl by protocol number in check mode
assert:
that:
- acl_rule|success
- acl_rule|changed
- acl_rule is successful
- acl_rule is changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.start_port == 81
@ -291,8 +291,8 @@
- name: verify test change network acl by protocol number
assert:
that:
- acl_rule|success
- acl_rule|changed
- acl_rule is successful
- acl_rule is changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.start_port == 81
@ -320,8 +320,8 @@
- name: verify test change network acl by protocol number idempotence
assert:
that:
- acl_rule|success
- not acl_rule|changed
- acl_rule is successful
- acl_rule is not changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.start_port == 81
@ -349,8 +349,8 @@
- name: verify test create 2nd network acl rule in check mode
assert:
that:
- acl_rule|success
- acl_rule|changed
- acl_rule is successful
- acl_rule is changed
- name: test create 2nd network acl rule
cs_network_acl_rule:
@ -366,8 +366,8 @@
- name: verify test create 2nd network acl rule
assert:
that:
- acl_rule|success
- acl_rule|changed
- acl_rule is successful
- acl_rule is changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.action_policy == "allow"
@ -390,8 +390,8 @@
- name: verify test create 2nd network acl rule idempotence
assert:
that:
- acl_rule|success
- not acl_rule|changed
- acl_rule is successful
- acl_rule is not changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.action_policy == "allow"
@ -416,8 +416,8 @@
- name: verify test create 2nd network acl rule
assert:
that:
- acl_rule|success
- acl_rule|changed
- acl_rule is successful
- acl_rule is changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.action_policy == "allow"
@ -444,8 +444,8 @@
- name: verify test create 2nd network acl rule idempotence
assert:
that:
- acl_rule|success
- not acl_rule|changed
- acl_rule is successful
- acl_rule is not changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.action_policy == "allow"
@ -468,8 +468,8 @@
- name: verify test absent network acl rule in check mode
assert:
that:
- acl_rule|success
- acl_rule|changed
- acl_rule is successful
- acl_rule is changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.start_port == 81
@ -490,8 +490,8 @@
- name: verify test absent network acl rule
assert:
that:
- acl_rule|success
- acl_rule|changed
- acl_rule is successful
- acl_rule is changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.start_port == 81
@ -512,8 +512,8 @@
- name: verify test absent network acl rule idempotence
assert:
that:
- acl_rule|success
- not acl_rule|changed
- acl_rule is successful
- acl_rule is not changed
- name: test absent 2nd network acl rule
cs_network_acl_rule:
@ -526,8 +526,8 @@
- name: verify test absent 2nd network acl rule
assert:
that:
- acl_rule|success
- acl_rule|changed
- acl_rule is successful
- acl_rule is changed
- acl_rule.vpc == "{{ cs_resource_prefix }}_vpc"
- acl_rule.network_acl == "{{ cs_resource_prefix }}_acl"
- acl_rule.action_policy == "allow"