Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc

test/integration/targets/cs_network_acl/tasks/main.yml

@@ -9,7 +9,7 @@
 - name: verify setup vpc
   assert:
     that:
-    - vpc|success
+    - vpc is successful
 
 - name: setup network acl absent
   cs_network_acl:
@@ -21,7 +21,7 @@
 - name: verify setup network acl absent
   assert:
     that:
-    - acl|success
+    - acl is successful
 
 - name: test fail missing param name and vpc for network acl
   cs_network_acl:
@@ -30,7 +30,7 @@
 - name: verify test fail missing param name and vpc for network acl
   assert:
     that:
-    - acl|failed
+    - acl is failed
     - "acl.msg.startswith('missing required arguments: ')"
 
 - name: test create network acl in check mode
@@ -43,8 +43,8 @@
 - name: verify test create network acl in check mode
   assert:
     that:
-    - acl|success
-    - acl|changed
+    - acl is successful
+    - acl is changed
 
 - name: test create network acl
   cs_network_acl:
@@ -55,8 +55,8 @@
 - name: verify test create network acl
   assert:
     that:
-    - acl|success
-    - acl|changed
+    - acl is successful
+    - acl is changed
     - acl.vpc == "{{ cs_resource_prefix }}_vpc"
     - acl.name == "{{ cs_resource_prefix }}_acl"
 
@@ -69,8 +69,8 @@
 - name: verify test create network acl idempotence
   assert:
     that:
-    - acl|success
-    - not acl|changed
+    - acl is successful
+    - acl is not changed
     - acl.vpc == "{{ cs_resource_prefix }}_vpc"
     - acl.name == "{{ cs_resource_prefix }}_acl"
 
@@ -85,8 +85,8 @@
 - name: verify test remove network acl in check mode
   assert:
     that:
-    - acl|success
-    - acl|changed
+    - acl is successful
+    - acl is changed
     - acl.vpc == "{{ cs_resource_prefix }}_vpc"
     - acl.name == "{{ cs_resource_prefix }}_acl"
 
@@ -100,8 +100,8 @@
 - name: verify test remove network acl
   assert:
     that:
-    - acl|success
-    - acl|changed
+    - acl is successful
+    - acl is changed
     - acl.vpc == "{{ cs_resource_prefix }}_vpc"
     - acl.name == "{{ cs_resource_prefix }}_acl"
 
@@ -115,5 +115,5 @@
 - name: verify test remove network acl idempotence
   assert:
     that:
-    - acl|success
-    - not acl|changed
+    - acl is successful
+    - acl is not changed