Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc

test/integration/targets/cs_instance_nic/tasks/main.yml

@@ -14,7 +14,7 @@
 - name: verify setup network
   assert:
     that:
-    - net|success
+    - net is successful
     - net.name == "net_nic"
 
 - name: setup instance
@@ -29,7 +29,7 @@
 - name: verify setup instance
   assert:
     that:
-    - instance|success
+    - instance is successful
     - instance.name == "instance-nic-vm"
     - instance.state == "Stopped"
 
@@ -48,7 +48,7 @@
 - name: verify setup network 2
   assert:
     that:
-    - net|success
+    - net is successful
     - net.name == "net_nic2"
 
 - name: setup absent nic
@@ -61,7 +61,7 @@
 - name: verify setup absent nic
   assert:
     that:
-    - nic|success
+    - nic is successful
 
 - name: test fail missing params
   cs_instance_nic:
@@ -70,7 +70,7 @@
 - name: verify test fail missing params
   assert:
     that:
-    - nic|failed
+    - nic is failed
     - "nic.msg.startswith('missing required arguments: ')"
 
 - name: test create nic in check mode
@@ -83,8 +83,8 @@
 - name: verify test create nic in check mode
   assert:
     that:
-    - nic|success
-    - nic|changed
+    - nic is successful
+    - nic is changed
     - nic.network == "net_nic2"
     - nic.vm == "instance-nic-vm"
     - nic.zone == "{{ cs_common_zone_adv }}"
@@ -99,8 +99,8 @@
 - name: verify test create nic
   assert:
     that:
-    - nic|success
-    - nic|changed
+    - nic is successful
+    - nic is changed
     - nic.ip_address == "10.100.124.42"
     - nic.netmask == "255.255.255.0"
     - nic.network == "net_nic2"
@@ -118,8 +118,8 @@
 - name: verify test create nic idempotence
   assert:
     that:
-    - nic|success
-    - not nic|changed
+    - nic is successful
+    - nic is not changed
     - nic.ip_address == "10.100.124.42"
     - nic.netmask == "255.255.255.0"
     - nic.network == "net_nic2"
@@ -136,8 +136,8 @@
 - name: verify test create nic without ip address idempotence
   assert:
     that:
-    - nic|success
-    - not nic|changed
+    - nic is successful
+    - nic is not changed
     - nic.ip_address == "10.100.124.42"
     - nic.netmask == "255.255.255.0"
     - nic.network == "net_nic2"
@@ -156,8 +156,8 @@
 - name: verify test update nic in check mode
   assert:
     that:
-    - nic|success
-    - nic|changed
+    - nic is successful
+    - nic is changed
     - nic.ip_address == "10.100.124.42"
     - nic.netmask == "255.255.255.0"
     - nic.network == "net_nic2"
@@ -175,8 +175,8 @@
 - name: verify test update nic
   assert:
     that:
-    - nic|success
-    - nic|changed
+    - nic is successful
+    - nic is changed
     - nic.ip_address == "10.100.124.23"
     - nic.netmask == "255.255.255.0"
     - nic.network == "net_nic2"
@@ -194,8 +194,8 @@
 - name: verify test update nic idempotence
   assert:
     that:
-    - nic|success
-    - not nic|changed
+    - nic is successful
+    - nic is not changed
     - nic.ip_address == "10.100.124.23"
     - nic.netmask == "255.255.255.0"
     - nic.network == "net_nic2"
@@ -212,8 +212,8 @@
 - name: verify test update nic without ip address idempotence
   assert:
     that:
-    - nic|success
-    - not nic|changed
+    - nic is successful
+    - nic is not changed
     - nic.ip_address == "10.100.124.23"
     - nic.netmask == "255.255.255.0"
     - nic.network == "net_nic2"
@@ -232,8 +232,8 @@
 - name: verify test remove nic in check mode
   assert:
     that:
-    - nic|success
-    - nic|changed
+    - nic is successful
+    - nic is changed
     - nic.ip_address == "10.100.124.23"
     - nic.netmask == "255.255.255.0"
     - nic.network == "net_nic2"
@@ -251,8 +251,8 @@
 - name: verify test remove nic
   assert:
     that:
-    - nic|success
-    - nic|changed
+    - nic is successful
+    - nic is changed
     - nic.ip_address == "10.100.124.23"
     - nic.netmask == "255.255.255.0"
     - nic.network == "net_nic2"
@@ -270,8 +270,8 @@
 - name: verify test remove nic idempotence
   assert:
     that:
-    - nic|success
-    - not nic|changed
+    - nic is successful
+    - nic is not changed
 
 - name: cleanup instance
   cs_instance:
@@ -281,7 +281,7 @@
 - name: verify cleanup instance
   assert:
     that:
-    - instance|success
+    - instance is successful
 
 - name: cleanup network
   cs_network:
@@ -292,7 +292,7 @@
 - name: verify cleanup network
   assert:
     that:
-    - net|success
+    - net is successful
 
 - name: cleanup network 2
   cs_network:
@@ -303,4 +303,4 @@
 - name: verify cleanup network 2
   assert:
     that:
-    - net|success
+    - net is successful