Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc

test/integration/targets/cs_instance_facts/tasks/main.yml

@@ -5,7 +5,7 @@
 - name: verify setup ssh key
   assert:
     that:
-    - sshkey|success
+    - sshkey is successful
 
 - name: setup affinity group
   cs_affinitygroup: name={{ cs_resource_prefix }}-ag
@@ -13,7 +13,7 @@
 - name: verify setup affinity group
   assert:
     that:
-    - ag|success
+    - ag is successful
 
 - name: setup security group
   cs_securitygroup: name={{ cs_resource_prefix }}-sg
@@ -21,7 +21,7 @@
 - name: verify setup security group
   assert:
     that:
-    - sg|success
+    - sg is successful
 
 - name: setup instance
   cs_instance:
@@ -36,7 +36,7 @@
 - name: verify create instance
   assert:
     that:
-    - instance|success
+    - instance is successful
 
 - name: test instance facts in check mode
   cs_instance_facts:
@@ -46,8 +46,8 @@
 - name: verify test instance facts in check mode
   assert:
     that:
-    - instance_facts|success
-    - not instance_facts|changed
+    - instance_facts is successful
+    - instance_facts is not changed
     - cloudstack_instance.id == instance.id
     - cloudstack_instance.domain == instance.domain
     - cloudstack_instance.account == instance.account
@@ -62,8 +62,8 @@
 - name: verify test instance facts
   assert:
     that:
-    - instance_facts|success
-    - not instance_facts|changed
+    - instance_facts is successful
+    - instance_facts is not changed
     - cloudstack_instance.id == instance.id
     - cloudstack_instance.domain == instance.domain
     - cloudstack_instance.account == instance.account