Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc

test/integration/targets/cs_instance/tasks/absent.yml

@@ -8,8 +8,8 @@
 - name: verify destroy instance in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.state != "Destroyed"
 
 - name: test destroy instance
@@ -20,8 +20,8 @@
 - name: verify destroy instance
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.state == "Destroyed"
 
 - name: test destroy instance idempotence
@@ -32,8 +32,8 @@
 - name: verify destroy instance idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
 
 - name: test recover to stopped state and update a deleted instance in check mode
   cs_instance:
@@ -45,8 +45,8 @@
 - name: verify test recover to stopped state and update a deleted instance in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
 
 - name: test recover to stopped state and update a deleted instance
   cs_instance:
@@ -57,8 +57,8 @@
 - name: verify test recover to stopped state and update a deleted instance
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.state == "Stopped"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
 
@@ -71,8 +71,8 @@
 - name: verify test recover to stopped state and update a deleted instance idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.state == "Stopped"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
 
@@ -85,8 +85,8 @@
 - name: verify test expunge instance in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.state == "Stopped"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
 
@@ -98,8 +98,8 @@
 - name: verify test expunge instance
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.state == "Stopped"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
 
@@ -111,5 +111,5 @@
 - name: verify test expunge instance idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed

test/integration/targets/cs_instance/tasks/absent_display_name.yml

@@ -7,8 +7,8 @@
 - name: verify destroy instance with display_name
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.state == "Destroyed"
 
 - name: test destroy instance with display_name idempotence
@@ -19,8 +19,8 @@
 - name: verify destroy instance with display_name idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
 
 - name: test recover to stopped state and update a deleted instance with display_name
   cs_instance:
@@ -31,8 +31,8 @@
 - name: verify test recover to stopped state and update a deleted instance with display_name
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.state == "Stopped"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
 

test/integration/targets/cs_instance/tasks/cleanup.yml

@@ -5,26 +5,26 @@
 - name: verify cleanup ssh key
   assert:
     that:
-    - sshkey|success
+    - sshkey is successful
 
 - name: cleanup affinity group
   cs_affinitygroup: name={{ cs_resource_prefix }}-ag state=absent
   register: ag
-  until: ag|success
+  until: ag is successful
   retries: 20
   delay: 5
 - name: verify cleanup affinity group
   assert:
     that:
-    - ag|success
+    - ag is successful
 
 - name: cleanup security group ...take a while unless instance is expunged
   cs_securitygroup: name={{ cs_resource_prefix }}-sg state=absent
   register: sg
-  until: sg|success
+  until: sg is successful
   retries: 100
   delay: 10
 - name: verify cleanup security group
   assert:
     that:
-    - sg|success
+    - sg is successful

test/integration/targets/cs_instance/tasks/present.yml

@@ -5,7 +5,7 @@
 - name: verify instance to be absent
   assert:
     that:
-    - instance|success
+    - instance is successful
 
 - name: test create instance in check mode
   cs_instance:
@@ -21,8 +21,8 @@
 - name: verify create instance in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
 
 - name: test create instance
   cs_instance:
@@ -37,8 +37,8 @@
 - name: verify create instance
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -59,8 +59,8 @@
 - name: verify create instance idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -77,8 +77,8 @@
 - name: verify running instance not updated in check mode
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -93,8 +93,8 @@
 - name: verify running instance not updated
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -109,8 +109,8 @@
 - name: verify stopping instance in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -124,8 +124,8 @@
 - name: verify stopping instance
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -139,8 +139,8 @@
 - name: verify stopping instance idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.state == "Stopped"
 
 - name: test updating stopped instance in check mode
@@ -153,8 +153,8 @@
 - name: verify updating stopped instance in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -169,8 +169,8 @@
 - name: verify updating stopped instance
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_2 }}"
@@ -185,8 +185,8 @@
 - name: verify updating stopped instance idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_2 }}"
@@ -201,8 +201,8 @@
 - name: verify starting instance in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_2 }}"
@@ -216,8 +216,8 @@
 - name: verify starting instance
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_2 }}"
@@ -231,8 +231,8 @@
 - name: verify starting instance idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_2 }}"
@@ -248,8 +248,8 @@
 - name: verify force update running instance in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_2 }}"
@@ -264,8 +264,8 @@
 - name: verify force update running instance
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -280,8 +280,8 @@
 - name: verify force update running instance idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -297,8 +297,8 @@
 - name: verify restore instance in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
@@ -312,8 +312,8 @@
 - name: verify restore instance
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"

test/integration/targets/cs_instance/tasks/present_display_name.yml

@@ -5,7 +5,7 @@
 - name: verify instance with display_name to be absent
   assert:
     that:
-    - instance|success
+    - instance is successful
 
 - name: test create instance with display_name
   cs_instance:
@@ -20,8 +20,8 @@
 - name: verify create instance with display_name
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
     - instance.state == "Running"
@@ -41,8 +41,8 @@
 - name: verify create instance with display_name idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
     - instance.state == "Running"
@@ -57,8 +57,8 @@
 - name: verify running instance with display_name not updated
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
     - instance.state == "Running"
@@ -71,8 +71,8 @@
 - name: verify stopping instance with display_name
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
     - instance.state == "Stopped"
@@ -85,8 +85,8 @@
 - name: verify stopping instance idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.state == "Stopped"
 
 - name: test updating stopped instance with display_name
@@ -97,8 +97,8 @@
 - name: verify updating stopped instance with display_name
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_2 }}"
     - instance.state == "Stopped"
@@ -111,8 +111,8 @@
 - name: verify starting instance with display_name
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_2 }}"
     - instance.state == "Running"
@@ -125,8 +125,8 @@
 - name: verify starting instance with display_name idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_2 }}"
     - instance.state == "Running"
@@ -140,8 +140,8 @@
 - name: verify force update running instance with display_name
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
     - instance.state == "Running"
@@ -155,8 +155,8 @@
 - name: verify force update running instance with display_name idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
     - instance.state == "Running"
@@ -170,7 +170,7 @@
 - name: verify restore instance with display_name
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"

test/integration/targets/cs_instance/tasks/project.yml

@@ -6,7 +6,7 @@
 - name: verify test create project
   assert:
     that:
-    - prj|success
+    - prj is successful
 
 - name: setup instance in project to be absent
   cs_instance:
@@ -17,7 +17,7 @@
 - name: verify instance in project to be absent
   assert:
     that:
-    - instance|success
+    - instance is successful
 
 - name: setup ssh key in project
   cs_sshkeypair:
@@ -27,7 +27,7 @@
 - name: verify setup ssh key in project
   assert:
     that:
-    - sshkey|success
+    - sshkey is successful
 
 - name: setup affinity group in project
   cs_affinitygroup:
@@ -37,7 +37,7 @@
 - name: verify setup affinity group in project
   assert:
     that:
-    - ag|success
+    - ag is successful
 
 - name: setup security group in project
   cs_securitygroup:
@@ -47,7 +47,7 @@
 - name: verify setup security group in project
   assert:
     that:
-    - sg|success
+    - sg is successful
 
 - name: test create instance in project in check mode
   cs_instance:
@@ -64,8 +64,8 @@
 - name: verify create instance in project in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
 
 - name: test create instance in project
   cs_instance:
@@ -81,8 +81,8 @@
 - name: verify create instance in project
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
@@ -105,8 +105,8 @@
 - name: verify create instance in project idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
@@ -125,8 +125,8 @@
 - name: verify running instance in project not updated in check mode
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
@@ -143,8 +143,8 @@
 - name: verify running instance in project not updated
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
@@ -161,8 +161,8 @@
 - name: verify stopping instance in project in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
@@ -178,8 +178,8 @@
 - name: verify stopping instance
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
@@ -195,8 +195,8 @@
 - name: verify stopping instance in project idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.state == "Stopped"
 
 - name: test updating stopped instance in project in check mode
@@ -210,8 +210,8 @@
 - name: verify updating stopped instance in project in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
@@ -228,8 +228,8 @@
 - name: verify updating stopped instance
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
@@ -246,8 +246,8 @@
 - name: verify updating stopped instance in project idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
@@ -264,8 +264,8 @@
 - name: verify starting instance in project in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
@@ -281,8 +281,8 @@
 - name: verify starting instance
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
@@ -298,8 +298,8 @@
 - name: verify starting instance in project idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
@@ -317,8 +317,8 @@
 - name: verify force update running instance in project in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
@@ -335,8 +335,8 @@
 - name: verify force update running instance
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
@@ -353,8 +353,8 @@
 - name: verify force update running instance in project idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
@@ -372,8 +372,8 @@
 - name: verify restore instance in project in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
@@ -389,8 +389,8 @@
 - name: verify restore instance in project
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.name == "{{ cs_resource_prefix }}-vm-{{ instance_number }}"
     - instance.project == "{{ cs_resource_prefix }}-prj"
     - instance.display_name == "{{ cs_resource_prefix }}-display-{{ instance_number }}"
@@ -406,8 +406,8 @@
 - name: verify destroy instance in project in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.state != "Destroyed"
 
 - name: test destroy instance in project
@@ -419,8 +419,8 @@
 - name: verify destroy instance in project
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.state == "Destroyed"
 
 - name: test destroy instance in project idempotence
@@ -432,8 +432,8 @@
 - name: verify destroy instance in project idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
 
 - name: test recover in project to stopped state and update a deleted instance in project in check mode
   cs_instance:
@@ -446,8 +446,8 @@
 - name: verify test recover to stopped state and update a deleted instance in project in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
 
 - name: test recover to stopped state and update a deleted instance in project
   cs_instance:
@@ -459,8 +459,8 @@
 - name: verify test recover to stopped state and update a deleted instance in project
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.state == "Stopped"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
 
@@ -474,8 +474,8 @@
 - name: verify test recover to stopped state and update a deleted instance in project idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.state == "Stopped"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
 
@@ -489,8 +489,8 @@
 - name: verify test expunge instance in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.state == "Stopped"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
 
@@ -503,8 +503,8 @@
 - name: verify test expunge instance in project
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.state == "Stopped"
     - instance.service_offering == "{{ test_cs_instance_offering_1 }}"
 
@@ -517,8 +517,8 @@
 - name: verify test expunge instance in project idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
 
 - name: cleanup ssh key in project
   cs_sshkeypair:
@@ -529,7 +529,7 @@
 - name: verify cleanup ssh key in project
   assert:
     that:
-    - sshkey|success
+    - sshkey is successful
 
 - name: cleanup affinity group in project
   cs_affinitygroup:
@@ -537,13 +537,13 @@
     project: "{{ cs_resource_prefix }}-prj"
     state: absent
   register: ag
-  until: ag|success
+  until: ag is successful
   retries: 20
   delay: 5
 - name: verify cleanup affinity group in project
   assert:
     that:
-    - ag|success
+    - ag is successful
 
 - name: cleanup security group in project ...take a while unless instance in project is expunged
   cs_securitygroup:
@@ -551,10 +551,10 @@
     project: "{{ cs_resource_prefix }}-prj"
     state: absent
   register: sg
-  until: sg|success
+  until: sg is successful
   retries: 100
   delay: 10
 - name: verify cleanup security group in project
   assert:
     that:
-    - sg|success
+    - sg is successful

test/integration/targets/cs_instance/tasks/setup.yml

@@ -5,7 +5,7 @@
 - name: verify setup ssh key
   assert:
     that:
-    - sshkey|success
+    - sshkey is successful
 
 - name: setup affinity group
   cs_affinitygroup: name={{ cs_resource_prefix }}-ag
@@ -13,7 +13,7 @@
 - name: verify setup affinity group
   assert:
     that:
-    - ag|success
+    - ag is successful
 
 - name: setup security group
   cs_securitygroup: name={{ cs_resource_prefix }}-sg
@@ -21,4 +21,4 @@
 - name: verify setup security group
   assert:
     that:
-    - sg|success
+    - sg is successful

test/integration/targets/cs_instance/tasks/sshkeys.yml

@@ -10,7 +10,7 @@
 - name: verify  update instance ssh key non existent
   assert:
     that:
-    - instance|failed
+    - instance is failed
     - 'instance.msg == "SSH key not found: {{ cs_resource_prefix }}-sshkey2"'
 
 - name: test create instance without keypair in check mode
@@ -23,8 +23,8 @@
 - name: verify create instance without keypair in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
 
 - name: test create instance without keypair
   cs_instance:
@@ -35,8 +35,8 @@
 - name: verify create instance without keypair
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.ssh_key is not defined
 
 - name: test create instance without keypair idempotence
@@ -48,8 +48,8 @@
 - name: verify create instance without keypair idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.ssh_key is not defined
 
 - name: setup ssh key2
@@ -58,7 +58,7 @@
 - name: verify setup ssh key2
   assert:
     that:
-    - sshkey|success
+    - sshkey is successful
 
 - name: test update instance ssh key2 in check mode
   cs_instance:
@@ -70,7 +70,7 @@
 - name: verify update instance ssh key2 in check mode
   assert:
     that:
-    - instance|changed
+    - instance is changed
     - instance.ssh_key is not defined
 
 - name: test update instance ssh key2
@@ -82,7 +82,7 @@
 - name: verify update instance ssh key2
   assert:
     that:
-    - instance|changed
+    - instance is changed
     - instance.ssh_key == "{{ cs_resource_prefix }}-sshkey2"
 
 - name: test update instance ssh key2 idempotence
@@ -94,7 +94,7 @@
 - name: verify update instance ssh key2 idempotence
   assert:
     that:
-    - not instance|changed
+    - instance is not changed
     - instance.ssh_key == "{{ cs_resource_prefix }}-sshkey2"
 
 - name: cleanup ssh key2
@@ -105,7 +105,7 @@
 - name: verify cleanup ssh key2
   assert:
     that:
-    - sshkey2|success
+    - sshkey2 is successful
 
 - name: test update instance ssh key2 idempotence2
   cs_instance:
@@ -117,7 +117,7 @@
 - name: verify update instance ssh key2 idempotence2
   assert:
     that:
-    - instance|failed
+    - instance is failed
     - 'instance.msg == "SSH key not found: {{ cs_resource_prefix }}-sshkey2"'
 
 - name: test update instance ssh key in check mode
@@ -130,7 +130,7 @@
 - name: verify update instance ssh key in check mode
   assert:
     that:
-    - instance|changed
+    - instance is changed
     - instance.ssh_key is not defined
 
 - name: test update instance ssh key
@@ -142,7 +142,7 @@
 - name: verify update instance ssh key
   assert:
     that:
-    - instance|changed
+    - instance is changed
     - instance.ssh_key == "{{ cs_resource_prefix }}-sshkey"
 
 - name: test update instance ssh key idempotence
@@ -154,7 +154,7 @@
 - name: verify update instance ssh key idempotence
   assert:
     that:
-    - not instance|changed
+    - instance is not changed
     - instance.ssh_key == "{{ cs_resource_prefix }}-sshkey"
 
 - name: cleanup expunge instance
@@ -165,4 +165,4 @@
 - name: verify cleanup expunge instance
   assert:
     that:
-    - instance|success
+    - instance is successful

test/integration/targets/cs_instance/tasks/tags.yml

@@ -12,8 +12,8 @@
 - name: verify add tags to instance in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - not instance.tags
 
 - name: test add tags to instance
@@ -28,8 +28,8 @@
 - name: verify add tags to instance
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.tags|length == 2
     - "instance.tags[0]['key'] in [ '{{ cs_resource_prefix }}-tag2', '{{ cs_resource_prefix }}-tag1' ]"
     - "instance.tags[1]['key'] in [ '{{ cs_resource_prefix }}-tag2', '{{ cs_resource_prefix }}-tag1' ]"
@@ -46,8 +46,8 @@
 - name: verify tags to instance idempotence
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.tags|length == 2
     - "instance.tags[0]['key'] in [ '{{ cs_resource_prefix }}-tag2', '{{ cs_resource_prefix }}-tag1' ]"
     - "instance.tags[1]['key'] in [ '{{ cs_resource_prefix }}-tag2', '{{ cs_resource_prefix }}-tag1' ]"
@@ -65,8 +65,8 @@
 - name: verify tags to instance idempotence in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.tags|length == 2
     - "instance.tags[0]['key'] in [ '{{ cs_resource_prefix }}-tag2', '{{ cs_resource_prefix }}-tag1' ]"
     - "instance.tags[1]['key'] in [ '{{ cs_resource_prefix }}-tag2', '{{ cs_resource_prefix }}-tag1' ]"
@@ -83,8 +83,8 @@
 - name: verify tags to instance idempotence
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.tags|length == 2
     - "instance.tags[0]['key'] in [ '{{ cs_resource_prefix }}-tag2', '{{ cs_resource_prefix }}-tag3' ]"
     - "instance.tags[1]['key'] in [ '{{ cs_resource_prefix }}-tag2', '{{ cs_resource_prefix }}-tag3' ]"
@@ -98,8 +98,8 @@
 - name: verify not touch tags of instance if no param tags
   assert:
     that:
-    - instance|success
-    - not instance|changed
+    - instance is successful
+    - instance is not changed
     - instance.tags|length == 2
     - "instance.tags[0]['key'] in [ '{{ cs_resource_prefix }}-tag2', '{{ cs_resource_prefix }}-tag3' ]"
     - "instance.tags[1]['key'] in [ '{{ cs_resource_prefix }}-tag2', '{{ cs_resource_prefix }}-tag3' ]"
@@ -115,8 +115,8 @@
 - name: verify remove tags in check mode
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.tags|length != 0
 
 - name: test remove tags
@@ -127,6 +127,6 @@
 - name: verify remove tags
   assert:
     that:
-    - instance|success
-    - instance|changed
+    - instance is successful
+    - instance is changed
     - instance.tags|length == 0