Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc
This commit is contained in:
Matt Martz 2017-11-27 16:58:08 -06:00 committed by ansibot
commit 4fe08441be
349 changed files with 4086 additions and 3844 deletions

View file

@ -7,7 +7,7 @@
- name: verify setup cluster is absent
assert:
that:
- cluster|success
- cluster is successful
- name: setup zone is present
cs_zone:
@ -19,7 +19,7 @@
- name: verify setup zone is present
assert:
that:
- zone|success
- zone is successful
- name: setup pod is present
cs_pod:
@ -32,7 +32,7 @@
- name: verify setup pod is present
assert:
that:
- pod|success
- pod is successful
- name: test fail if missing name
cs_cluster:
@ -41,7 +41,7 @@
- name: verify results of fail if missing name
assert:
that:
- cluster|failed
- cluster is failed
- "cluster.msg == 'missing required arguments: name'"
- name: test fail if pod not found
@ -56,7 +56,7 @@
- name: verify results of fail if missing name
assert:
that:
- cluster|failed
- cluster is failed
- "cluster.msg == 'Pod unexistent not found in zone {{ cs_resource_prefix }}-zone'"
- name: test create cluster in check mode
@ -71,7 +71,7 @@
- name: verify test create cluster in check mode
assert:
that:
- cluster_origin|changed
- cluster_origin is changed
- name: test create cluster
cs_cluster:
@ -84,7 +84,7 @@
- name: verify test create cluster
assert:
that:
- cluster_origin|changed
- cluster_origin is changed
- cluster_origin.name == "{{ cs_resource_prefix }}-cluster"
- cluster_origin.zone == "{{ cs_resource_prefix }}-zone"
- cluster_origin.allocation_state == "Enabled"
@ -102,7 +102,7 @@
assert:
that:
- cluster.id == cluster_origin.id
- not cluster|changed
- cluster is not changed
- cluster.name == "{{ cs_resource_prefix }}-cluster"
- cluster.zone == "{{ cs_resource_prefix }}-zone"
- cluster.allocation_state == "Enabled"
@ -120,7 +120,7 @@
- name: verify test update cluster in check mode
assert:
that:
- cluster|changed
- cluster is changed
- cluster.name == "{{ cs_resource_prefix }}-cluster"
- cluster.zone == "{{ cs_resource_prefix }}-zone"
- cluster.allocation_state == "Enabled"
@ -138,7 +138,7 @@
- name: verify test update cluster
assert:
that:
- cluster|changed
- cluster is changed
- cluster.name == "{{ cs_resource_prefix }}-cluster"
- cluster.zone == "{{ cs_resource_prefix }}-zone"
- cluster.allocation_state == "Enabled"
@ -156,7 +156,7 @@
- name: verify test update cluster idempotence
assert:
that:
- not cluster|changed
- cluster is not changed
- cluster.name == "{{ cs_resource_prefix }}-cluster"
- cluster.zone == "{{ cs_resource_prefix }}-zone"
- cluster.allocation_state == "Enabled"
@ -173,7 +173,7 @@
- name: verify test disable cluster in check mode
assert:
that:
- cluster|changed
- cluster is changed
- cluster.name == "{{ cs_resource_prefix }}-cluster"
- cluster.zone == "{{ cs_resource_prefix }}-zone"
- cluster.allocation_state == "Enabled"
@ -189,7 +189,7 @@
- name: verify test disable cluster
assert:
that:
- cluster|changed
- cluster is changed
- cluster.name == "{{ cs_resource_prefix }}-cluster"
- cluster.zone == "{{ cs_resource_prefix }}-zone"
- cluster.allocation_state == "Disabled"
@ -205,7 +205,7 @@
- name: verify test disable cluster idempotence
assert:
that:
- not cluster|changed
- cluster is not changed
- cluster.name == "{{ cs_resource_prefix }}-cluster"
- cluster.zone == "{{ cs_resource_prefix }}-zone"
- cluster.allocation_state == "Disabled"
@ -221,7 +221,7 @@
- name: verify test enable cluster in check mode
assert:
that:
- cluster|changed
- cluster is changed
- cluster.name == "{{ cs_resource_prefix }}-cluster"
- cluster.zone == "{{ cs_resource_prefix }}-zone"
- cluster.allocation_state == "Disabled"
@ -237,7 +237,7 @@
- name: verify test enable cluster
assert:
that:
- cluster|changed
- cluster is changed
- cluster.name == "{{ cs_resource_prefix }}-cluster"
- cluster.zone == "{{ cs_resource_prefix }}-zone"
- cluster.allocation_state == "Enabled"
@ -253,7 +253,7 @@
- name: verify test enable cluster idempotence
assert:
that:
- not cluster|changed
- cluster is not changed
- cluster.name == "{{ cs_resource_prefix }}-cluster"
- cluster.zone == "{{ cs_resource_prefix }}-zone"
- cluster.allocation_state == "Enabled"
@ -272,7 +272,7 @@
assert:
that:
- cluster.id == cluster_origin.id
- cluster|changed
- cluster is changed
- cluster.name == "{{ cs_resource_prefix }}-cluster"
- cluster.zone == "{{ cs_resource_prefix }}-zone"
- cluster.allocation_state == "Enabled"
@ -288,7 +288,7 @@
assert:
that:
- cluster.id == cluster_origin.id
- cluster|changed
- cluster is changed
- cluster.name == "{{ cs_resource_prefix }}-cluster"
- cluster.zone == "{{ cs_resource_prefix }}-zone"
- cluster.allocation_state == "Enabled"
@ -303,4 +303,4 @@
- name: verify test remove cluster idempotence
assert:
that:
- not cluster|changed
- cluster is not changed