Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc
This commit is contained in:
Matt Martz 2017-11-27 16:58:08 -06:00 committed by ansibot
commit 4fe08441be
349 changed files with 4086 additions and 3844 deletions

View file

@ -5,7 +5,7 @@
- name: verify setup
assert:
that:
- acc|success
- acc is successful
- name: test fail if missing name
action: cs_account
@ -14,7 +14,7 @@
- name: verify results of fail if missing params
assert:
that:
- acc|failed
- acc is failed
- 'acc.msg == "missing required arguments: name"'
- name: test fail if missing params if state=present
@ -25,7 +25,7 @@
- name: verify results of fail if missing params if state=present
assert:
that:
- acc|failed
- acc is failed
- 'acc.msg == "missing required arguments: email, username, password, first_name, last_name"'
- name: test create user account in check mode
@ -42,8 +42,8 @@
- name: verify results of create account in check mode
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- name: test create user account
cs_account:
@ -58,8 +58,8 @@
- name: verify results of create account
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -79,8 +79,8 @@
- name: verify results of create account idempotence
assert:
that:
- acc|success
- not acc|changed
- acc is successful
- acc is not changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -96,8 +96,8 @@
- name: verify results of lock user account in check mode
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -112,8 +112,8 @@
- name: verify results of lock user account
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -128,8 +128,8 @@
- name: verify results of lock user account idempotence
assert:
that:
- acc|success
- not acc|changed
- acc is successful
- acc is not changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -145,8 +145,8 @@
- name: verify results of disable user account in check mode
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -161,8 +161,8 @@
- name: verify results of disable user account
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -177,8 +177,8 @@
- name: verify results of disable user account idempotence
assert:
that:
- acc|success
- not acc|changed
- acc is successful
- acc is not changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -194,8 +194,8 @@
- name: verify results of lock disabled user account in check mode
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -210,8 +210,8 @@
- name: verify results of lock disabled user account
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -226,8 +226,8 @@
- name: verify results of lock disabled user account idempotence
assert:
that:
- acc|success
- not acc|changed
- acc is successful
- acc is not changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -243,8 +243,8 @@
- name: verify results of enable user account in check mode
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -259,8 +259,8 @@
- name: verify results of enable user account
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -275,8 +275,8 @@
- name: verify results of enable user account idempotence
assert:
that:
- acc|success
- not acc|changed
- acc is successful
- acc is not changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -292,8 +292,8 @@
- name: verify results of remove user account in check mode
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -308,8 +308,8 @@
- name: verify results of remove user account
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -324,8 +324,8 @@
- name: verify results of remove user account idempotence
assert:
that:
- acc|success
- not acc|changed
- acc is successful
- acc is not changed
- name: test create user disabled account
cs_account:
@ -341,8 +341,8 @@
- name: verify results of create disabled account
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -357,8 +357,8 @@
- name: verify results of remove disabled user account
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -379,8 +379,8 @@
- name: verify results of create locked account
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -395,8 +395,8 @@
- name: verify results of remove locked user account
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -417,8 +417,8 @@
- name: verify results of create unlocked/enabled account
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"
@ -433,8 +433,8 @@
- name: verify results of remove unlocked/enabled user account
assert:
that:
- acc|success
- acc|changed
- acc is successful
- acc is changed
- acc.name == "{{ cs_resource_prefix }}_user"
- acc.network_domain == "example.com"
- acc.account_type == "user"